Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6258779rwb; Wed, 18 Jan 2023 03:12:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXuRhT7k729DaV7c1d96fYEPh35bROPfHjryELpoPk0SBMQA2IF0l4g7oEFe4fVU3TMvPeJb X-Received: by 2002:a17:90a:3cc4:b0:225:d450:2ccc with SMTP id k4-20020a17090a3cc400b00225d4502cccmr6450442pjd.30.1674040350231; Wed, 18 Jan 2023 03:12:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674040350; cv=none; d=google.com; s=arc-20160816; b=SRWtlRBQSNsfYNaDHEhC2g5nW+C5XU2u7qTx+MUpTkkV4jkgHwC7HcMvK5mON150+r nhjfb2XF/dldJFxQH5dI9Xg6fugx/TU5jvMYx+Jsoj+MPFc+MtFmIBESdYUBC22KMvKC BreoE4qZ82sr335nJ93vmlGE0cmo548DQBtWJhKVw+1Uixhea/+lbmrU1A+prUgKEV7E +mNbliJHNLs0AdT7D2kWn8m+DhLkIZWDXvIApuYKJFYp9y28dRVKs6R66qhjpuXJUF4a sTe1OS/lJ47Ma2TJSA1LfytXlvNu71ZwGxU+lwNHqBrFuiGIne9WYXJo7hu44AiDNe88 slBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yZCBSoc669Nnqq+G8r/cQW/++tfWj88n4rotdNNYM1A=; b=Gegd7w7UUUe9LXUvOOoTDZ0BSjk+rhWiLeXSdAgEyZyHA+YXeBiKEUJLC5h8oJxCbb Iv+20G0iDQORN2+ufRPNCrp4VT/0tPz4emx+5oU2G6iW7wlOOhJ5L+tbf+0ZzjNVJaM3 mq6wq7GVLoyU3XvMeSQnKzce+NbuhK2GR73SZQ3ePa+BxbbbdDx9RkLQkveYYWOPEfRv 497alSok9TlhSiLX0f/DNQmFC9sPl774+FpZe/mMKbmhqfK/RXciYHf1QPuqCFInXB0k 5Q4uNGzZM8RXp3p4/Ting9LMTDdGZ+LFGu2kyOG9ntQ3fc16piyTq0W3L9DrTENSI/9S MZSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UefuBp1N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ct1-20020a17090af58100b002270156c063si1796062pjb.37.2023.01.18.03.12.23; Wed, 18 Jan 2023 03:12:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UefuBp1N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbjARKxc (ORCPT + 45 others); Wed, 18 Jan 2023 05:53:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230471AbjARKvA (ORCPT ); Wed, 18 Jan 2023 05:51:00 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F289A45F40; Wed, 18 Jan 2023 02:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674036041; x=1705572041; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=2kzgrBUfMBAY/+H5vDRwbImFOagJJve1sIaVm+YscYE=; b=UefuBp1NLFFuMnkqf4VPFFpP4d3UJcidkltE1mvqxinv8jl4A6c8nClB T/QhABpFTbDLwlDGaQZ2X5X1D0Q0PkSWhbybz5Hcq93bDo4sJBSBRTId0 ESZnsivQgU+vo0zyuHyNQJEkzWSuR9qgH7STZv8Gxc6LYcihYzMApuNFO RvTVcQy0+ZZ/PZ/VWZHr0zcy4V46jEMi1RVcxJbre1vMOeImwM66cgvnH 8Yv9RwUNjAuBaZ4v3KYlUAYkvN0DYVi/BPOKRo042Vcw0qPeORPIm7VbV 0ksrLCqEU9J1gSgCGiHeTnmV2jzH29Pb93HoTI+pwYsKO2lrlQgBiC3+Q Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="308508848" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="308508848" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 02:00:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="783612749" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="783612749" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 18 Jan 2023 02:00:38 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pI5FF-00B6yP-0G; Wed, 18 Jan 2023 12:00:37 +0200 Date: Wed, 18 Jan 2023 12:00:36 +0200 From: Andy Shevchenko To: Jiri Kosina Cc: Dmitry Torokhov , Raul E Rangel , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] HID: i2c-hid: acpi: Drop unneded NULL check of adev Message-ID: References: <20230116154621.16135-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2023 at 10:06:32AM +0100, Jiri Kosina wrote: > On Mon, 16 Jan 2023, Andy Shevchenko wrote: > > > The driver is enumerated on ACPI platforms, so adev is valid. > > Since there is no valid I?C ID table provided, there is no > > possibility to bind a device to this driver via user space. > > Hence, drop unneeded NULL check of adev. > > > > Signed-off-by: Andy Shevchenko > > Applied both to hid.git#for-6.3/i2c-hid. Thanks, Thank you and HNY! -- With Best Regards, Andy Shevchenko