Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 12:11:36 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Hayes Wang <hayeswang@realtek.com>
Cc:     kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
        nic_swsd@realtek.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, bjorn@mork.no
Subject: Re: [PATCH net-next v2] r8152: avoid to change cfg for all devices
Message-ID: <Y8fT6JN5uHtP4Pws@corigine.com>
References: <20230116075951.1988-1-hayeswang@realtek.com>
 <20230117030344.4581-396-nic_swsd@realtek.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230117030344.4581-396-nic_swsd@realtek.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S037WAUdv020xbSTpWBtT4o/Ll20WjxTXcgG5+grMFU/oFCbVqrWLBXtWoux?=
 =?us-ascii?Q?4I6K6rNiYFWXxdFaQOJZM8jVnyurW735v3dg7GZE56u04mJC8ewLo5eVKkMA?=
 =?us-ascii?Q?MFXqzbjrrUSYSF2sePU4LDHu8LZalYLn3eJO7tkWR/penjsLJz1JOdgIF5kb?=
 =?us-ascii?Q?zhdRSEjqpb0GQQMhajEWwsPnh33oICf9/7EQyQEbr+g1hPVYSzrFvP00lWJJ?=
 =?us-ascii?Q?TZmeIcbdWw4hHmtHtw8OS7rCpzEUs64lvot55MPV/wjV8r9csbkNQH6o3eEn?=
 =?us-ascii?Q?s6BZiYjQ8LxJVMWLQnv3E2qpsXMPI336Sm+OFFvXQ2QhVKFoqDfZKBgb4nYi?=
 =?us-ascii?Q?WOBi9hIStYtWlJFGVTKnBJ1FiYo5dvsQczP3BHdsWXXhhbmyWEzq8MloGgs2?=
 =?us-ascii?Q?y2aBvbLFOySxon/QTpnDQn8SvAbxhTBoB1blpxnuHO/3yo09zmyTj7vB2mdP?=
 =?us-ascii?Q?Vp/m/Szl5wkTbCxJfnqbZRbKY0+RpQ6hsvnQ9tqJWyGpXmrAwgVzrSifEhAF?=
 =?us-ascii?Q?b4ouCwRxZcxvGDTS4Bc88m1bx8cGOD8D3ZwLbPJ4sEAhQk0HKAmKnb6mnDNw?=
 =?us-ascii?Q?PK8HiLxxSbsdHhLcJSk/t/etXSBU+2TY2zZGZid3dAm+eNdfUzsMmdagKjqC?=
 =?us-ascii?Q?n37xHAqyDyEFUlBlf0r85j1MwKPBPzO9xtV1uKc87jDyRHqRQoJBM9U1hSCp?=
 =?us-ascii?Q?QfMPxeXaOcRbWGxWVPGgvLVPsIKE6HCohnxqJ8MRSLvetOMYsqiZtmrYj/yM?=
 =?us-ascii?Q?+CHkI1ZJRNIQFNBkucTO2yLAgtRLdYc+r/Xc0hPqJKdO28XYsqqkJzjkRtxK?=
 =?us-ascii?Q?XKVdXd3y+PpIJbyzyFUru8uZE2o0vzde54P5a6xtfhyiGXzx0ZQnkaGyIUG+?=
 =?us-ascii?Q?XOOd7ulCtPAZxMtLWz3YJUL0NOrgFYV46BZzORU0cT63Iy6I1BBZz1o7NEYx?=
 =?us-ascii?Q?hALronjYsEj95jdD4CNZddFzqlwuMN4FOZHWP6sjNOX7MhGNFJWgIe0cckV8?=
 =?us-ascii?Q?YNE01Lx8PjMEF8GUKI7dtxBpcpTGHyO8/yNC9At3HFDdzhzA9ZFysiGODR1Z?=
 =?us-ascii?Q?VPkdNzDvQmgjip0Mz5GpAEZ1IDu/s7+pjd14Rz4sHNSLMaFKc48GP74qf/K6?=
 =?us-ascii?Q?q6lZWopHgogZDBn4hp+u147o4ySrHwUUnRaZ5qEYi5AxFxK6bzldxc7auTlz?=
 =?us-ascii?Q?5a7jJFI4F2AJirXLc4fnW9LIKW+5xBOnxGL99OHkmVryx7bmSYDCDZ9fwuYO?=
 =?us-ascii?Q?dmy2zvppyY4Js5wd4qyFSLtm3qBnF701CsvbbY6qqOWbj+xdKJYVpJkFQEP/?=
 =?us-ascii?Q?XPFTskpn9sG+uBVFL7ZLazqrQD3URYi+YtLHXKYYLW/jIhKUiiSsFxAjdVm5?=
 =?us-ascii?Q?3dnNdat6abLxDeE+FX28axXmOJmbMM7Lw2aAsaasS4mOvadMH/T8CthTouDK?=
 =?us-ascii?Q?h+dRybNunnP6nacPSPkflayFIKJwvQYRvkabss923gtB9fNu4UKQRhJWq1yD?=
 =?us-ascii?Q?n1SNMctDMfwUDvj6TG8wCggeTpAL3kBEJCLfUBlwbaQnFcTlTOxwtmH5dWPn?=
 =?us-ascii?Q?5TxfgExGzBhgJWIG15O+K3DSp8iy+47vHrss/C0FjSyiFMsBmETQf89Yr3KU?=
 =?us-ascii?Q?wR1i0w7nvRmDuQV7KJfOwsDLciSHbs8MAKJfAKpYJWd+1JPNKQdiaYoVLnlH?=
 =?us-ascii?Q?KPNzdg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c94d8b8-9c0f-42e4-8f04-08daf944c761
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 11:11:42.6373
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D431hk8afeA/L+NLEJXsNa45fHaeqfIgwDnzEKbNNDeFeuOk/bxXV+j55R87nakLtPaGb60yRzukBujdYK5hmgnxHw5mi24GUz0z/pctZcI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5603
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 17, 2023 at 11:03:44AM +0800, Hayes Wang wrote:
> The rtl8152_cfgselector_probe() should set the USB configuration to the
> vendor mode only for the devices which the driver (r8152) supports.
> Otherwise, no driver would be used for such devices.
> 
> Fixes: ec51fbd1b8a2 ("r8152: add USB device driver for config selection")
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> ---
> v2: fix a typo for the comment.
> 
>  drivers/net/usb/r8152.c | 20 +++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)

Assuming that all the versions covered in rtl8152_get_version()
support switching the device to vendor mode, then this looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>