Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 12:00:07 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Daniel Machon <daniel.machon@microchip.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com,
        Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
        joe@perches.com, error27@gmail.com, horatiu.vultur@microchip.com,
        Julia.Lawall@inria.fr, petrm@nvidia.com, vladimir.oltean@nxp.com,
        maxime.chevallier@bootlin.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/6] Introduce new DCB rewrite table
Message-ID: <Y8fRNwO71ncHNLxB@corigine.com>
References: <20230116144853.2446315-1-daniel.machon@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230116144853.2446315-1-daniel.machon@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jHIAAxwY/jcazR63CE9S9cu6QG98dMjmggbs1OETcHWccyE7Q71SUmRX70Yu?=
 =?us-ascii?Q?r3LFiPdfTTZ6Cix0dZfRS/5KNe+XKTw1XWzmkLpmFTNLAjLPocCUnPkzzR9r?=
 =?us-ascii?Q?GqhGbxRfiIegHp64kmPiJAYyhFraCXTiuNBYOX5xTpNY7kQezjz2DKviA4yB?=
 =?us-ascii?Q?gljrbAqizJK1QsK8HBfBMHSezqwtga7b5+8u/GjS6t23BHMCKX2mEMsI4CjY?=
 =?us-ascii?Q?htuDNxMV5zpu6/PBb6GaNgRFnAX4TpNLdZ/79qEsBCg9Y2vKag+uoBCgwL2n?=
 =?us-ascii?Q?o88YgmfV41nyDuUfe2Z/bbqEAZkHJ3r+BUA5Va1VL0N0wnWWIibEA/Z/nEVW?=
 =?us-ascii?Q?ZSUNR40q85s2ZBpgf4JbXU+aiZ5AUW3PxuKYg1EKyyDnZLUQyATSDLv8JYic?=
 =?us-ascii?Q?ZtAadi4OYCD631K9f/9JjxoCxWFm6dx6Ys8s6czJxMO69QqLfZcwfppIhLss?=
 =?us-ascii?Q?0tygQCYSwcxG94VBjkZzcKY1JqyGRDYfsRdhwyBu5RxmZE6pHOHevHF5Kb4+?=
 =?us-ascii?Q?Oiw2tKMIJDxsfgi9G2DIlwv1tKILVJpXKtyu8uNk4SXZGzaR9kATs9lzczb0?=
 =?us-ascii?Q?/cPAXve50K8ePHj1xVEU1J4Qav5u8D7meMSQSluX5VGzc7TRJimxr389wKmP?=
 =?us-ascii?Q?KZv4tyQNbDKZmXBuLHGKfZXAumptVVJKjmeHXw29HjYnJT2zR9qGpuS35iNl?=
 =?us-ascii?Q?wSBqB6CidVjskUXy7+jsDdXfE6lUMhA82tivvY4uDmlwU2D/glX1CsC4z6OE?=
 =?us-ascii?Q?mfGzqZqHNfOaaVi4sTOEGtUeQ4h7cN2EMl939mNrXQiDVJcve228gsX4LwAA?=
 =?us-ascii?Q?Z6YXS7/6FVeeOcrcBlXwYpndDOWIAc8A6Jlgb0eAU7k82uYhtlMrEXgWjZUN?=
 =?us-ascii?Q?gd9akjlz3URNDW6lWzHvOpisQnYqgsjHpMnfZHtkwI9RvSo9TiUxEfSJObGf?=
 =?us-ascii?Q?CUQVJ2GAlTrHTTu0UVzMuETHHFKEbxmdyUYwvWyPFaWTqBZMt9NMjqrE2TRV?=
 =?us-ascii?Q?d3BZsir5Oyx2kQFyk4XxL5yWt4KMNM4bnDrpy0jPWw2y6A33XwIrxY8i2l9s?=
 =?us-ascii?Q?17H3hcMgC6Dg7t0TxZhGTuuQ+P5sqKY1rTYMQo/CNTDJSxdZNArZJAMKBJJo?=
 =?us-ascii?Q?ndXzmLa4BhPBi6FmNhmbyzGTS2UCxBN68OwJFVvaRti2E2KYj4DrrTFC0o+c?=
 =?us-ascii?Q?4TAZyO8g3uJo66XcMvbp0P5j7uLIraluyBSb5NQ/i/bozcjx1IHFY34JFmCm?=
 =?us-ascii?Q?r9o1GorVD6oQzraJ9ShGZ7P9gkZO98ylEgnwxV5BuWz0avTCSfONRF3kAPaI?=
 =?us-ascii?Q?KPJfDXfXYsS6Bsyh0kOK9oo42Umq+6SPlSR4K8nNy00IdM0AphWyKIt9An7R?=
 =?us-ascii?Q?dcgXK7mgELTdHLR+Jp/Hz1/7hFFP4+aRypuAuDxdhlM+pjan/qhDDuFmWQRl?=
 =?us-ascii?Q?wXEbw9MNKXq5U1TVyJIewL+gNHLyq7L+MvHCFffP2f30CBH+vivgyfpBRBSE?=
 =?us-ascii?Q?q7ftXc7XhVoheVm/lblEEWof3oYHbakSjidW2trQEKkezAy4ktx5nEwc9NpJ?=
 =?us-ascii?Q?ZwD6twOQsz9QiP/RPYwCoTvNQlc+cRFpqGpYNIdfdON1CFX6q34g1bH4O7fl?=
 =?us-ascii?Q?A+YUYteFNu8X6T7lu416byonklULF1ZgoJ5ar1esWc5zK7G84Nk7i4zXu8PQ?=
 =?us-ascii?Q?khjNLQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa7c0fea-2c5f-4420-6d31-08daf9432cf3
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 11:00:14.0653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uXxlYXWa2QCa8ooQeWzAe2zA+hRsYZ+I+ZQSRAMHz4M4NddiDJpJwj2NiXSmim1yGtlSjwP1L2ToW9GU0XNgMF2SNyRZDreVcGt6jmgCS8o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB4963
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 16, 2023 at 03:48:47PM +0100, Daniel Machon wrote:
> There is currently no support for per-port egress mapping of priority to PCP and
> priority to DSCP. Some support for expressing egress mapping of PCP is supported
> through ip link, with the 'egress-qos-map', however this command only maps
> priority to PCP, and for vlan interfaces only. DCB APP already has support for
> per-port ingress mapping of PCP/DEI, DSCP and a bunch of other stuff. So why not
> take advantage of this fact, and add a new table that does the reverse.
> 
> This patch series introduces the new DCB rewrite table. Whereas the DCB
> APP table deals with ingress mapping of PID (protocol identifier) to priority,
> the rewrite table deals with egress mapping of priority to PID.
> 
> It is indeed possible to integrate rewrite in the existing APP table, by
> introducing new dedicated rewrite selectors, and altering existing functions
> to treat rewrite entries specially. However, I feel like this is not a good
> solution, and will pollute the APP namespace. APP is well-defined in IEEE, and
> some userspace relies of advertised entries - for this fact, separating APP and
> rewrite into to completely separate objects, seems to me the best solution.
> 
> The new table shares much functionality with the APP table, and as such, much
> existing code is reused, or slightly modified, to work for both.

Thanks Daniel,

FWIIW, this looks nice and clean to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>