Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 13:41:14 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Jerome Brunet <jbrunet@baylibre.com>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        linux-amlogic@lists.infradead.org,
        Kevin Hilman <khilman@baylibre.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Da Xue <da@lessconfused.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support
Message-ID: <Y8fo6qx7LnXsJN4o@corigine.com>
References: <20230116091637.272923-1-jbrunet@baylibre.com>
 <20230116091637.272923-3-jbrunet@baylibre.com>
 <Y8U+1ta6bmt86htm@corigine.com>
 <1jk01mhaeg.fsf@starbuckisacylon.baylibre.com>
 <Y8VWWP53ZysENI7/@corigine.com>
 <Y8df4LRfPN34lvP8@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y8df4LRfPN34lvP8@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O1tTq+ye9ukHlwP16vBqLsFgDMQFMYw3+MFRKr+LEUYvUtaT5AqWxGolhP4i?=
 =?us-ascii?Q?dXlM0Q/HJgO4gJa5+4ntIzDUozJOYSoG6Pb8IlMs1UDHXsV647oWGVewsmTh?=
 =?us-ascii?Q?leVrvlibE6B/IkWPy0VZZ5jSO0CNq/QcP5UxIlEovVI6nomc/Tkxn7f8JJE5?=
 =?us-ascii?Q?iZL3W3wBNiGlb9QkCGXOEFncm8KAes9sQg2ZzIqnVp4ahpdCxpuFzKGeWEFG?=
 =?us-ascii?Q?Flq7ZEST9VX0RaK5L7+PsKPFDAUuRYqcGkQgdJfXshxLq2ZKj2p9MOE3JeJC?=
 =?us-ascii?Q?gVx6H1VZmQfOj9D6cHA7BmId5gmZu5xLDP80YpeodaIRUfFitOhT3jq9rx8S?=
 =?us-ascii?Q?JDL5wkUh1R79L8br8fn92nUYLQUFXJBqsQEKLty8w1H6vYjq9Cre4O1HfRp2?=
 =?us-ascii?Q?haEitAIzy528IVRdAtipPru1HqU401sopmIcU95gwo96nwWrg8QlHbtOll+A?=
 =?us-ascii?Q?juA5dzOg7iViX189E31F50ula/ds5RcUBO2nbbdFTYRwBp0LpT+LRvTDBDmk?=
 =?us-ascii?Q?Mu3WAOnYmH8weiQhJ0pBWrWh0jkN1rIGHPfAyIgF76zjtCjKn3qz5Y7tNFnF?=
 =?us-ascii?Q?EeIGCYmC4d5TD4a8lRvcr8Sd69QHw79ZvlrIxZeaoPBEKVcwVA0ievaTNoIY?=
 =?us-ascii?Q?xP/cqDkoUlePfJIsQDOSPFDcQBibmNk2E6KC8gChIx38XPXQTZJ1hWPirqiE?=
 =?us-ascii?Q?2qYVFgYqV0V4JOkJDPt0hjL+RHdGS78oJ1ypukKGeBGmz4JZJKDK6ADnP0fs?=
 =?us-ascii?Q?OTkSOmx1yPs4dN1vhEqJuyhvboIcGPER0KLU5JTYdTmS7CWD4NnkB4ZGjYM1?=
 =?us-ascii?Q?P5GqcyJYhGcMgQSJC1BsZZACqotBO9M8lJUrB37A64QHtgKjKC4mQD3U06IR?=
 =?us-ascii?Q?WnlPAHlQw5IVEhvx/nGsegKrBJQBfGYPYfIg29VRgZFYm/ni3Y0+etvEaslp?=
 =?us-ascii?Q?27Go7/43laEEbbV2ZfZ4V5ZapEaIGhqFFWl3W7eSNHXwDvQ81rJilQ5c26XZ?=
 =?us-ascii?Q?/xu2IUPPyw1ytwFo5pe6wgZ4HgdTmkE19QO0STrDWOBGEOkDuZKv++Q8lDcO?=
 =?us-ascii?Q?icuErJDgDjgqnN6bUwAJ7limHHm8D99w2YE02Pyxejby0mkcVxBa4ZGQ2inX?=
 =?us-ascii?Q?eXRF5A11j497PXKEAj4pzDr7a21LZVpAxA++HyU8RTQ+tyzVK47i4ue6Sy6r?=
 =?us-ascii?Q?w5eZ9/yfoT6Vs23DfiDS6amyjP1CVUfeH6GR65ccLyWjPcQhsxHKr1uJju6y?=
 =?us-ascii?Q?Y1sqf+d3aN791wSz/P71BMaolX5hCperHYaYDyHiiALD5lbcgnjeRycyU+IK?=
 =?us-ascii?Q?5WAa02bUZus/IgFFRd+8SCFUpoqGJrpN2MhaPJyw7lNPk39Sdb4zXXjqYTV7?=
 =?us-ascii?Q?31umLQ2i8r179z+6+2cICLOndI6z9tsCvyvXgBIqzsIJ73bSSwRIAijWio7J?=
 =?us-ascii?Q?94F9BG/m2izc5LuhhbyzRYjfZAx2X7ZLwn2HcgDIixaBDq+rHN3rMdHcozWr?=
 =?us-ascii?Q?ZB1ZCf/P7pOViQvbud7nfMVXxexaXJWv7rXj4WC9aC5ytQMN4hbxu0SZwxvS?=
 =?us-ascii?Q?R6p8pgq3qCFLVDlkxM4ZmwjXt3nqj2WAQVZRF0lB6GDieECOBPbVGbzcgkcn?=
 =?us-ascii?Q?NIx7kub8jsXC7GjM7sSKZ8yr9m+JQgatyvnZzhptV8Sfqi5AjfLy0QoIMnEY?=
 =?us-ascii?Q?V4JEkw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3374fa1c-8ffc-480b-99c0-08daf9514d16
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 12:41:20.9371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IEd/OgkS94qsK8qfO2kmww3hy9cWUVraSrn1L4SlNbslvAX0JO6PNqs9pXve2AT18LmbrGaJCD2x/jLvQCUk548r//cHs4mqW9OTfFV6gBU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5659
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 18, 2023 at 03:56:32AM +0100, Andrew Lunn wrote:
> > > >> +	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > > >> +	if (!priv)
> > > >> +		return -ENOMEM;
> > > >
> > > > nit: may be it is nicer to use dev_err_probe() here for consistency.
> > > 
> > > That was on purpose. I only use the `dev_err_probe()` when the probe may
> > > defer, which I don't expect here.
> > > 
> > > I don't mind changing if you prefer it this way.
> > 
> > I have no strong opinion on this :)
> 
> dev_err_probe() does not apply here, because devm_kzalloc does not
> return an error code. Hence it cannot be EPROBE_DEFFER, which is what
> dev_err_probe() is looking for.

Sure, there is no EPROBE_DEFFER.

But, FWIIW, my reading of the documentation for dev_err_probe()
is that it's use in such cases is acceptable.

Anyway, let's pass on my suggestion.