Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 14:25:45 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Kubecek <mkubecek@suse.cz>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Rui Sousa <rui.sousa@nxp.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v3 net-next 12/12] net: mscc: ocelot: add MAC Merge layer
 support for VSC9959
Message-ID: <20230118122545.n7z42rvk7qmg3beq@skbuf>
References: <20230117085947.2176464-1-vladimir.oltean@nxp.com>
 <20230117085947.2176464-13-vladimir.oltean@nxp.com>
 <20230117195221.3e216f90@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230117195221.3e216f90@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZVF1VchnzFoCDoFmoVo1viecijywgYkyAUTG5H4brm/sgaFvWbo2JyFwkN/m?=
 =?us-ascii?Q?TYotbjRlZ62/QphD2HnYQvBJ/W7U1LoqOG8Ip9YTTSNsl/STGvFD0JHSNKRi?=
 =?us-ascii?Q?fjuz+179upNJzTzQbkTDs62Lv63wocf4Q7XDzgGuOkkzLEU2tKoM2H/wu5t5?=
 =?us-ascii?Q?nncL4c6KOqUUfhFYBcnaITT2a3DJhdNxrKFY/lARFpLs0vqejbbhIrrPqJ1n?=
 =?us-ascii?Q?983aim7/XD9xuxJNXZ9q87GDIBQinZ+67QhUQBoWElV3lzA6B4G2kKFZOceB?=
 =?us-ascii?Q?rJs5HDnsWJ5801kfZoSs303WYrRSkHYudNl/ymF5ilaFFeuePAx3wpydXV2w?=
 =?us-ascii?Q?E0nk8OjEXe6DYg68lNtJQ6eL5Bx4QXr48uGkbzXDx+N0aL5oOJhYYMHv7qyY?=
 =?us-ascii?Q?vgc8wLjsmRjLV1snixU/c5JOtKo3/HRZ90N5+QMD9mTuUoEELh9l5DeZrbJU?=
 =?us-ascii?Q?kWhwc4sezLJMBSGJHIRh6gxrNSh4r4H872VP5/Jr9BWiWiiz0s29AVREfG8n?=
 =?us-ascii?Q?mh69FP8DVxS+uJMK9j+n2H+5BCFUx7lwxG/BjgFigyu/N1nWhHzU9ZI4HoBR?=
 =?us-ascii?Q?R+O0DfsIVHyFgcbn6pAweSdxaqkltWxjKFT8XWDsPqvhr563KMRmnFT3/Hmw?=
 =?us-ascii?Q?DlmRY/z1dz6H6YbUKiNLjnEO04z8spU0lbAOj9t9yrbQ/zUQk+GmGbfT0Xvj?=
 =?us-ascii?Q?PD13cAbypyLZBvsXqpZUTitXDcYXeDukyLWLPUKox4xPpUED/GRnRBDUcbkd?=
 =?us-ascii?Q?rekugmRPQY2JL2RvnC0PHE87T8LiQdhXnvhU52vJ/RXLEkkEO2k6q2pEfpKy?=
 =?us-ascii?Q?n1wKsGMqO2Nb5QYxO9yDrIlNGl25HHDRn1PSGbH+AesmUKjmyWS9TP0fMO90?=
 =?us-ascii?Q?szUG0j98Q6wi/f0k34xbES8kgynJEO2XREZ98nOrFoum5IaSLZATen4IgT3t?=
 =?us-ascii?Q?PUO/cXNTnDU30myQgvvwIAUNIAPe7fPlzSFkJah4Qy8PE9g6e+35VADBqjf+?=
 =?us-ascii?Q?ahmOVynp8iWzzM6PM3QndKEvwFLYlkg3cNyE9QTi1ie3HjmxSpHsWhmlAEnE?=
 =?us-ascii?Q?TWH1ZZNI6lFesIWJ+jTsnekzDqK6q/RVjDnM5Xzo/PDMBiWU357/g2lKaBiC?=
 =?us-ascii?Q?JFizBLH9symstTNxgCXb6WNaFBMsMSdMuURHK2tn2ViEsjoF0NiPB0s9ZDeV?=
 =?us-ascii?Q?fva2wpTCWWRazuy9d32BpO9bIAatc2Y8ju7EeZxzVKS+kibbEfmwvf4fp7kU?=
 =?us-ascii?Q?Kjgj2iiK69ldL2VMzEUryoDCOHiKwy9bC8nX7HSBbeC4Uw7dHHUft724xJ5b?=
 =?us-ascii?Q?Dz/TX6Ec+OgQQjHvlBIo5KzPi/hb/g9A8Jg5gm9FikD67giE3G8CJJ4MkPLy?=
 =?us-ascii?Q?eCBykwE+CwfrToO7M5FYWNsjQFe9ZG0wmjpPQFbXdVLedPa4xA33lf5nXb9A?=
 =?us-ascii?Q?CoNKczky+3eVcQALhSj39PZjx8GCdJ/VuMKPfzKAiQipUQWNUM9QOLT+3dM8?=
 =?us-ascii?Q?1afBVt6G7WtFqdd7OVnQjSB8lYA7t3moF6GZ6dn+vcIMMwMF71e457Q4JWH/?=
 =?us-ascii?Q?LdnlR+Iq3DId5k93b/9eS9uDIdO1QWIvhEP4FzR71ZTueL7+z59rISrPFxqc?=
 =?us-ascii?Q?Xg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91ee2155-8a54-4b91-c399-08daf94f227b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 12:25:50.8708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R0DFhotgIosy6wjtytAjsX+wVXuDqlWmK6UdFfmUux1OVFL4ViazQmyKQNfQNCtXEVkxZTT1IgxtAKxU7hP4+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7007
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 17, 2023 at 07:52:21PM -0800, Jakub Kicinski wrote:
> On Tue, 17 Jan 2023 10:59:47 +0200 Vladimir Oltean wrote:
> > Felix (VSC9959) has a DEV_GMII:MM_CONFIG block composed of 2 registers
> > (ENABLE_CONFIG and VERIF_CONFIG). Because the MAC Merge statistics and
> > pMAC statistics are already in the Ocelot switch lib even if just Felix
> > supports them, I'm adding support for the whole MAC Merge layer in the
> > common Ocelot library too.
> > 
> > There is an interrupt (shared with the PTP interrupt) which signals
> > changes to the MM verification state. This is done because the
> > preemptible traffic classes should be committed to hardware only once
> > the verification procedure has declared the link partner of being
> > capable of receiving preemptible frames.
> > 
> > We implement ethtool getters and setters for the MAC Merge layer state.
> > The "TX enabled" and "verify status" are taken from the IRQ handler,
> > using a mutex to ensure serialized access.
> 
> Doesn't build now.

Right. In an incredibly stupid last-minute move, I turned the dev_info()
into a dev_dbg() here, but I apparently deleted the opening bracket too:

	verify_status = ocelot_mm_verify_status(val);
	if (mm->verify_status != verify_status)
		dev_dbg(ocelot->dev,
			"Port %d MAC Merge verification state %s\n",
			port, mm_verify_state_to_string(verify_status));
		mm->verify_status = verify_status;
	}

I'll wait for some more comments from the TSN-inclined people (if the
netlink parts are okay with you) regarding the UAPI before reposting.