Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765416AbXHXJwb (ORCPT ); Fri, 24 Aug 2007 05:52:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763325AbXHXJwW (ORCPT ); Fri, 24 Aug 2007 05:52:22 -0400 Received: from smtp.ocgnet.org ([64.20.243.3]:46669 "EHLO smtp.ocgnet.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760196AbXHXJwV (ORCPT ); Fri, 24 Aug 2007 05:52:21 -0400 Date: Fri, 24 Aug 2007 18:50:58 +0900 From: Paul Mundt To: "Robert P. J. Day" Cc: Linux Kernel Mailing List Subject: Re: what is the value of the macro "__setup_param"? Message-ID: <20070824095058.GA32013@linux-sh.org> Mail-Followup-To: Paul Mundt , "Robert P. J. Day" , Linux Kernel Mailing List References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 24 On Fri, Aug 24, 2007 at 05:19:29AM -0400, Robert P. J. Day wrote: > > perhaps i'm missing it, but it seems that the macro __setup_param is > entirely superfluous: > > $ grep -rw __setup_param * > include/linux/init.h:#define __setup_param(str, unique_id, fn, early) \ > include/linux/init.h: __setup_param(str, unique_id, NULL, 0) > include/linux/init.h: __setup_param(str, fn, fn, 0) > include/linux/init.h: __setup_param(str, fn, fn, 1) > include/linux/init.h:#define __setup_param(str, unique_id, fn) /* nothing */ > $ > > or am i must misreading something badly? > Superfluous how? It does different things depending on whether MODULE is defined or not. It's a good indicator of how often people use __setup_param() from module context though, given the complete mismatch of parameters. It's probably worth fixing that up at least. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/