Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <petrm@nvidia.com>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <joe@perches.com>,
        <error27@gmail.com>, <Horatiu.Vultur@microchip.com>,
        <Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
        <maxime.chevallier@bootlin.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/6] net: dcb: add new common function for
 set/del of app/rewr entries
Thread-Topic: [PATCH net-next v2 2/6] net: dcb: add new common function for
 set/del of app/rewr entries
Thread-Index: AQHZKbnEKv6IsE6w70C8Q9TlPGBnVK6j+1CAgAAKK4CAADBJAA==
Date:   Wed, 18 Jan 2023 13:56:07 +0000
Message-ID: <Y8f6dqXGo8ikcQsx@DEN-LT-70577>
References: <20230116144853.2446315-1-daniel.machon@microchip.com>
 <20230116144853.2446315-3-daniel.machon@microchip.com>
 <87cz7cw1g5.fsf@nvidia.com> <874jsow1b6.fsf@nvidia.com>
In-Reply-To: <874jsow1b6.fsf@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ikSHJ7JUpOE3xyhR8MIRRums6PTlcQm5ZIqr5IdZIN6xpzsP7N1SqBoNJ+5d?=
 =?us-ascii?Q?Sd3qB2JKT7mmr3UB2E05HOFKeBx1zciS4iyNUB5ln8V1YbBgWtrP1/2+vJFw?=
 =?us-ascii?Q?M6ktxBAfUu5/yaiECVAXOSuyyJsJ2vN4A2WtL2YM73gP1/KLXsbvOK4N+bdp?=
 =?us-ascii?Q?lcLiuM/iBxIWeGkkGElkwTbe2rR/ILKk/9025Hg2AsHLfa0PwVPc2MXroj1+?=
 =?us-ascii?Q?eXBnc0YnHuRu2jV5V6AX8aEa2NPKk8r8kBxyzlhkuD27F6BNgmeLndSSVm39?=
 =?us-ascii?Q?nn0lNHeI3JA3yg3jbRAxe/HaHXnKtiWes/GZFLuAK3Stq1Nkf1qCn9hQ+pkF?=
 =?us-ascii?Q?TrROum7oeUpbRQsd5OkTW/eZvYMPEE9KzmBHYWDsm2NxZvk82sQ4AHJrJVjI?=
 =?us-ascii?Q?B5nQBO+lfYd0VnL7xzVt4+c2qlIn0H1sSeoRFJq/R7PildgSPyJD306xLpaL?=
 =?us-ascii?Q?lmJ8jvCbUGgb72WKskhTVVMZBASEHoORmHDdHIaPi0btY1s1keI880KCqVK9?=
 =?us-ascii?Q?ZahsBVlctLX59+gEzjzr/wkNJsziFzauWpfh422UnET9wP9bHmf9iOr/VR1k?=
 =?us-ascii?Q?RGREH3kggwxrlfKG369fokYDcHiKvzpNwkih5h8YO3V5c3iv94y+OZVB/G1H?=
 =?us-ascii?Q?yk+J0Kv9nXSm0MasocbfgTyiM5MDjpo1JO42Jnky5RH7wORzuz7IozPP8NgV?=
 =?us-ascii?Q?RHX4hql91WE9aDjPDdtvtH6EHoU5ZRYarO7FQAWgomiguLM4Fp/amxd7JZO/?=
 =?us-ascii?Q?Zlu+IZvU9gkevKgd6SAZMpNrVBvRJIqyVCAfwqWdQwinfCRGQ5PudqtHBJEc?=
 =?us-ascii?Q?azLnQK0VW3Ii7ySFr/W0wTQaQ0gNg3Zo++IAwJ8xFn8GhORseXtLGNTzgC3j?=
 =?us-ascii?Q?jnCqYNbHXSWH8/fsR8C66v7g3Fy7YvHqnH4NGdoY0bwIHaTyWuD+WtkX9akL?=
 =?us-ascii?Q?72tRS2YDAOrw1jD+N8XWnlvjdP8S4l2SoY7rmogjT9s2F3uV8Cmi2m7/508J?=
 =?us-ascii?Q?pFkCCNpymR6wPxComm/5Lw3BK1j2kTdvGdEz5J9wRcqSKoptZhQfnvJY2OBn?=
 =?us-ascii?Q?KW3mcdlWZP1TkQpcU+mh2/vleQpKYYtcCJlD+huElz8xNP3cQCZIAq9P91kv?=
 =?us-ascii?Q?ZQYWSZPtArvAC9AUoxs935sgqagiH23R8OwaKYlI84pOvBsl5O2RODn3oGP0?=
 =?us-ascii?Q?b5xnhAYQJmQrRPbMo3NAtXN8wWxTndcSG7tkmsuScInAOXrTz8Ugm0TufUAv?=
 =?us-ascii?Q?6gAIxJYkcZjatR3HyURj9QvjB0/DXES7D+Dyw3Iy2qiHbEq0wByjLEoJKK//?=
 =?us-ascii?Q?8b3eSEnzxzQR5rR97QqgSknZi5JkDlL3M/kLC2KHIxIUC+5XEvTZOitP/5b4?=
 =?us-ascii?Q?/ewM7/BvFFwzPEPVIbyrP3Ckcqie6a02bmYHTP4qUfywd6tv0nR3lXqVkw0F?=
 =?us-ascii?Q?woDqw1tKsOHeo7sd5TojwRJcRNH7C0tdSa/wNlPpEdpKz6EDtM20bCT3v4XL?=
 =?us-ascii?Q?hHxz7VJZozROSXLLsDHdP4PJDndChnFiajaxubKH96F0lwPzWmksbv1PzeYz?=
 =?us-ascii?Q?PbRPJ8OvOKGjrs4jiS9X0acAg1p0H/mlzu9a2lR1iKEXWHf7UOgn6t6dBRCJ?=
 =?us-ascii?Q?8KL7MF5jywgjDpQLVxbGlRM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <883D2D71D6146740ADD2A74A28764E16@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00f915c3-4d32-4378-8290-08daf95bbf65
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 13:56:07.4162
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rkWcsjhBw5yglkwhwnOjPZPKB23Wmcw5xk5q5xxmsjnjnfAM/d+HANImFfH5Te6FrI/vLiVjY2YR4af9j+D/yUUjP2gB6GzUcy8huU7ufqw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7812
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 > Petr Machata <petrm@nvidia.com> writes:
>=20
> > Daniel Machon <daniel.machon@microchip.com> writes:
> >
> >> In preparation for DCB rewrite. Add a new function for setting and
> >> deleting both app and rewrite entries. Moving this into a separate
> >> function reduces duplicate code, as both type of entries requires the
> >> same set of checks. The function will now iterate through a configurab=
le
> >> nested attribute (app or rewrite attr), validate each attribute and ca=
ll
> >> the appropriate set- or delete function.
> >>
> >> Note that this function always checks for nla_len(attr_itr) <
> >> sizeof(struct dcb_app), which was only done in dcbnl_ieee_set and not =
in
> >> dcbnl_ieee_del prior to this patch. This means, that any userspace too=
l
> >> that used to shove in data < sizeof(struct dcb_app) would now receive
> >> -ERANGE.
> >>
> >> Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
> >
> > Reviewed-by: Petr Machata <petrm@nvidia.com>
>=20
> ... though, now that I found some issues in 3/6, if you would somehow
> reformat the ?: expression that's now awkwardly split to two unaligned
> lines, that would placate my OCD:
>=20
> +               err =3D dcbnl_app_table_setdel(ieee[DCB_ATTR_IEEE_APP_TAB=
LE],
> +                                            netdev, ops->ieee_setapp ?:
> +                                            dcb_ieee_setapp);

Putting the expression on the same line will violate the 80 char limit.
Does splitting it like that hurt anything - other than your OCD :-P At
least checkpatch didn't complain.

/Daniel

>=20
> (and the one other).=