Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5da005dd-e34e-ff08-7a97-8a37b231ed5e@linux.intel.com>
Date:   Wed, 18 Jan 2023 14:49:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v1 3/4] ASoC: ts3a227e: add set_jack and
 get_jack_supported_type
Content-Language: en-US
To:     Astrid Rost <astrid.rost@axis.com>,
        Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc:     alsa-devel@alsa-project.org, kernel@axis.com,
        linux-kernel@vger.kernel.org
References: <20230118125226.333214-1-astrid.rost@axis.com>
 <20230118125226.333214-4-astrid.rost@axis.com>
From:   =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
In-Reply-To: <20230118125226.333214-4-astrid.rost@axis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/18/2023 1:52 PM, Astrid Rost wrote:
> Add set_jack and get_jack_supported_type
> to allow simple-card-utils to add a jack for it.
> 
> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
> ---
>   sound/soc/codecs/ts3a227e.c | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/ts3a227e.c b/sound/soc/codecs/ts3a227e.c
> index 2305a472d132..212dfd2b60ed 100644
> --- a/sound/soc/codecs/ts3a227e.c
> +++ b/sound/soc/codecs/ts3a227e.c
> @@ -258,7 +258,22 @@ int ts3a227e_enable_jack_detect(struct snd_soc_component *component,
>   }
>   EXPORT_SYMBOL_GPL(ts3a227e_enable_jack_detect);
>   
> -static struct snd_soc_component_driver ts3a227e_soc_driver;
> +static int ts3a227e_set_jack(struct snd_soc_component *component,
> +			     struct snd_soc_jack *jack, void *data)
> +{
> +	return ts3a227e_enable_jack_detect(component, jack);
> +}

Patch looks ok, but it seems that ts3a227e_enable_jack_detect() doesn't 
check if jack is NULL, before calling snd_jack_set_key() I guess this 
should be also fixed, as _set_jack can be called with jack being NULL to 
disable jack detection. Optionally, while set_jack is being added I 
would also just get rid of 
EXPORT_SYMBOL_GPL(ts3a227e_enable_jack_detect); and convert all other 
users to snd_soc_component_set_jack as it currently serves as bad example.

> +
> +static int ts3a227e_get_supported_jack_type(struct snd_soc_component *component)
> +{
> +	return TS3A227E_JACK_MASK;
> +}
> +
> +static const struct snd_soc_component_driver ts3a227e_soc_driver = {
> +	.name = "ti,ts3a227e",
> +	.set_jack = ts3a227e_set_jack,
> +	.get_jack_supported_type = ts3a227e_get_supported_jack_type,
> +};
>   
>   static const struct regmap_config ts3a227e_regmap_config = {
>   	.val_bits = 8,