Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <83939b6b-0188-9cb7-c4fc-624f13437a48@linaro.org>
Date:   Wed, 18 Jan 2023 15:37:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH v4 16/17] arm64: dts: freescale: apalis-imx8: fix
 reserved-memory node names
Content-Language: en-US
To:     Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc:     "linux-imx@nxp.com" <linux-imx@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>
References: <20230118072656.18845-1-marcel@ziswiler.com>
 <20230118072656.18845-17-marcel@ziswiler.com>
 <b5a60852-f8f5-f3c4-fb75-bb5f00823c82@linaro.org>
 <1d4dc13ce1ffae4885bceb439d5d259f3567e6c4.camel@toradex.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <1d4dc13ce1ffae4885bceb439d5d259f3567e6c4.camel@toradex.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 18/01/2023 15:36, Marcel Ziswiler wrote:
> On Wed, 2023-01-18 at 15:02 +0100, Krzysztof Kozlowski wrote:
>> On 18/01/2023 08:26, Marcel Ziswiler wrote:
>>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>>
>>> Fix reserved-memory node names using dashes rather than underscores.
>>>
>>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>>
>>> ---
>>>
>>> Changes in v4:
>>> - New patch fixing reserved-memory node names.
>>>
>>>  arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 12 ++++++------
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-
>>> apalis-v1.1.dtsi
>>> index 70c00b92cb05..6217e0a48f96 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
>>> @@ -133,17 +133,17 @@ reserved-memory {
>>>                 #size-cells = <2>;
>>>                 ranges;
>>>  
>>> -               decoder_boot: decoder_boot@84000000 {
>>> +               decoder_boot: decoder-boot@84000000 {
>>
>> This is ridiculous. You just added it! If we consider original code as
>> wrong, then you intentionally added wrong code just to fix it.
>>
>> No, that's not the way how it should be developed.
> 
> Shawn asked me to ease the review process which is exactly what I did.

Any reason why b4 diff cannot be used? If your patchset fails b4
auto-detection of version, this should be fixed instead of fake split.

Best regards,
Krzysztof