Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6655696rwb; Wed, 18 Jan 2023 07:51:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXuWu+S6oHjMwhpuAm8vpTiK6sA7nKcDFotM5Mz7S9t6zo1Z3f2pg//5yt5TG8X0tBskdtk/ X-Received: by 2002:a05:6402:294c:b0:49e:28b6:4cf5 with SMTP id ed12-20020a056402294c00b0049e28b64cf5mr7703910edb.12.1674057090483; Wed, 18 Jan 2023 07:51:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674057090; cv=none; d=google.com; s=arc-20160816; b=LH1CnjZPhcGp2hDhtPvX41Q3jAFzh1RvXgTyZM5O9ygu9VNTU2nSbk1x7mbDVojRNF t4fIyJDA+BU2MJc/ODv7CNxpkqHBB0Puup9in8kId+jg0tQKGRU8i+Vq5AOrV8SJ8YcE OzHU0CJBVUNdLmNm34kGAw2uv9NbAQIn+q7nsPHPSjgwipYU4MHxhkgIUFYlUXKGBi5Y vIwnjheAxkqLBnN57aI5q9G5ibH6l6000VHaYjs3s5rX0/1Vz5tMYfIJQF5W4zbh6lMb l8DKJ3sC7lMgucgkr6FUBJXjdPp3l3Cs6crx3XDte4ilzU1PFnFvpYwwa5nLIAj5I+ZP tWRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=B9RzjYW5fk/Pv3a3HT0wliwsWy33+IKdBWh16kmMlOY=; b=c4OBpECzdqhTN0XxAi+dmjwGrN1hO55XZCP2vBfQVZCCEO+JEZ4sI2YarUbd/wUtDe e8YR7nI0j9qdoN7QqT752acgtlKR74AmzQ7geW8Vv26BgZ94P1ka2NUCZprZ1JtodjXB gffrpon+J0nQeXY7HvFRUewmZru/8ZRVYw2CFTvkejzRZWtTElH5SpL2fS9pLDomM7dE vI4si6WgXyLGRvBygoPqq2u1dTnZ78ld87Yw4bA71ZWg22ySJ4LyLLI3ABYku/HyxifH JvqvH05EPDLef0VQIg/UMqr9kVrE44OiISqo/qNmWPa2PtnMzkryZFbGcHQkCNKDmPU6 Kc3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZizAwzMJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k26-20020aa7d8da000000b0048ee8cf8bb8si32294256eds.53.2023.01.18.07.51.19; Wed, 18 Jan 2023 07:51:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZizAwzMJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230113AbjAROpL (ORCPT + 45 others); Wed, 18 Jan 2023 09:45:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231132AbjAROo1 (ORCPT ); Wed, 18 Jan 2023 09:44:27 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 302D33803A for ; Wed, 18 Jan 2023 06:36:26 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id iv8-20020a05600c548800b003db04a0a46bso1521811wmb.0 for ; Wed, 18 Jan 2023 06:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B9RzjYW5fk/Pv3a3HT0wliwsWy33+IKdBWh16kmMlOY=; b=ZizAwzMJ8r5IBCHKVkV64U1DkWX/9+dcs0OKEw4xzRcg5ZyV2GjIfZ5s1orTp6malV XYr5zhFLgJzJpCoErqMJMLg1GmPxrOsMzfYWik+wbc/fHhivIWM1DfCsxCuokIw6kQAE DuL4qE50QGKGH+9s785iJh+QeDF6Q/7d8AFO+sz3obvxZHlaxnnpSoM/tZtGbgqxPTPz Zp2tdsCOt+lEgAj+kM7Pf+/b1MUemxduB+o/VlLWgicsAIO7FYT/rcg9Lm0yboOzEf6X /a4FSpYHaNpxmqoR1wr9dQluOgMeH9ZogxNi2/tk4SffOHlNXkNufB31BOXKL9/ndv2I y6cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B9RzjYW5fk/Pv3a3HT0wliwsWy33+IKdBWh16kmMlOY=; b=RzmNh1CDy0eRrZFnR/xGIhhax45/QXqzuTZlQWtSD42m3Aso8hyCoPpE8251CYwZHP EqE+ZcgxgDvf0WMT9j3srAv1hwy2q3rzh8I+tg2AlAyLliLuBK/8dyRHfubw/TJsFywd viXBE4W/4tytjOJfE9nP/EtSNETZ4VYWGGOgv3/o26UI+9qJ+S8p5DoDhdsQ3vrLEn9R QvuvfgSmddpllYYAjYAmitfnUHARiLhsEyN96iW9yLozRF9doQFG8FovYCZ6Ayh9Ns+N ruRmGw+ZRJ54FCFwCLDQ6YzeDQUDLfcIS9O+sKWb1sx3Y6APIHCqnLcqWeDdKYpdAG2Z c+Gw== X-Gm-Message-State: AFqh2kqZIPARGwdbYVvMchScYVh568ErBjQrs7scUQJZ/IDXiTZKmCOR JT/bSxZAddbj6K/xEtOJBGrlgA== X-Received: by 2002:a05:600c:920:b0:3da:22a6:7b6b with SMTP id m32-20020a05600c092000b003da22a67b6bmr6905330wmp.13.1674052584806; Wed, 18 Jan 2023 06:36:24 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id i18-20020a05600c355200b003d9df9e59c4sm2538588wmq.37.2023.01.18.06.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 06:36:24 -0800 (PST) Message-ID: <063d98af-7b9b-c918-6436-5402265628fa@linaro.org> Date: Wed, 18 Jan 2023 15:36:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v4 12/17] arm64: dts: freescale: apalis-imx8: analogue audio comment Content-Language: en-US To: Marcel Ziswiler , "devicetree@vger.kernel.org" Cc: "linux-imx@nxp.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "robh+dt@kernel.org" References: <20230118072656.18845-1-marcel@ziswiler.com> <20230118072656.18845-13-marcel@ziswiler.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/01/2023 15:33, Marcel Ziswiler wrote: > On Wed, 2023-01-18 at 14:59 +0100, Krzysztof Kozlowski wrote: >> On 18/01/2023 08:26, Marcel Ziswiler wrote: >>> From: Marcel Ziswiler >>> >>> Added a comment about Apalis analogue audio being another todo. >>> >>> Signed-off-by: Marcel Ziswiler >> >> You just added this file in previous patch. This should be squashed >> instead of splitting one logical change (adding new hardware) into >> multiple independent patches. > > Remember, I explicitly did that for review purpose and even mentioned this in the cover letter. There is b4 diff for this purpose. Splitting patches makes them difficult to apply and confuse. Best regards, Krzysztof