Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 09:30:54 -0600
From:   Andrew Halaney <ahalaney@redhat.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     davem@davemloft.net, peppe.cavallaro@st.com,
        alexandre.torgue@foss.st.com, joabreu@synopsys.com,
        edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
        richardcochran@gmail.com, netdev@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Ning Cai <ncai@quicinc.com>
Subject: Re: [PATCH net] net: stmmac: enable all safety features by default
Message-ID: <20230118153054.22vs2sqsuxifjpxg@halaney-x13s>
References: <20230116193722.50360-1-ahalaney@redhat.com>
 <20230117194348.3f098a18@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230117194348.3f098a18@kernel.org>
Precedence: bulk

On Tue, Jan 17, 2023 at 07:43:48PM -0800, Jakub Kicinski wrote:
> On Mon, 16 Jan 2023 13:37:23 -0600 Andrew Halaney wrote:
> > I've been working on a newer Qualcomm platform (sa8540p-ride) which has
> > a variant of dwmac5 in it. This patch is something Ning stumbled on when
> > adding some support for it downstream, and has been in my queue as I try
> > and get some support ready for review on list upstream.
> > 
> > Since it isn't really related to the particular hardware I decided to
> > pop it on list now. Please let me know if instead of enabling by default
> > (which the original implementation did and is why I went that route) a
> > message like "Safety features detected but not enabled in software" is
> > preferred and platforms are skipped unless they opt-in for enablement.
> 
> Could you repost and CC Wong Vee Khee, and maybe some other Intel folks
> who have been touching stmmac recently? They are probably the best to
> comment / review.
> 

Shoot, yes thank you I intended to do! Will resend.

- Andrew