Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6745299rwb; Wed, 18 Jan 2023 08:53:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXu3ee3j8fuR6vduQNd9rXIGjI3NtXclMA2f0OAaGVm2tcOriwrWFIliV7eb5Z5MbjvUjPce X-Received: by 2002:a17:907:9252:b0:86e:d832:2f60 with SMTP id kb18-20020a170907925200b0086ed8322f60mr7030491ejb.48.1674060792861; Wed, 18 Jan 2023 08:53:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674060792; cv=none; d=google.com; s=arc-20160816; b=yyEt2TaYMCmuEl91JIo4fstFqu4Acu3irAtJG3jFjIjwc/qvmZQ+7h0YCL6fT1XsWk 4its32Hn3S6uIiMI6HUxBji4KYwj47Pr/9pGp8vxAdVYxVBXD5ET30uU6JLfXSxd9u/s JYw9UEp3i8OvMFh4qLyBhdYBb5waczEPJm9z7JJh+798T96dS/0es4MPXdH2g2SKEmEh 6/s8vzAmtBQQYexvqUfKzZTU7DCHslVSZvGQU8gdyHAXssQWo7Nsja9BJzXp9CRQXTQC AMOmjnK4khC/LLB9ObVKgy29MHQO+0O0KYBAy4T9QCPdF1MKOcOJDttX4vCONPl/PGti yAxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=c9hRqYJ/0TrWZpOVSGInBBWjY6DA9YlneTvRU36ho4w=; b=eABRcL/u1LgDfT2GKV71FE9631QhsPuT3gjCsIuX1MI2I+sEmmdZmWbWd1P3IH3npQ kUDchqIAPU3mlaUQVYAy2y4qrqlJfJ7ZKa2sab/uBjt6XzYI9jWpXJ1iXFAWKfwXdL4p z3B6pu2AGRCcMaYzBdoN+NZIUDN/lqGlMMFnA9aLZtHt+6zboVkN8y6999h/MCJeIcG/ AQFOALfVYeNSayeErIp64BsIq13kyQxEnJh+EexZpUeFNyJL1XJzE5ajvo0nrdKZbBt0 wcnxc6nPmIXfp+xn4FK5rRcrb31FlqElyXhMZ41DS86oQDzjpInoXjJDER3UYxL6U+Pt yE/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aXqEdyVU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg29-20020a170907971d00b008702f808455si12684843ejc.417.2023.01.18.08.53.01; Wed, 18 Jan 2023 08:53:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aXqEdyVU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbjARQs4 (ORCPT + 45 others); Wed, 18 Jan 2023 11:48:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjARQsv (ORCPT ); Wed, 18 Jan 2023 11:48:51 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 739225587; Wed, 18 Jan 2023 08:48:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E68561157; Wed, 18 Jan 2023 16:48:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3B81C433EF; Wed, 18 Jan 2023 16:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674060530; bh=/RbbN2yNZ5vrt37ezendcfzEpHoDc80MyVLJKX/27mU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aXqEdyVURePjmJ17P1TS/ISnyHnGP5GwMmWKt6d6mSTTqfhNJqEO7Er2HRx7/k7De AKO+O+D+1DWLnioTpL8V3gmMKyIfW2PLsHI7J0n6W8JIJYKV6baG7lqginZmnjQntd UdEvvFfAbIyFCuSUpOhZwRpXKVPe3Xtx4T8t7NZS2g851KMKs33BogbMNOJ2SkAvAO 0eQ+tNT+PijEiplKBh6IJD3Y3Mxk3oy3RhXjAL395BafNtaU+IbG1AjegJOlSt2EqI u8w+UJqQWlgCJzBt2CHlqkSG00DibliveMFUxa7xoHsTHJ5aprufzG/8thyO9wOgFT oT4lMtWyDBn3w== Date: Wed, 18 Jan 2023 22:18:45 +0530 From: Vinod Koul To: Akhil R Cc: ldewangan@nvidia.com, jonathanh@nvidia.com, thierry.reding@gmail.com, p.zabel@pengutronix.de, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: tegra: Fix memory leak in terminate_all() Message-ID: References: <20230118115801.15210-1-akhilrajeev@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230118115801.15210-1-akhilrajeev@nvidia.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-01-23, 17:28, Akhil R wrote: > Terminate vdesc when terminating an ongoing transfer. > This will ensure that the vdesc is present in the desc_terminated list > The descriptor will be freed later in desc_free_list(). > > This fixes the memory leaks which can happen when terminating an > ongoing transfer. Applied, thanks -- ~Vinod