Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 11:07:28 -0500
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Tony Lindgren <tony@atomide.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Janusz Krzysztofik <jmkrzyszt@gmail.com>,
        linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: ohci-omap: avoid unused-variable warning
Message-ID: <Y8gZQPmdpY+jCXC2@rowland.harvard.edu>
References: <20230118082746.391542-1-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230118082746.391542-1-arnd@kernel.org>
Precedence: bulk

On Wed, Jan 18, 2023 at 09:27:34AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The dead code removal has led to 'need_transceiver' not being
> used at all when OTG support is disabled:
> 
> drivers/usb/host/ohci-omap.c: In function 'ohci_omap_reset':
> drivers/usb/host/ohci-omap.c:99:33: error: unused variable 'need_transceiver' [-Werror=unused-variable]
>    99 |         int                     need_transceiver = (config->otg != 0);
> 
> Change the #ifdef check into an IS_ENABLED() check to make the
> code more readable and let the compiler see where it is used.
> 
> Fixes: 8825acd7cc8a ("ARM: omap1: remove dead code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Acked-by: Alan Stern <stern@rowland.harvard.edu>

> The patch that caused the issue is in the boardfile-removal branch
> of the soc tree. I would just add the patch there.