Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 11:42:44 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Praveen Kumar" <kumarpraveen@linux.microsoft.com>,
        Saurabh Singh Sengar <ssengar@microsoft.com>
Subject: Re: [PATCH] drm/i915/display: Convert i9xx_pipe_crc_auto_source to
 void
Message-ID: <Y8ghhIzMPc8silvo@intel.com>
References: <Y8K2SS/zNiPAmLsS@ubun2204.myguest.virtualbox.org>
 <Y8b1V7TwesqmB4Hv@intel.com>
 <Y8d42OYWpW03zdAi@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y8d42OYWpW03zdAi@ubun2204.myguest.virtualbox.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q5IprgyCHDczrzcMDgGk/FQbfTtJQdgJQFjufMK6Tzd9zklDAWHs+7XA46j4?=
 =?us-ascii?Q?gWxGadkwLn76/qcOpWxUsAg/KQnlbsV2aUKyKlwEwyrLUBITWgvTGgpQq5Zk?=
 =?us-ascii?Q?zHZIY3IObpz2+6H8MHO/vm3gqbDd2qoiejxgvUaQnpd2uf1B1prGh3EZpNSk?=
 =?us-ascii?Q?bfQgRaqQmjpsLYP2OaK9MlpNLoXDruN6lbH46TMsfu8ROvHA1hpcwvG5Vq2+?=
 =?us-ascii?Q?exmtBbJRg7UYzhqmm7N5GA4n+RDeiph5Fzgd7xnfWHwdw0lnSdLPG1PLymd1?=
 =?us-ascii?Q?jE8Pk70zP2TGiV5BShMOEXL9wy/ouAVfcb0OfLXppGALJSRt5t+YPYsCqffM?=
 =?us-ascii?Q?iLBhZxhhH5XlNM1phDmxtfVTLuPujv/EDtP1KjPNVZ1iMVL4UkuC4cmvjZ05?=
 =?us-ascii?Q?L+M3U+JiGbln3FbfJKnDYsRWmbzKy2qghJlsyxHVROQRUSCYWNfggJcCtIj4?=
 =?us-ascii?Q?EGt2ddndjD3hUbefUV09JP5cRUyOA0iWfct6Ru2ZuadeqWa10RteH9WtUO4e?=
 =?us-ascii?Q?5GTZZp+MeUN1tzoAzxxdsQP1g074AyHAc8P5ErB7qFmjkOSGOQMt0j8Htlm1?=
 =?us-ascii?Q?67YAq9CRW+/U0GAgfdJjybcVaXUvPybiKg9R7O23TYHvgLtVPRtMsxnCezxW?=
 =?us-ascii?Q?yxaYHcd/EN0COU+xVivQH4gRG/i4J3NAxpztZmAs4F1I8Kte5NPYxMPYwhqA?=
 =?us-ascii?Q?VGA3ci/g1qunmcchC3le2d7fifhu1oKVJ+ST6W3U+3HalJogjWacTXoyduu6?=
 =?us-ascii?Q?4iiKujaSvLdCG0TFy8GybML/W7Uva9jG7Fw+6Sa7cvxHiWBUQvxJaokSw4If?=
 =?us-ascii?Q?ySyFTNYTa4DHTYmHQpiGUNkr2Zy1puL7r6sB5AHVLHAgOvXzlrHoxL0gxmMv?=
 =?us-ascii?Q?jWTsw/0C5SChDGaXhVS22YJu5NTJJTmiRIKlWb+Bkd6DoHbkdeXoisMBh+nJ?=
 =?us-ascii?Q?+kHxR853OkU/uXgiR59JO1xw0kXOe8bfAoGF/pUYJKuu/5S1+BgPeVllxGcq?=
 =?us-ascii?Q?XzVYM7TrIDdNJG4aIbTX/hfp9PYjwQBSRfxQ4Hy4wxl0P80o+TpoPGmjTs9U?=
 =?us-ascii?Q?Nqu+5Em/5jG2Dwn8LfYxpRwkPDxeonNbXpmEUtDxCT5XOe1jYKVBXmes0rgE?=
 =?us-ascii?Q?Yp2k0zBCfhXVnIr7jqL/3YpfRGXTPMouA+sywtpBafYA8deC/vhx7LzrF4Py?=
 =?us-ascii?Q?C3jNBgFLlXy4NJG4GdQJYuQi95hxAlsnWwi9HWwthsZIE+/b2XXlYsd919HK?=
 =?us-ascii?Q?e9lt7ih7j/Z/1H7y5Mx4AHTHMRxEMC+OjyIgInmeNmAGO0XcPFws0oYDCX94?=
 =?us-ascii?Q?G0MjMls9Dt9Q9KSY1O9B2u3AHtJBH6gKUABKhlAFhZzgbA8p94oMQn6mYa0G?=
 =?us-ascii?Q?3sdfW4xkrROXQKgWdYW2afuLq0x8hLO5rBktH4eaKh5mnsVg94qQStlwztcL?=
 =?us-ascii?Q?SuQFXlyhsNNcioRBPrn1Q4+danyl6l0YTMuu/3mNcFK5N3SqItGb37cIzB8r?=
 =?us-ascii?Q?OD4afL8iyXqkAQs86rr8OkvzuhLCz/IpBP5ZqBGgrXz9kUE1zb11QqhktAJu?=
 =?us-ascii?Q?sESwdKjbxts3dWO4swKyNIi48L0/qar5bZmGT7Pg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eaefc2c4-3d39-4682-831a-08daf973096f
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 16:42:50.9341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jXtoIn+pLEAQMAjiWRA1ATCGk5ElIUv2DLK3YdyAAlWfo7lgEzZW1cHPCSEv9P+KWmLnurJR0zk1ONUIKYAjSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4962
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 18, 2023 at 10:13:04AM +0530, Deepak R Varma wrote:
> On Tue, Jan 17, 2023 at 02:21:59PM -0500, Rodrigo Vivi wrote:
> > On Sat, Jan 14, 2023 at 07:33:53PM +0530, Deepak R Varma wrote:
> > > Convert function i9xx_pipe_crc_auto_source() to return void instead
> > > of int since the current implementation always returns 0 to the caller.
> > > Issue identified using returnvar Coccinelle semantic patch.
> > 
> > could you please share the coccinelle commands and files you used here?
> 
> Hello Rodrigo,
> I used following command to identify this change opportunity:
> 
> make coccicheck COCCI=scripts/coccinelle/misc/returnvar.cocci M=drivers/gpu/drm/
> 
> Let me know if you would like me to include the same in the commit message.

Thanks for the line.
Added to the commit message while pushing it.

Thanks,
Rodrigo.

> 
> > 
> > > 
> > > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > > ---
> > > Please note: The change is compile tested only.
> > 
> > np, our CI liked it.
> > 
> > I liked the clean up as well:
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> Thank you for your review and the feedback.
> 
> Regards,
> ./drv
> 
> > 
> > > 
> > > 
> > >  drivers/gpu/drm/i915/display/intel_pipe_crc.c | 23 ++++++-------------
> > >  1 file changed, 7 insertions(+), 16 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_pipe_crc.c b/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> > > index e9774670e3f6..8d3ea8d7b737 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> > > @@ -72,14 +72,13 @@ static int i8xx_pipe_crc_ctl_reg(enum intel_pipe_crc_source *source,
> > >  	return 0;
> > >  }
> > >  
> > > -static int i9xx_pipe_crc_auto_source(struct drm_i915_private *dev_priv,
> > > -				     enum pipe pipe,
> > > -				     enum intel_pipe_crc_source *source)
> > > +static void i9xx_pipe_crc_auto_source(struct drm_i915_private *dev_priv,
> > > +				      enum pipe pipe,
> > > +				      enum intel_pipe_crc_source *source)
> > >  {
> > >  	struct intel_encoder *encoder;
> > >  	struct intel_crtc *crtc;
> > >  	struct intel_digital_port *dig_port;
> > > -	int ret = 0;
> > >  
> > >  	*source = INTEL_PIPE_CRC_SOURCE_PIPE;
> > >  
> > > @@ -121,8 +120,6 @@ static int i9xx_pipe_crc_auto_source(struct drm_i915_private *dev_priv,
> > >  		}
> > >  	}
> > >  	drm_modeset_unlock_all(&dev_priv->drm);
> > > -
> > > -	return ret;
> > >  }
> > >  
> > >  static int vlv_pipe_crc_ctl_reg(struct drm_i915_private *dev_priv,
> > > @@ -132,11 +129,8 @@ static int vlv_pipe_crc_ctl_reg(struct drm_i915_private *dev_priv,
> > >  {
> > >  	bool need_stable_symbols = false;
> > >  
> > > -	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO) {
> > > -		int ret = i9xx_pipe_crc_auto_source(dev_priv, pipe, source);
> > > -		if (ret)
> > > -			return ret;
> > > -	}
> > > +	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO)
> > > +		i9xx_pipe_crc_auto_source(dev_priv, pipe, source);
> > >  
> > >  	switch (*source) {
> > >  	case INTEL_PIPE_CRC_SOURCE_PIPE:
> > > @@ -200,11 +194,8 @@ static int i9xx_pipe_crc_ctl_reg(struct drm_i915_private *dev_priv,
> > >  				 enum intel_pipe_crc_source *source,
> > >  				 u32 *val)
> > >  {
> > > -	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO) {
> > > -		int ret = i9xx_pipe_crc_auto_source(dev_priv, pipe, source);
> > > -		if (ret)
> > > -			return ret;
> > > -	}
> > > +	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO)
> > > +		i9xx_pipe_crc_auto_source(dev_priv, pipe, source);
> > >  
> > >  	switch (*source) {
> > >  	case INTEL_PIPE_CRC_SOURCE_PIPE:
> > > -- 
> > > 2.34.1
> > > 
> > > 
> > > 
> 
>