Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 11:44:55 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Zhenyu Wang <zhenyuw@linux.intel.com>,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        <dri-devel@lists.freedesktop.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        "David Airlie" <airlied@gmail.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for
 vgpu_status debug attributes
Message-ID: <Y8giB988U5cqsGdd@intel.com>
References: <cover.1673375066.git.drv@mailo.com>
 <188df08e0feba0cda2c92145f513dd4e57c6e6cf.1673375066.git.drv@mailo.com>
 <Y72zVXYLVHXuyK05@intel.com>
 <Y8TkTi+/GQwhiMvO@zhen-hp.sh.intel.com>
 <Y8b3IRhx976Ke99X@intel.com>
 <Y8d6CwD3dHLKOUZ5@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y8d6CwD3dHLKOUZ5@ubun2204.myguest.virtualbox.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xYdxfYNlmAI0tWXP/TIIxSGrcVBcDVkyRWba9SF38fixOVWBdRQ+qmoal2sY?=
 =?us-ascii?Q?76XAJKESbqr7wDRiMzs/YufEtpdX1Ne83AQM1cjSIMsDFeYCFH3doYYWo1iL?=
 =?us-ascii?Q?nVGbTiDvv42wEEThTu/i6bE8XOcwEfISrqqlaOjfnQyOyjRx30Mr1txXpdos?=
 =?us-ascii?Q?fzukIVNygT7RTwnbc8Pv3F0/Xz7+Fbjp7M7leGX/FREPNjoYe4aPR4IwwQsc?=
 =?us-ascii?Q?JsNxn7gGLyARjGN5WLLzxQsqQHtZN3WnOKLB6DT5jRWEoyTNdsSVkOLOtWal?=
 =?us-ascii?Q?oDVqR78jGpHvTdvL8r4YTRfeJm4qzHO98RjkEE8y5CA0j8ylFqFj8ekEoVNT?=
 =?us-ascii?Q?/kW+Dgqi811PetWNY0I7ReVxU2c8rLwT0kRJI5yT4RaeS6yQiygbUff78BUS?=
 =?us-ascii?Q?sOQedMSTZJTnTVT+9TP9fzyofGvmNjQFbtTDmViCxdA31oINOI57fC+VC43T?=
 =?us-ascii?Q?IqgPKTk3JwmVibAVV0opbecMGtwwI5p6SP+JdBiojGEY22p+i+OndaWQUxFZ?=
 =?us-ascii?Q?JGXPvorLSiaiMJP3luSfS7unBilXJo/B0DducvEJiwqLo18hLPc1VY/HxqEu?=
 =?us-ascii?Q?MNWzHYe8+WZOGmvdeTt0IuwQD4U1/ToaiXHW/473M3lEjOrIfUm3ivgrP/SX?=
 =?us-ascii?Q?unlVaRPapTQBBui4kBTFhjIpDedGcS0P9ugKdd2U46GY26Qv24AKg+kvscoS?=
 =?us-ascii?Q?EYN2hDZygmUiYshEkVhMN6xCwmdb7Jq7d8QioBc2soampVh7Q1TDLnQVaQCL?=
 =?us-ascii?Q?Ktwsa45fUh0xPrqVKBoesx8HX+w6tVxXYNIMnWjiLCrtzbVwavEHzuU2QqEe?=
 =?us-ascii?Q?60vx6IY8LxZ1KbdDd26xClJYexziK1cWlRqJJzkAiDgRkqL3LJP4ZbuhN8B2?=
 =?us-ascii?Q?P5uFYT7g5b2HazoZh/day6bPmm5LXyBHpwg3vxPcVisq83Vh97fhN/AsyDrN?=
 =?us-ascii?Q?gNIYhTt6D7GOomJGT7QhZRd4yoR0wucY06TPK2B5hNOSLIOa9mzf71MP6+Fs?=
 =?us-ascii?Q?lgNg1LiH/FvqEkDTAjRH+EH6cbWJjgLCpDL7NBJ9CedJlWvjL7m0WlzFx3kv?=
 =?us-ascii?Q?rcm7PPMtlSepZsl1YHbg8DgmKD2bChCQUi4+pH3PKfbgKYNIRm9EEvrE4qXE?=
 =?us-ascii?Q?G0Zjh9Di1DDeIQxkgXU5A+wqn7QqhrcwT+j66MRQwt+osP/Z3fsDA0gTI9Mp?=
 =?us-ascii?Q?yAE1HFcPkl2ByVRJ0LydYqJIo49qtJEVqGNgYhPRL0XfxYZj48cc29VRwDGD?=
 =?us-ascii?Q?v1DTVhTJLQCPY7yc9067TSsiy5GcEDiETUD6LLSe66L3JHpMA1/kaMQDDHUj?=
 =?us-ascii?Q?/Ci4dwVOHifbwGUdAmdSNhWjByRU+IM4O3aJpKNbVgEyxRb85efzWt87n3ZV?=
 =?us-ascii?Q?djG69Sqk51VH9l3I3c2S5DfXkFIMXNqXeA3u7r7KbSB89tYeyRjQSuaNzTcK?=
 =?us-ascii?Q?NRvNt4iSQy8lfYNtx2xXrIQ0va4aCdIFwdgj5cDQ8zbJ4I9nMl5cDUIJui9G?=
 =?us-ascii?Q?u+APiWbc29t1atEK5ONIgbe2+O1wmk7mzNqnBiQsO/JGXnkBwtYuqTVpS89c?=
 =?us-ascii?Q?Al1nr3FUNoL+6h1j4H+N11sHhwJsRjYOuP6NgYQ+GGBqjpL/yckQ6ypZje/1?=
 =?us-ascii?Q?PA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 883d4d52-ac37-4007-8ced-08daf97356e0
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 16:45:00.5457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3H0ZvmTws/0m6mg30pfdwDGoy9M/PVh6jyh6YJeaIbRpZUGUWeHz119yIOq9daOUj4uLeOzq1xEpJj/V8xPJHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6943
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 18, 2023 at 10:18:11AM +0530, Deepak R Varma wrote:
> On Tue, Jan 17, 2023 at 02:29:37PM -0500, Rodrigo Vivi wrote:
> > On Mon, Jan 16, 2023 at 01:44:46PM +0800, Zhenyu Wang wrote:
> > > On 2023.01.10 13:49:57 -0500, Rodrigo Vivi wrote:
> > > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote:
> > > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file()
> > > > > function adds the overhead of introducing a proxy file operation
> > > > > functions to wrap the original read/write inside file removal protection
> > > > > functions. This adds significant overhead in terms of introducing and
> > > > > managing the proxy factory file operations structure and function
> > > > > wrapping at runtime.
> > > > > As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired
> > > > > with debugfs_create_file_unsafe() is suggested to be used instead.  The
> > > > > DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and
> > > > > debugfs_file_put() wrappers to protect the original read and write
> > > > > function calls for the debug attributes. There is no need for any
> > > > > runtime proxy file operations to be managed by the debugfs core.
> > > > > Following coccicheck make command helped identify this change:
> > > > > 
> > > > > make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> > > > > 
> > > > > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > > > 
> > > > I believe these 2 gvt cases could be done in one patch.
> > > > But anyways,
> > > > 
> > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > 
> > > > for both patches... and will leave these 2 patches for gvt folks
> > > > to apply. Unless they ack and I apply in the drm-intel along with the other ones.
> > > >
> > > 
> > > yeah, they're fine with me, feel free to apply them directly.
> > > 
> > > Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> > 
> > Unfortunately I got some conflicts when trying to apply on drm-intel-next.
> > 
> > We probably need a new version, and probably through gvt branches it
> > will be easier to handle conflicts if they appear.
> 
> Hello Rodrigo,
> Sure. I will send in a new version. I am current using linux-next git repo as my
> remote origin [tag 20230113]. Are there any specific instruction/location from
> where I should access the gvt branch?

https://github.com/intel/gvt-linux.git

but with the linux-next your patch is probably right for them.

> 
> Thank you.
> 
> > 
> > > 
> > > thanks!
> > > 
> > > > > ---
> > > > >  drivers/gpu/drm/i915/gvt/debugfs.c | 6 +++---
> > > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c
> > > > > index 03f081c3d9a4..baccbf1761b7 100644
> > > > > --- a/drivers/gpu/drm/i915/gvt/debugfs.c
> > > > > +++ b/drivers/gpu/drm/i915/gvt/debugfs.c
> > > > > @@ -165,7 +165,7 @@ static int vgpu_status_get(void *data, u64 *val)
> > > > >  	return 0;
> > > > >  }
> > > > >  
> > > > > -DEFINE_SIMPLE_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n");
> > > > > +DEFINE_DEBUGFS_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n");
> > > > >  
> > > > >  /**
> > > > >   * intel_gvt_debugfs_add_vgpu - register debugfs entries for a vGPU
> > > > > @@ -182,8 +182,8 @@ void intel_gvt_debugfs_add_vgpu(struct intel_vgpu *vgpu)
> > > > >  			    &vgpu_mmio_diff_fops);
> > > > >  	debugfs_create_file_unsafe("scan_nonprivbb", 0644, vgpu->debugfs, vgpu,
> > > > >  				   &vgpu_scan_nonprivbb_fops);
> > > > > -	debugfs_create_file("status", 0644, vgpu->debugfs, vgpu,
> > > > > -			    &vgpu_status_fops);
> > > > > +	debugfs_create_file_unsafe("status", 0644, vgpu->debugfs, vgpu,
> > > > > +				   &vgpu_status_fops);
> > > > >  }
> > > > >  
> > > > >  /**
> > > > > -- 
> > > > > 2.34.1
> > > > > 
> > > > > 
> > > > > 
> > 
> > 
> 
>