Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6867972rwb; Wed, 18 Jan 2023 10:18:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXtgyBGU72bDFmD3uXLhZ0sO9XYY0uV6vUAIba7Y5fUCAVaTDQ05VOCQpCSLfhdUYsh0QtbW X-Received: by 2002:a17:90b:1992:b0:229:989e:71d5 with SMTP id mv18-20020a17090b199200b00229989e71d5mr7987520pjb.6.1674065924671; Wed, 18 Jan 2023 10:18:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674065924; cv=none; d=google.com; s=arc-20160816; b=hgrp/+c0NQCDj53XvCwpVaXH+7quoNIXdUcreOtijQpknsXYRQ/S7hY2vsDOlOJ4uX 987E2tqVG3wTP17Y1tvAFpR9vTIS0LtQ2W488Lcyx17ye0V5RRiHkEkNYfEfsA9K3LZL jWSRycgyZShpQLVHB8xkSgsWMENQTRoj8OxmC7W0BqYWeUPA7LxIauNdrd5yb2movYp1 CXPfM3EMQJ35+ikd8pH1FbFYABfs0zwZPOumxi4mv3ulUpxWxbt+onCXHxCP4wOd4PeS j37M6tEzyrgx5K45ew15EkoJb0/ss1DpT/JqKk++xpu2XWxjHdSBC+m7Zakr3Cq624gJ dSmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=p2NaqA9q9WjYL84Tv3k7fozZNI5pbm41qXkSl3p42HY9Ts4QetZ7YgIkKqFJb9TYdz 4BXcP/AnFZJQZu8w5N3ujkfCXijbs0bioE73vqHaNT11ta7KbE3LOWRa0n0XV77AJXCs KcPLT2woTb3AVwiYag+wuhVOurZw0nC4XUdTBJDnHMjWr6iQG93o86emS1DmHsX3S22W c3Dz3qCswDtDwg+9SMcGEFIWk83YZtjuTMK+FST2h9/yzNSjhU8mC1jxPziEu67VpIRG T9CHPwFaERuIuSO6rxjCg5RCdFP/yvCipGKzkM4bKQk/TZwQY0SzXJnW8dFuwXvITJRp PCSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id na11-20020a17090b4c0b00b00225c1d3a26asi2877334pjb.110.2023.01.18.10.18.39; Wed, 18 Jan 2023 10:18:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230268AbjARRn4 (ORCPT + 45 others); Wed, 18 Jan 2023 12:43:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231282AbjARRm7 (ORCPT ); Wed, 18 Jan 2023 12:42:59 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 367A646158; Wed, 18 Jan 2023 09:42:31 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 1054168D13; Wed, 18 Jan 2023 18:42:28 +0100 (CET) Date: Wed, 18 Jan 2023 18:42:27 +0100 From: Christoph Hellwig To: Kemeng Shi Cc: hch@lst.de, axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, john.garry@huawei.com, jack@suse.cz Subject: Re: [PATCH v4 13/14] blk-mq: use switch/case to improve readability in blk_mq_try_issue_list_directly Message-ID: <20230118174227.GI12399@lst.de> References: <20230118093726.3939160-1-shikemeng@huaweicloud.com> <20230118093726.3939160-13-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230118093726.3939160-13-shikemeng@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig