Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 18:36:21 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Kemeng Shi <shikemeng@huaweicloud.com>
Cc:     hch@lst.de, axboe@kernel.dk, dwagner@suse.de, hare@suse.de,
        ming.lei@redhat.com, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, john.garry@huawei.com, jack@suse.cz
Subject: Re: [PATCH v4 06/14] blk-mq: remove unncessary from_schedule
 parameter in blk_mq_plug_issue_direct
Message-ID: <20230118173621.GB12399@lst.de>
References: <20230118093726.3939160-1-shikemeng@huaweicloud.com> <20230118093726.3939160-6-shikemeng@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230118093726.3939160-6-shikemeng@huaweicloud.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Wed, Jan 18, 2023 at 05:37:18PM +0800, Kemeng Shi wrote:
> Function blk_mq_plug_issue_direct tries to issue batch requests in plug
> list to driver directly. We will only issue plug request to driver if we
> are not from scheduler, so from_scheduler parameter of
> blk_mq_plug_issue_direct is always false.
> Remove unncessary from_scheduler of blk_mq_plug_issue_direct.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>