Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <705c78c1d0da18089419b064832d5fed.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <063c5516-417d-7c21-b58f-a6552779a621@linaro.org>
References: <20230113145859.82868-1-krzysztof.kozlowski@linaro.org> <e73ad320fafa1365e3506bbd4cc77d8d.sboyd@kernel.org> <063c5516-417d-7c21-b58f-a6552779a621@linaro.org>
Subject: Re: [PATCH] dt-bindings: clock: qcom,a53pll: drop operating-points-v2
From:   Stephen Boyd <sboyd@kernel.org>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 18 Jan 2023 11:11:00 -0800
User-Agent: alot/0.10
Precedence: bulk

Quoting Krzysztof Kozlowski (2023-01-15 06:35:23)
> On 13/01/2023 21:28, Stephen Boyd wrote:
> > Quoting Krzysztof Kozlowski (2023-01-13 06:58:59)
> >> The CPU PLL clock node does not use OPP tables (neither driver).
> >=20
> > What device is qcom_a53pll_get_freq_tbl() operating on?
>=20
> On its own, internal table. While of course driver could be converted to
> operating-points-v2, no one did it within last 5 years, so why it should
> happen now?
>=20

The property was added mid 2021 by Shawn[1], that's not 5 years ago. I
guess there were plans to add an OPP table that never happened[2]? Is
Shawn still working on this? If not, we should revert the OPP code out
of the driver.

[1] https://lore.kernel.org/all/20210704024032.11559-4-shawn.guo@linaro.org/
[2] https://lore.kernel.org/all/20210709021334.GB11342@dragon/