Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6961271rwb; Wed, 18 Jan 2023 11:32:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXv26CYl7Rv7S3LDrpTW5+/53bOxunNXcIlyceR9F863xO/7FkW9ZOPbkrY1365EiWZ6dyFO X-Received: by 2002:a05:6a00:d64:b0:572:6e9b:9f9e with SMTP id n36-20020a056a000d6400b005726e9b9f9emr7837713pfv.19.1674070354688; Wed, 18 Jan 2023 11:32:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674070354; cv=none; d=google.com; s=arc-20160816; b=J434O5W6m2vNzbcRwfiNJACCT41wC0nAjStwkuLj8gO7sWV/xQuEAvCVgCNjfdtc7Y LiYvacN7hXxo94QhukqOd6MkxqM61Jg/ffpEGnZSJTsIE+DEWjTZiwLcmRvWHy+M4qT7 TRV11fTfU2edj+8/Es2hzUYlaogbQZ6Ndj5pQUrAP1InkAc1LZMuxS6k57/LbKGNdZvu 4FgibMahzZ1ex3t0CHoaxP8pbc7lSjaI9T6SyJ76bT/ujoT0nrt/Qt3f+z2YvCvy7DKt uMC/hWd8JB6LNR84olr96oE4yPKjz+i15bd/csnZ1zdMVKjaS+e8OJi2+z5de0SYBkA/ +CdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=weTLZG8IsGIN+dW9FnU1+H8fULkXuUXBKDQBQ6V8wqU=; b=PQaJwz6Xa1KcLup1WhHNBQ7v/I7cqcyJFAD2IdtQmYl2JK23vfgbMajWccy91fWHim 6IMNovXuE2nA0lgK5VIpPJIxBYJMC5d18GHesBW3hHk1d6Z/xrnq0QWHmu0hYTWGoiXp u0B0n/3XNPhDo0NamvBf/AoifkT4WquSbtD4DsGwyQcNOIkh2VUMNJC90uzyPv6oY/xW avfak/mpK+lds0NBAf9lS1zqya1gjoTJnsSqwrCLgTS9BAlAESpxOWSieHM7PlctlkZ4 mjU8igxE2yXmWbhiZ0c4ySIRIqE8Q3VXuSLgrdtq/XJFuZBUKjyRRacrgYOlK4g3nqFT 3HuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SLzj9xO0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s22-20020a056a00179600b0058dbb06c94dsi8846710pfg.291.2023.01.18.11.32.29; Wed, 18 Jan 2023 11:32:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SLzj9xO0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229814AbjARTCQ (ORCPT + 46 others); Wed, 18 Jan 2023 14:02:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229892AbjARTBL (ORCPT ); Wed, 18 Jan 2023 14:01:11 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 302B35B479; Wed, 18 Jan 2023 11:00:40 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6E8B619C6; Wed, 18 Jan 2023 19:00:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C59BC433EF; Wed, 18 Jan 2023 19:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674068439; bh=weTLZG8IsGIN+dW9FnU1+H8fULkXuUXBKDQBQ6V8wqU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=SLzj9xO01/OI/eGBS3unEvefzng3fwo3+fycbHhn7MXd7g6HSBXi9e4KNPmgNjzMP MrPfPMbeTgq42EYUIeqjlQisKw/MmoNTmLqOUkrT9GUbF12AB/Niwca98J0RC7yhht HUH2SdHvw6PQLpu7NM0A8+moC0cgI+65AMwjDftVpUMQXn3HDERfjgPYJQvG9Zat9s vnyA919v0HhUa2qBgheQd3E6QYb0bkQ5oYAPn8xr+5gVgbgDF/dXNP1SIwLPpyGYVD 6lAMtFJ51ZIeBYjrZKSJFuLl5B+3MPjQO9d1zXERgmPIgVwV+Jy7duZUur6rXMW0It RVil9O9e1naVQ== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20230111101030.686885-1-Qing-wu.Li@leica-geosystems.com.cn> <20230111101030.686885-2-Qing-wu.Li@leica-geosystems.com.cn> Subject: Re: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE From: Stephen Boyd Cc: LI Qingwu , abelvesa@kernel.org, mturquette@baylibre.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 18701859600@163.com, bsp-development.geo@leica-geosystems.com, Marco Felsch To: Abel Vesa Date: Wed, 18 Jan 2023 11:00:36 -0800 User-Agent: alot/0.10 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Abel Vesa (2023-01-16 06:28:33) > On 23-01-11 11:10:30, LI Qingwu wrote: > > Defined IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV in imx8mp-clock.h > > but never assigned. It will cause the system to hang if using them. > > Alias IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV to IMX8MP_CLK_M7_CORE > > for backward compatibility. > >=20 > > Fixes: 8c83a8ff4dd9 (clk: imx8mp: use imx8m_clk_hw_composite_core to si= mplify code) > > Reviewed-by: Marco Felsch > > Reviewed-by: Abel Vesa > > Signed-off-by: LI Qingwu >=20 > Stephen, can you please pick this up yourself? >=20 Is it needed for clk-fixes? When did the system start hanging?