Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 11:42:30 -0800
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, Song Liu <song@kernel.org>,
        bpf@vger.kernel.org
Subject: Re: [PATCHSET 0/8] perf/core: Prepare sample data for BPF (v3)
Message-ID: <20230118194230.mqitrgfb3j73hzw4@MacBook-Pro-6.local>
References: <20230118060559.615653-1-namhyung@kernel.org>
 <Y8fO/Tro6wstoAeo@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y8fO/Tro6wstoAeo@hirez.programming.kicks-ass.net>
Precedence: bulk

On Wed, Jan 18, 2023 at 11:50:37AM +0100, Peter Zijlstra wrote:
> On Tue, Jan 17, 2023 at 10:05:51PM -0800, Namhyung Kim wrote:
> > Namhyung Kim (8):
> >   perf/core: Save the dynamic parts of sample data size
> >   perf/core: Add perf_sample_save_callchain() helper
> >   perf/core: Add perf_sample_save_raw_data() helper
> >   perf/core: Add perf_sample_save_brstack() helper
> >   perf/core: Set data->sample_flags in perf_prepare_sample()
> >   perf/core: Do not pass header for sample id init
> >   perf/core: Introduce perf_prepare_header()
> >   perf/core: Call perf_prepare_sample() before running BPF
> 
> Thanks!,
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Thanks Peter.
The patches look good to me as well.
How do you want to route them bpf-next or tip ?

Namhyung,
I'd also like to see a follow up patch with a selftest/bpf for this.

BPF CI didn't have a chance to really test the set, since
there is a build issue on s390 due to llvm upstream repo.
We're aware and working on that.