Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ba437ae5bd782ec2a6a8351f4c667aa16014af97.camel@linux.ibm.com>
Subject: Re: [PATCH -next] evm: Support small xattr in dump_security_xattr()
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Xiu Jianfeng <xiujianfeng@huawei.com>, dmitry.kasatkin@gmail.com,
        paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com
Cc:     linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 18 Jan 2023 15:23:43 -0500
In-Reply-To: <20221226102419.16189-1-xiujianfeng@huawei.com>
References: <20221226102419.16189-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Xiu,

Thank you for cleaning up the code.  The purpose of this patch is to
remove code duplication.   Perhaps rename the patch to "evm: call
dump_security_xattr() in all cases to remove code duplication".

On Mon, 2022-12-26 at 18:24 +0800, Xiu Jianfeng wrote:
> Currently the debug function of dumping xattr is splited into two parts,
> when the length of xattr is less than 64 bytes, it uses pr_debug()
> directly. Merge it into dump_security_xattr() to simplify the code, no
> functional changes here.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Please reword the patch description in terms of removing code
duplication.

-- 
thanks,

Mimi