Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3d5435a0-b01f-9015-3d7f-525001bf77ad@intel.com>
Date:   Wed, 18 Jan 2023 13:24:55 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts
 driver
Content-Language: en-US
To:     Siddharth Vadapalli <s-vadapalli@ti.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <linux@armlinux.org.uk>,
        <pabeni@redhat.com>, <rogerq@kernel.org>, <leon@kernel.org>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <vigneshr@ti.com>,
        <srk@ti.com>
References: <20230118095439.114222-1-s-vadapalli@ti.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20230118095439.114222-1-s-vadapalli@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTl6amdRU3AxLzJMekppQXJxalFwa2xpZ0VIb1lFYnFvcldYRjVMUWxPRlNQ?=
 =?utf-8?B?MElNaTJCZ3hpSDJHYitnZjlVYjhadkZBSHQ3RHAxRUk1ZXlFSUNKOWkyM3hS?=
 =?utf-8?B?bTFKR0dqaUljUGxZSjhHSjI3T1pBa1pLdHcyVDhjY0owRHR6THlBdHFWNkhz?=
 =?utf-8?B?dE1MWHlqTzE3OUtzbWZMVTB0QWlVRGpJMDJOSzV3WnN0blk0M0VQaGFYQzF3?=
 =?utf-8?B?bmRlSVVYMWo0VCt0NjJ0RFVGM2ZGb3NPU2VyZFlJYjRVdVA1dnhML28zbzdV?=
 =?utf-8?B?ZHRYejh6aFpKVG5sZSt4RERCNHV5RVFDQWZvazd2RVdLMWRjTUUwVW81UXhs?=
 =?utf-8?B?RG9UQkNHVkxFN0hMM2dFZmNJNHdXaUZmQlE0Z0VzdGdUbU01MFdzcWNuMkNs?=
 =?utf-8?B?RTFpd21FNHR2T3p6YjBqTnl3bThCWVJlNnRXK0dpY2RxM3k3MkJiZmlpQXVq?=
 =?utf-8?B?b0VmK2ZKQVFLSE5QcWpoMEVYL25XYWtTWmU3cXlocjVCYWxpR0FwMGY0eE9t?=
 =?utf-8?B?d0J3LzF2T0NVWmdkVFJaaHl3Ri93bU95SjhtenROcG5qNGJaRjI5V2RxcWZL?=
 =?utf-8?B?c1lUUW9rTzJ2RzNQOEZCWVQyNWVtMitobFd3Uk0wRzFaQjk2YkVQTFNKazlm?=
 =?utf-8?B?Z1ozcEJRUEVpRUx4b1RGQ1dnWFgveTZnc1FDWi9OQ0FwTW93eElicmJ0V1hu?=
 =?utf-8?B?bHZLL3MyQ3dkUmpvWXlCNEF3SldwSXEraGlZNzNCVDZ3SDZKY0xVN0M5b3hi?=
 =?utf-8?B?N0Z0bFQvWGxNWmJEdm11eXE0Q1BVOHMyWENDVjBya2pxL1YyZEN2clk1RTcw?=
 =?utf-8?B?T0wrMWxNeThGakVkc3lkSk4rNWd6TVBzTWp5QUVsemZSR0Z1RWxuRlk0RjFU?=
 =?utf-8?B?QzJ2YjdGUE1iSkE5VU1jb1M4TEF6WmpQZlc1L3YwL3Z4T1h2M1A4SytISmpQ?=
 =?utf-8?B?dm5YaC9vY2I4Mkd5aVdEVkdndmJLaXJOMVdIc0E1TVBHeXVxR1lyUnJldDl5?=
 =?utf-8?B?aDRzb1c5ZUp3U25ha0M5ZWphZ0FQZFhobmtuSUE1OGt2Ymg2S1pZSzVlRTVy?=
 =?utf-8?B?VFdack1OUzg1SG1nTVRiZGo3Uitpa2xYbzdyeWdyMnJ0U0hwU0hoemJDSDRT?=
 =?utf-8?B?bkdwMWRzKzJPRXNXOG5VVnZuUDRQMzgvVXc0bmRMU1cwL0FaZ3VQc2paYWhj?=
 =?utf-8?B?ejhaVDZzVVN4VlUyZ0hacjJoQzhieVd2bmUwWDVTSzQyQXhTbEI5Z3BGVTYx?=
 =?utf-8?B?YTU5Rkc2d25Jak1iTkhVcW1HNkZYazNlMnI3WmNjcThyeFZ3VmVuUmkwUllm?=
 =?utf-8?B?dEZ4Sjk5T0g2V2V0MW1rTEt6eHhoK1FBWWllQndtVGlLeGxJajhDdll3SmtL?=
 =?utf-8?B?Vm9hWDJGVlFycm96blZrTERQTTRua0FMNTEvL2JoYU9OTkRjTkk4M014Y3Bz?=
 =?utf-8?B?UDlTYm1lQ3U4N3plVkN1QzZ2c2VkUjErU2QybHZObEdsakFLbjZqRXRUM3Vn?=
 =?utf-8?B?NnRLOG1MZmxoQ3RENytTMEVpUFZIczVQZ1hkWXlYU0tWUmdEd0tGL2x1R1p3?=
 =?utf-8?B?Y2hDVm53bXRLQi9tRnh6UGI2VERCUXhVSXlNcXd0K2k2QUthMnF0K0c5a3pB?=
 =?utf-8?B?d1VndkJKQUc0SHpzNk1xNXdhZGFlQjQzc2J4bDE2R2w4bFcrOWhMWUM2WDRh?=
 =?utf-8?B?eDl1OGJScVAyNzY1OWtCZ2NVVnJHb2dFSTIxUnFGTHJhendONkJmQlpNZVBj?=
 =?utf-8?B?OXBYYXJ2dnJKVVNhSlZQTkZCMTYrd21sNlRCckNpaWdLektETWFBU0FXNXcy?=
 =?utf-8?B?eTQ4TVNsd3c2WnFLNXRadjRrMDFqNkFVek94WExTeG5aUzAwd2NXZlkwZHha?=
 =?utf-8?B?dmp1RjM0LzVmZFQzNUQzUXNacTh1Z0ZLbWF2S2ZoWUV4YUZlcjZQbUxLd1dK?=
 =?utf-8?B?Qk01MzBHdkJ6bEdPR0VWbzRDemEzN3FVUkhOc0NOenhsYk9vZTJNNStuK29S?=
 =?utf-8?B?U2FJUTQ2ODl4TUtqeWRDbWtPa3M1Si80NmYrUmhoRit0TEd4VFd6d0lVaU1n?=
 =?utf-8?B?eFBZdFFpQm5QRm5vcDNldHNoYnA0WFlkQmRFWm8ydEJ1MTlwdWtMVzBleXZm?=
 =?utf-8?B?OEx3cEpNVjF2S0JVbzNCbjJoQ2pRa1NlUW93SG9kOXFFQWVORVhrYXIrRU1l?=
 =?utf-8?B?NGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e5d9813-ea00-4a40-ba33-08daf99a7369
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 21:24:58.5122
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v7ifQhMrFHFUdF/DfDTN0qAYaVGy8vTkPsfgY+BxORd+T9YSz3G9G2NhZz9hGQeWMIhC+/G5cWoVlKO5pAbfGbOLtJq881MlBB+QbNzb0MI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6139
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/18/2023 1:54 AM, Siddharth Vadapalli wrote:
> Delete unreachable code in am65_cpsw_init_cpts() function, which was
> Reported-by: Leon Romanovsky <leon@kernel.org>
> at:
> https://lore.kernel.org/r/Y8aHwSnVK9+sAb24@unreal
> 
> Remove the devm action associated with am65_cpts_release() and invoke the
> function directly on the cleanup and exit paths.
> 
> Changes from v2:
> 1. Drop Reviewed-by tag from Roger Quadros.
> 2. Add cleanup patch for deleting unreachable error handling code in
>     am65_cpsw_init_cpts().
> 3. Drop am65_cpsw_cpts_cleanup() function and directly invoke
>     am65_cpts_release().
> 
> Changes from v1:
> 1. Fix the build issue when "CONFIG_TI_K3_AM65_CPTS" is not set. This
>     error was reported by kernel test robot <lkp@intel.com> at:
>     https://lore.kernel.org/r/202301142105.lt733Lt3-lkp@intel.com/
> 2. Collect Reviewed-by tag from Roger Quadros.
> 
> v2:
> https://lore.kernel.org/r/20230116044517.310461-1-s-vadapalli@ti.com/
> v1:
> https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli@ti.com/
> 
> Siddharth Vadapalli (2):
>    net: ethernet: ti: am65-cpsw: Delete unreachable error handling code
>    net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action
> 
>   drivers/net/ethernet/ti/am65-cpsw-nuss.c |  7 ++-----
>   drivers/net/ethernet/ti/am65-cpts.c      | 15 +++++----------
>   drivers/net/ethernet/ti/am65-cpts.h      |  5 +++++
>   3 files changed, 12 insertions(+), 15 deletions(-)

Seems reasonable to me.

Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>