Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230118150703.4024-1-ubizjak@gmail.com> <20230118131825.c6daea81ea1e2dc6aa014f38@linux-foundation.org>
In-Reply-To: <20230118131825.c6daea81ea1e2dc6aa014f38@linux-foundation.org>
From:   Uros Bizjak <ubizjak@gmail.com>
Date:   Wed, 18 Jan 2023 22:47:06 +0100
Message-ID: <CAFULd4ZQGG+N3f7xDuoiNG1jY128pqaH0F4eLKO+fhvSNAbKfA@mail.gmail.com>
Subject: Re: [PATCH] lib/genalloc: use try_cmpxchg in {set,clear}_bits_ll
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 18, 2023 at 10:18 PM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> On Wed, 18 Jan 2023 16:07:03 +0100 Uros Bizjak <ubizjak@gmail.com> wrote:
>
> > Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
> > {set,clear}_bits_ll.  x86 CMPXCHG instruction returns success in ZF
> > flag, so this change saves a compare after cmpxchg (and related move
> > instruction in front of cmpxchg).
> >
> > Also, try_cmpxchg implicitly assigns old *ptr value to "old"
> > when cmpxchg fails.
> >
> > Note that the value from *ptr should be read using READ_ONCE to prevent
> > the compiler from merging, refetching or reordering the read.
> >
> > The patch also declares these two functions inline, to ensure inlining.
>
> But why is that better?  This adds a few hundred bytes more text, which
> has a cost.

Originally, both functions are inlined and the size of an object file
is (gcc version 12.2.1, x86_64):

  text    data     bss     dec     hex filename
  4661     480       0    5141    1415 genalloc-orig.o

When try_cmpxchg is used, gcc chooses to not inline set_bits_ll (its
estimate of code size is not very precise when multi-line assembly is
involved), resulting in:

  text    data     bss     dec     hex filename
  4705     488       0    5193    1449 genalloc-noinline.o

And with an inline added to avoid gcc's quirks:

  text    data     bss     dec     hex filename
  4629     480       0    5109    13f5 genalloc.o

Considering that these two changed functions are used only in
genalloc.o, adding inline qualifier is a win, also when comparing to
the original size.

Uros.