Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <820cf397-a99e-44d4-cf9e-3ad6876e4d06@intel.com>
Date:   Wed, 18 Jan 2023 14:22:43 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [Intel-wired-lan] [PATCH] ice/ptp: fix the PTP worker retrying
 indefinitely if the link went down
Content-Language: en-US
To:     Daniel Vacek <neelx@redhat.com>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        "Kolacinski, Karol" <karol.kolacinski@intel.com>,
        Siddaraju <siddaraju.dh@intel.com>,
        "Michalik, Michal" <michal.michalik@intel.com>,
        <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
        <linux-kernel@vger.kernel.org>
References: <20230117181533.2350335-1-neelx@redhat.com>
 <2bdeb975-6d45-67bb-3017-f19df62fe7af@intel.com>
 <CACjP9X-hKf8g2UqitV8_G7WQW7u6Js5EsCNutsAMA4WD7YYSwA@mail.gmail.com>
 <42e74619-f2d0-1079-28b1-61e9e17ae953@intel.com>
 <CACjP9X8SHZAd_+HSLJCxYxSRQuRmq3r48id13r17n2ehrec2YQ@mail.gmail.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <CACjP9X8SHZAd_+HSLJCxYxSRQuRmq3r48id13r17n2ehrec2YQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDJQdVZTQTB6bCtlakc4azRYQ3VBc2JXYWtZaWpmZHdLa1I2Tm1jSG15TGNa?=
 =?utf-8?B?c0NpaGdseXBhWW5EajFlai9zWkR6a3Ria1FRekJkb2pwUmZFc3hwam9ieVB3?=
 =?utf-8?B?RGhTbWE1QUpYY3JOdUg2bVNvTEZlVXFoYUVpQXdpcGcvSHlqSnNtZDZoZzQw?=
 =?utf-8?B?dTFGVmZML1JBSHlJOUdTTEw4bGdKSkRpRjZ3NTJmNTI5SmRxUCtWaUVyTHd2?=
 =?utf-8?B?RzVCN0JUODNvcjQyRTA5SlpaUFJxQmpidEVJZzh5TVh0SnZTaVBCdUNYcjZ1?=
 =?utf-8?B?cmswbG9TVTdQSnhxMjk2Y2JsT3kyWGM2Q3dtR1lkamFOVVEvWjNSMU9sQU83?=
 =?utf-8?B?cDlRdFMvQWlMRlorTFRFMnJEeTl5SzRObnNicTUrTHhNZ0t5UCt1UUdoS0E3?=
 =?utf-8?B?Y2ptYXFkZFlCbUhyMTM0RzFGTkNtd1d2ZDRybklGRDBhc00rOVcxaXJ3N3pr?=
 =?utf-8?B?L052NFAxQkZrVXNCQ3A4Y1pHY2V6SHRYQkw2MnFULzZseWk1NDFRL2crTXRr?=
 =?utf-8?B?Qkc4VG85cllFVCt6aElocUI4SHVFWmlPZGVVL1ZKNnJOMXRjYXhxdWZ6ZlNh?=
 =?utf-8?B?MmVod3hpbnN1cUR2Z3pCZXoxdmJKUlowYzJPM3kxZE9TRnFHMGRWZWFOb3RJ?=
 =?utf-8?B?NmZNSjI5eEIzZUx4eDhkS1ZXSUJ0TGRabmgxMUxUWUw2YVNwRE9KbDByL0JO?=
 =?utf-8?B?R2Nlczg1VTU4bEFsU1lDQmR1V1dMWHYrejVaWVFLY2JFUXBoV08vdTBhUG9N?=
 =?utf-8?B?SFlGbEtSZWZ1WWd3Y3g0QVU5MGkwSUQxMDlVbnJWeWJld0pJZXFQMjY4YXBH?=
 =?utf-8?B?czdUMm0zNUx0aVpOUGNheWZwZTZSc3JERVhJQkw4NXBIOE9aVXJTdkFJZXJE?=
 =?utf-8?B?cjQ2RDdNV09sRTJRMTRFak9xUW5GdXk2czNWb1FNS0N3QlhvNEdqYlk1bDIv?=
 =?utf-8?B?UlUybkJ0dTRCKzNURVJwTnE1Tkh1NXNiaUxxU1VDY1ZkRVgzaTEyOFNvdVJT?=
 =?utf-8?B?T1NZK05TNURRT0lhUmVRTjhpMWpXYnBXMmt3TjlvcTJYU3RsTjNERVBJU3F6?=
 =?utf-8?B?dGJwazNXQTVEMitEMk5ZZE80MGdrWDNOTXBSaFNIOGFxa1lqQ0NjcjdzV3E1?=
 =?utf-8?B?OGYvMFBORGo3SFF5QzB6QnBpaCtNN3ROa2FFK3MyZURGMnkxdHRsclZ1WS80?=
 =?utf-8?B?R3h2OWVQVFRuaUd5T2V0NFhEM1MvVVRsSThsbFltOVZUUGxqTlZqMGdxd1dG?=
 =?utf-8?B?ajhEUUpLdEJBZnpBTmhIdXREbjJTZWlqOHJ2R1hXQ080Zkt2MEkxRGNrNy9r?=
 =?utf-8?B?WGl4d0swVXJ5TUgwWjFqT0ZyR2wrYUpLWk13bDZMb0FPMmYyWlYwZU04c3Uz?=
 =?utf-8?B?Y2xLcURZbTlkUHlRVGVJdU4rOWNqUkRKbEl6WkNmaGRFYzRSOFQweGF1Q3dk?=
 =?utf-8?B?SmxweUFOMDE0TU1IYmlaZXA3Vi80dVQzNmlzQVM5ZzhjWm5LM1E0blc4cWFR?=
 =?utf-8?B?aWIxSlJtZnR4T3ZFQ0ZCNEQwV09YNzlQajlJd1YxQTIwWmlQeVZQMFJGcDNz?=
 =?utf-8?B?RVBVZU9mcXl5M0VaVUNMUy83WGtJQWRwVjA1NWFBa1U1S3NlU2ZWWnZNVFlK?=
 =?utf-8?B?QzRDWERSQ2VWNHBIblVFSllJcHpuUnk5NXZCYVE5bXFROVkwM2tmWGpMNVZU?=
 =?utf-8?B?ckg5WkFmVTQzd1VmYXdnWEplamloWHZGdXhtbHhuTXp3V0FkSWlLZEcwSUNz?=
 =?utf-8?B?UFFwdEJJbGd0enVTSlVMQXBiUjUvOXRnYWNIdTlVcEFhTGxITmROdFkwTHcv?=
 =?utf-8?B?VjR3a1kvVmRNdjMxcFZueGJvUEJLT1Y5YkYwd1Y4ZWNvdGEycGNYMTR2Q0FI?=
 =?utf-8?B?RVRKQjlxQ0VKTFpLL0pZcC8zRnRnRDdLeDZxeVNJQjl5REFpbmN2MFlISmR2?=
 =?utf-8?B?RjBsQ3NyT0lDY0dMUDdVODhvSjlWSXVKNVRCYmluTElCSnJuMjdNaTMzdGpD?=
 =?utf-8?B?L3pqbjQxR0hVdGJpMXhlSGtON2hHYWxxM0VEdk8vaGhQL0RaYnJ6NkZPTldN?=
 =?utf-8?B?TktrVW0xYUc3emFXWVBNNlVsZERCUDhKQVRIUGlQbkViRTVzNWNWanNlSzdE?=
 =?utf-8?B?WTFqT01RVXBJWjlGTlhuanltZVE1UXpYckJ1bkpKOC94K2JtR0RhbFBibmEr?=
 =?utf-8?B?ZXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a9ae69c7-656c-4904-2634-08daf9a286ad
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 22:22:46.8046
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xx4CDLeML8o3nUrcH2Y9HxgrjUmsjnHOVA2GmpHmtA1h+/WpkMGH7EojGJ2krrWu4z1htxenA8xjAT6RJhh2QSbd5IGmH67AP9WAGolV+k4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6343
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/18/2023 2:11 PM, Daniel Vacek wrote:
> On Wed, Jan 18, 2023 at 9:59 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>> On 1/18/2023 7:14 AM, Daniel Vacek wrote:
>> 1) request tx timestamp
>> 2) timestamp occurs
>> 3) link goes down while processing
> 
> I was thinking this is the case we got reported. But then again, I'm
> not really experienced in this field.
> 

I think it might be, or at least something similar to this.

I think that can be fixed with the link check you added. I think we
actually have a copy of the current link status in the ice_ptp or
ice_ptp_tx structure which could be used instead of having to check back
to the other structure.

I'm just hoping not to re-introduce bugs related to the hardware
interrupt counter that we had which results in preventing all future
timestamp interrupts.

> --nX
> 
>> 1) link down
>> 2) request tx timestamp rejected
>>
>> Thanks!
>>
>> -Jake
>