Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c3bd2bf7-e174-3afd-43d2-7010d9809815@oracle.com>
Date:   Wed, 18 Jan 2023 17:07:25 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] scsi: fix iscsi rescan fails to create block
Content-Language: en-US
To:     Zhong Jinghua <zhongjinghua@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, bvanassche@acm.org, emilne@redhat.com,
        hare@suse.de
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        yi.zhang@huawei.com, yukuai3@huawei.com, houtao1@huawei.com
References: <20230117030114.2131734-1-zhongjinghua@huawei.com>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20230117030114.2131734-1-zhongjinghua@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVErdVptTlhkQmRhcHcrWldZb1l5dVl6UVNhWXZqbGxpZEZ0bTh6djFOK3dG?=
 =?utf-8?B?cXp2amtQVm96QTJCQXFvVEtGM0s3eThBOXlGd3JLSE8wRk5lUWFXdXpxbVRJ?=
 =?utf-8?B?Z0ZuNVMwZWowblN5cFF1WjErVWF6Q3BVVVk5QVpKQk9zUkg4YU9nRmtLUUU4?=
 =?utf-8?B?SzU1VW96VGNCMTNrbWNENlQ1QURLV3NFTU9HMW1RUTQxTTVFVnh4SkhOTU56?=
 =?utf-8?B?OVhueFB0K3k1K3RBb05vSVM3UVhIZURTODVMdnZhb2I1aVR1Qng4blNFbllL?=
 =?utf-8?B?YUJoNVp2WGd3eXF0TnNvWk9icmhRSnkyVW1BdW5kTTFWSmkzNGp4SU16VFBO?=
 =?utf-8?B?aXRHaUtaSHVWc0RYdkEvSkFjQ1hrY2xtVE5TYWpIQm80Q2kzZDQ2TkVyeWpJ?=
 =?utf-8?B?VXFpV0tKTm1Ecm9BVUF2WlQzdHRMejJqdUVZNTdYYWh3RE9GenVrSFNpbkp3?=
 =?utf-8?B?NXlQNVllUDYvSmE4eGx6RWt4d2FRTlM3eno4VHZlYWFoRW1zRDRrWWUvamtv?=
 =?utf-8?B?WkhNRWRoYmtrbFl4Q3luS1ZFeXZMcGNMb1BLdXBHOGJ2Y2x4c3BTbkVSdmNI?=
 =?utf-8?B?cmFFK09VQTFpa2JIYXAvNkc1TzJ0OHB0VXVLT3RFUCtab0s2MCs1S0VOeUFk?=
 =?utf-8?B?eURYT0Q3QmYraE1ZQWhyMUwyS2hJNHIxRG1DZVB0ZUpDdXgzTFVaRGV5VTVx?=
 =?utf-8?B?bUFJeGh0ZW1jVElHM0h2b3BjSzFRTEVNL2t2VE1wZ1laUUFhZk8zSjFob2dS?=
 =?utf-8?B?Y0xZQXZmdEhXVEFpc0R0cDVReHlGVDhxQjBTSC9ReldkajU0OCtpd3Q4dU94?=
 =?utf-8?B?enpzdmExZzBzNnZnZkxJblRDZm1JYmE1Q2pEanFSYmtocHJJb1FPTHJVTUdT?=
 =?utf-8?B?MjM0Q1RtaWdmTTFXd0U5ZlljV1NpTTJRM3o2RUFmNFNYTitJZVpUMElDV0dO?=
 =?utf-8?B?QlpBUk81ZUlrQWk1MDBob1NIYUlQVkdLQzZiNS9oTEVFQm5LdFF3OVRrTVIx?=
 =?utf-8?B?OUNGb0krUkVDOE9uakg0eXVFS0ovMWJCdjFGcENzQm1wZng4K3FuTklveXZm?=
 =?utf-8?B?OUk0aFhNTyttUklwLzgxNTAvRTRER3NTZDh3V1pIQzlhWTYxTHZPRCtaVmNS?=
 =?utf-8?B?WmMwUzhNTTRyMXcrTXo0a0d1WE1GRHBsbkwrSTlUSTFVT1ZPWkxLNnVRZ3g4?=
 =?utf-8?B?clpzQ2Z2anhPSHppbHpXSEVJQkxwK2pwRytKQldiT1YwYW9abDF1V2grMWd6?=
 =?utf-8?B?Q2ZvYVRjK3RCbms3T29XYjZCYU9TUDFvTlJ5UjVxTHZUUjJYcWZvVDVBZnYv?=
 =?utf-8?B?ZHBhOHloRy9pSjF5MHhBWmhRbjJtVmZHVm93L3NDT2FZZVlZWGx4ZS8wYnFP?=
 =?utf-8?B?N3E0WjRtTWNFMnVZTkhPK3ZRYkVhTUJMOUJPNU9XN09QMzZFV3FQQTZrWWZM?=
 =?utf-8?B?cnFMSHVlcHdrZVlpM1Q0YUNhZm9mWTcxcVlPN250UlV6Tk1EZEc4U0Yzdk91?=
 =?utf-8?B?eG5mSnhsZGFMNjA1UGoydVJxWWtlUm4wNmZCNUtPaExwVXo1RVI3eFUyZTdG?=
 =?utf-8?B?eHB0VWhOUjhvbEc2SmdTVFV5d011bHF5N3JaVnMyckZuQTcvNjVEUDlZS1l4?=
 =?utf-8?B?cHJEMERSZHJlc21qODBzUmhQVFpPcmEzUU5OT0hLQXlYR2F5eUJwNGl1enAv?=
 =?utf-8?B?VUxWYjR6QXZaNXV1MmIzUEVpQytXaTBUYjZaNURPVGdzeFo0OGx5QXkxcjlU?=
 =?utf-8?B?Rm1kVkw0WGIyR1NvRkx3QkpLeXFBdEcvQVlRUW5zb3F0ZXJkN3o1a0Irc1VY?=
 =?utf-8?B?Y0tUN2VkbDF4d2VqNnExa0thcFRwQTVpWklhZXNBMGV2OTZhQ3RWazdWZ1JB?=
 =?utf-8?B?QnFmdFkzMFlYTnVJWG5XK3VuUU11N0xTSkNCWjUzdEVBRjdjT29BRUZkQW9R?=
 =?utf-8?B?MzJGazVZQW16a3ZBdHdtN0pJV2NjeXBacmYxekdlaFp5TExycjJLUGZqWnY4?=
 =?utf-8?B?QmVVakFQVEpPa3pxV3R6Rjc3TXNWWnJlUXdZVExvNml3SFd6a1JBaitLRGJF?=
 =?utf-8?B?YVF1NUN6emdQQzQ0SjRwMHVETkc5QTY0NWFxZ2p3NnZxc08weXU5YzZpZjB4?=
 =?utf-8?B?RVV0UW9hK2NyV05ld0QrYjVOb1dJZmU5NlJLQzI2U1k2QldXVUI2YzZ4bzh4?=
 =?utf-8?B?VWc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: FuZV8fZi4s24Dh0IHu5gXDyZI2lDTrwEZ/BXgFxc9rBlIrabX8gxo7m1GAahZAuRyRavfBP5qTapN60htm05/cYY73QiePjRz5uqzdSpQh/ALDaSPeJz5mIe+aeSToZQNKl2YeVQRDiIOk+2DGXw+29UvMRHeREQRWPjFT686K9cBl1EqPbY7NN4YpT0Q+6j75/upHAwHj5B+EG9C2zBRjFgXe4Izi6DCyvvaLsQqNjdMxcul54Yo/lwudSTRLc5AZFtdFcd6HTQTaQbCReqH/qRzI2649v/Iy6oOwjApH1yIR/NS4EiE2NBU9ngH9j12R/4rT7Cb1Oud7SVG7zPMkbFSTyoBCRXxUfJf/H8d4niszwGXUxtI5zWh47b56EKNot3laDju4qF4RP7/uo4TJGyuqSNkEj5BMCB6b9rleYHFiSrUdYltpI1gnfcU2g8X/WrSUGAkByVGzSkZTWrx2THObgucqX/NfMi94YiLsbjdgVBw3JzX5ELLTsoEzb6hltaeAM9KLjzow/I4/xZWl+Q2wYt50JzZTljYZMBELpc4v0DLVSk5K4ZPg6e8VMJARX0ydBLcptQxDy+GO29thOaMNYr0KL97kHXJ5NobO7lOVv7gNFIPErRAqv2/0EtrO9tqUPkPJHFdjjCXN11e86GGiLzvOia69Dv77caOyiMO2YIGNa4+/OLmUPbrFbh5nO3vo8KzgKw5CTfwD4LF0f9z8R+Dr4Lgb2SwCRzDqMpXARDiQqaH+5Kz6gr7RHCML4tgRq7xD7kORqo7ZKR5UvNbcHh+CijbgTtXfMng2/jF3P0vri0P2ckezURbJYzOG1HMkyRMVGho7BLm5JGAflb0d5R/AN6Qdg+aqF2jHLCscVnRUfDUZe+gIMln4SYzeP82dVIb20jxuqlPlkW8A==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4a106e1-0dcb-4b7b-1889-08daf9a8c43f
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 23:07:27.0981
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1M6FIQqEeX/g37mV/XWVt3/sfmn7TCK9FSW64Qwp/ETA69p5WversMKnR5SeCbpCSEgGuCZnevVBo25eFKzt01QkbCY6X+90MnqawuwKj3I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6011
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-18_05,2023-01-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301180192
X-Proofpoint-GUID: XmV-Y00tipLSuLGhlxoNr0Xn56nOAbvZ
X-Proofpoint-ORIG-GUID: XmV-Y00tipLSuLGhlxoNr0Xn56nOAbvZ
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/16/23 21:01, Zhong Jinghua wrote:
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 42db9c52208e..e7893835b99a 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -1503,6 +1503,13 @@ void scsi_remove_device(struct scsi_device *sdev)
>  }
>  EXPORT_SYMBOL(scsi_remove_device);
>  
> +static int scsi_device_try_get(struct scsi_device *sdev)
> +{
> +	if (!kobject_get_unless_zero(&sdev->sdev_gendev.kobj))
> +		return -ENXIO;
> +	return 0;
> +}
> +
>  static void __scsi_remove_target(struct scsi_target *starget)
>  {
>  	struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);
> @@ -1521,9 +1528,7 @@ static void __scsi_remove_target(struct scsi_target *starget)
>  		if (sdev->channel != starget->channel ||
>  		    sdev->id != starget->id)
>  			continue;
> -		if (sdev->sdev_state == SDEV_DEL ||
> -		    sdev->sdev_state == SDEV_CANCEL ||
> -		    !get_device(&sdev->sdev_gendev))
> +		if (scsi_device_try_get(sdev))
>  			continue;
>  		spin_unlock_irqrestore(shost->host_lock, flags);
>  		scsi_remove_device(sdev);

I think the patch will work ok. I don't think we want to mix
in our own reference getting function that works on kobjects
directly with the put_device use a little below that line above.

Since this is the second time (looks like Hannes was wanting one
when he originally fixed this) we've wanted a get_unless_zero type
function did you send Greg a get_device_unless_zero type of patch
already and was that rejected?

Why doesn't scsi_forget_host have the same issue with other drivers and
similar scan/delete/host-removal type of tests? Is there something that
flushes those async scans? I'm just wondering if we can do something
similar for the target removal or if the host removal needs a similar
fix.