Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762498AbXHXOwt (ORCPT ); Fri, 24 Aug 2007 10:52:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754448AbXHXOwj (ORCPT ); Fri, 24 Aug 2007 10:52:39 -0400 Received: from gir.skynet.ie ([193.1.99.77]:47284 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754182AbXHXOwi (ORCPT ); Fri, 24 Aug 2007 10:52:38 -0400 Date: Fri, 24 Aug 2007 15:52:34 +0100 To: Yasunori Goto Cc: Andrew Morton , Kamalesh Babulal , "Luck, Tony" , Jeremy Higdon , Andi Kleen , linux-kernel@vger.kernel.org, Balbir Singh , linux-ia64@vger.kernel.org, Christoph Lameter , linux-mm@kvack.org Subject: Re: [PATCH] Fix find_next_best_node (Re: [BUG] 2.6.23-rc3-mm1 Kernel panic - not syncing: DMA: Memory would be corrupted) Message-ID: <20070824145233.GA26374@skynet.ie> References: <617E1C2C70743745A92448908E030B2A023EB020@scsmsx411.amr.corp.intel.com> <20070823142133.9359a1ce.akpm@linux-foundation.org> <20070824153945.3C75.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20070824153945.3C75.Y-GOTO@jp.fujitsu.com> User-Agent: Mutt/1.5.13 (2006-08-11) From: mel@skynet.ie (Mel Gorman) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2037 Lines: 60 On (24/08/07 15:53), Yasunori Goto didst pronounce: > > I found find_next_best_node() was wrong. > I confirmed boot up by the following patch. > Mel-san, Kamalesh-san, could you try this? > This boots the IA-64 successful and gets rid of that DMA corrupts memory message. As a bonus, it fixes up the memoryless nodes (the bug where Total pages == 0 and there is a BUG in page_alloc.c) by building zonelists properly. The machine still fails to boot with the more familiar net/core/skbuff.c:95 but that is a separate problem. Well spotted Yasunori-san. Andrew, this fixes a real problem and should be considered a fix to memoryless-nodes-fixup-uses-of-node_online_map-in-generic-code.patch unless Christoph Lameter objects. > Bye. > --- > > Fix decision of memoryless node in find_next_best_node(). > This can be cause of SW-IOMMU's allocation failure. > > This patch is for 2.6.23-rc3-mm1. > > Signed-off-by: Yasunori Goto > Acked-by: Mel Gorman > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: current/mm/page_alloc.c > =================================================================== > --- current.orig/mm/page_alloc.c 2007-08-24 16:03:17.000000000 +0900 > +++ current/mm/page_alloc.c 2007-08-24 16:04:06.000000000 +0900 > @@ -2136,7 +2136,7 @@ static int find_next_best_node(int node, > * Note: N_HIGH_MEMORY state not guaranteed to be > * populated yet. > */ > - if (pgdat->node_present_pages) > + if (!pgdat->node_present_pages) > continue; > > /* Don't want a node to appear more than once */ > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/