Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp291351rwb; Wed, 18 Jan 2023 17:51:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXtEMh0OikbxarZrMI8CLbATX0KI1DaDr9sBEgl9QI9wP/U84d6CrI8/52NqFkUXIdpIC6Q9 X-Received: by 2002:a05:6a20:a709:b0:b8:dc72:1766 with SMTP id by9-20020a056a20a70900b000b8dc721766mr6497632pzb.18.1674093101682; Wed, 18 Jan 2023 17:51:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674093101; cv=none; d=google.com; s=arc-20160816; b=jNnN1w4Bjs+BExwdZtUkbFKFs2cRSa/laleFELyykLdoCfniVaI3TfqJN7vWXjKQ4i WBDXqgi0n/9pckW3w9x+1OJQRpzpTghMygreTDUTd8tId9DbFOUkUt6yMweHrUudVBJo KmK0xv2drpM1pAGsxFHjDPZkHpuEpKud/Cw9Y7zfnxf4HkOBYgzZGL6p7Bn/1V7vRxDZ PKXlEwQEeerQ43gUMvsm2H46FDDfQSmgJnlcXc/96UsiQ0uRR2G7zRlMt0ZbREHxrTU6 SVeyR8ysG4oV6zjp6Omw1gF23xpB389eH8TnvKqbT19jdQ7Qwb3BzkwcMcOhSOp20hor P79w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=oe4r0h3mpIvSN47ii4zylZ1rmQUYgFQS1O0MgSApTpg=; b=ZNtvuqRTzRWcp8QeDavNrMH+QrvIfn2p2asaVkt7YMCQzx2sU+BgCexXdy7QLIcvOk +b2VY1HDNZJoMezXA9GQ8X0UuWqk36flSJhMyCbCdsmio/jR2AgsNvuRCX/LojceMTwg eEAXLtr//3ShrBL/C2mm+HEZOr4lWj2xnijrvMNx0Z0vQX1gIVGdU2QNhd3gLiAHgnYw clzMwO3Db5mgK1+/FOoLeh7I9C3yNMtBVAsg9G1miZx2Sjlmx4f6kTW77oxeyEHqJwJx CF1yZxWxaQDlE3IcRbNMc5q5AHsu39OGAC07VSf9tsiSyE82QoL40uLr0rKDrXBtFVl9 bC7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ZPzHVZ3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a656944000000b004c7b0317f22si14639876pgq.712.2023.01.18.17.51.36; Wed, 18 Jan 2023 17:51:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ZPzHVZ3Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230121AbjASB3r (ORCPT + 44 others); Wed, 18 Jan 2023 20:29:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbjASB2u (ORCPT ); Wed, 18 Jan 2023 20:28:50 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4700674966; Wed, 18 Jan 2023 17:23:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oe4r0h3mpIvSN47ii4zylZ1rmQUYgFQS1O0MgSApTpg=; b=ZPzHVZ3QuopuhW4TEcYQ8OENg9 tEYRvyc+DhETJOQ/EKWH0HCPJMDqdBi3k5U0T5gWJL81Z126vnIMF3JHI/ChBbV0pleEN3ZwmZ5pz pYMx5lTBxPgpkvnPVldSX9ax+ZEO2/ZiqsKfk8sj3TQojiQ4zFyWcq2fAxCZpdXIOINUxYykKd3h+ RTah/8IcyI8/0xxjoTC/KF7JyqSzR4RDdek8CPpmIfPbZ1IInjKuClBCU5TIYYt8k7YhUUh+w6eoy md5lonxAZqRVDvJMD7rRJBWrGNwT+/hxl8hpkUmqdz0q1+c9yOnnkF2iOckxNNGx9BUImKKn7TZOD Kf/oXJAQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIJe7-00383m-QX; Thu, 19 Jan 2023 01:23:15 +0000 Date: Wed, 18 Jan 2023 17:23:15 -0800 From: Luis Chamberlain To: Borislav Petkov Cc: Petr Mladek , Prarit Bhargava , Vegard Nossum , NeilBrown , Goldwyn Rodrigues , Petr Pavlu , david@redhat.com, mwilck@suse.com, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] module: Don't wait for GOING modules Message-ID: References: <20221205103557.18363-1-petr.pavlu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2023 at 09:02:52PM +0100, Borislav Petkov wrote: > On Tue, Jan 17, 2023 at 04:04:22PM -0800, Luis Chamberlain wrote: > > and now I'm seeing this while trying to build v5.1: > > > > ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; > > arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here > > You need to backport > > aa5cacdc29d7 ("x86/asm: Replace __force_order with a memory clobber") > > for that. > > Happens when building older kernels with newer toolchain. Thanks that certainly helps. FWIW if someone needs it, I had to remove the double colons on write cr0 and cr4 to compile, but this crashed :( Any ideas? diff --git a/arch/x86/boot/compressed/kaslr_64.c b/arch/x86/boot/compressed/kaslr_64.c index 748456c365f4..9557c5a15b91 100644 --- a/arch/x86/boot/compressed/kaslr_64.c +++ b/arch/x86/boot/compressed/kaslr_64.c @@ -29,9 +29,6 @@ #define __PAGE_OFFSET __PAGE_OFFSET_BASE #include "../../mm/ident_map.c" -/* Used by pgtable.h asm code to force instruction serialization. */ -unsigned long __force_order; - /* Used to track our page table allocation area. */ struct alloc_pgt_data { unsigned char *pgt_buf; diff --git a/arch/x86/boot/compressed/pgtable_64.c b/arch/x86/boot/compressed/pgtable_64.c index f8debf7aeb4c..7471b48524cb 100644 --- a/arch/x86/boot/compressed/pgtable_64.c +++ b/arch/x86/boot/compressed/pgtable_64.c @@ -5,15 +5,6 @@ #include "pgtable.h" #include "../string.h" -/* - * __force_order is used by special_insns.h asm code to force instruction - * serialization. - * - * It is not referenced from the code, but GCC < 5 with -fPIE would fail - * due to an undefined symbol. Define it to make these ancient GCCs work. - */ -unsigned long __force_order; - #define BIOS_START_MIN 0x20000U /* 128K, less than this is insane */ #define BIOS_START_MAX 0x9f000U /* 640K, absolute maximum */ diff --git a/arch/x86/include/asm/special_insns.h b/arch/x86/include/asm/special_insns.h index 0a3c4cab39db..5586e4cf62d3 100644 --- a/arch/x86/include/asm/special_insns.h +++ b/arch/x86/include/asm/special_insns.h @@ -7,49 +7,50 @@ #include +#define __FORCE_ORDER "m"(*(unsigned int *)0x1000UL) + /* - * Volatile isn't enough to prevent the compiler from reordering the - * read/write functions for the control registers and messing everything up. - * A memory clobber would solve the problem, but would prevent reordering of - * all loads stores around it, which can hurt performance. Solution is to - * use a variable and mimic reads and writes to it to enforce serialization + * The compiler should not reorder volatile asm statements with respect to each + * other: they should execute in program order. However GCC 4.9.x and 5.x have + * a bug (which was fixed in 8.1, 7.3 and 6.5) where they might reorder + * volatile asm. The write functions are not affected since they have memory + * clobbers preventing reordering. To prevent reads from being reordered with + * respect to writes, use a dummy memory operand */ -extern unsigned long __force_order; - static inline unsigned long native_read_cr0(void) { unsigned long val; - asm volatile("mov %%cr0,%0\n\t" : "=r" (val), "=m" (__force_order)); + asm volatile("mov %%cr0,%0\n\t" : "=r" (val) : __FORCE_ORDER); return val; } static inline void native_write_cr0(unsigned long val) { - asm volatile("mov %0,%%cr0": : "r" (val), "m" (__force_order)); + asm volatile("mov %0,%%cr0": : "r" (val) : "memory"); } static inline unsigned long native_read_cr2(void) { unsigned long val; - asm volatile("mov %%cr2,%0\n\t" : "=r" (val), "=m" (__force_order)); + asm volatile("mov %%cr2,%0\n\t" : "=r" (val) : __FORCE_ORDER); return val; } static inline void native_write_cr2(unsigned long val) { - asm volatile("mov %0,%%cr2": : "r" (val), "m" (__force_order)); + asm volatile("mov %0,%%cr2": : "r" (val) : "memory"); } static inline unsigned long __native_read_cr3(void) { unsigned long val; - asm volatile("mov %%cr3,%0\n\t" : "=r" (val), "=m" (__force_order)); + asm volatile("mov %%cr3,%0\n\t" : "=r" (val) : __FORCE_ORDER); return val; } static inline void native_write_cr3(unsigned long val) { - asm volatile("mov %0,%%cr3": : "r" (val), "m" (__force_order)); + asm volatile("mov %0,%%cr3": : "r" (val) : "memory"); } static inline unsigned long native_read_cr4(void) @@ -64,17 +65,17 @@ static inline unsigned long native_read_cr4(void) asm volatile("1: mov %%cr4, %0\n" "2:\n" _ASM_EXTABLE(1b, 2b) - : "=r" (val), "=m" (__force_order) : "0" (0)); + : "=r" (val) : "0" (0), __FORCE_ORDER); #else /* CR4 always exists on x86_64. */ - asm volatile("mov %%cr4,%0\n\t" : "=r" (val), "=m" (__force_order)); + asm volatile("mov %%cr4,%0\n\t" : "=r" (val) : __FORCE_ORDER); #endif return val; } static inline void native_write_cr4(unsigned long val) { - asm volatile("mov %0,%%cr4": : "r" (val), "m" (__force_order)); + asm volatile("mov %0,%%cr4": : "r" (val) : "memory"); } #ifdef CONFIG_X86_64 -- 2.35.1