Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 20:44:02 -0600
From:   Bjorn Andersson <andersson@kernel.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Melody Olvera <quic_molvera@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Taniya Das <quic_tdas@quicinc.com>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] clk: qcom: Add QDU1000 and QRU1000 GCC support
Message-ID: <20230119024402.yfiekwp6grl3kn6q@builder.lan>
References: <20230112204446.30236-1-quic_molvera@quicinc.com>
 <20230112204446.30236-3-quic_molvera@quicinc.com>
 <8ecb84b5-93a5-691d-4a7d-5daed0e432e4@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8ecb84b5-93a5-691d-4a7d-5daed0e432e4@linaro.org>
Precedence: bulk

On Thu, Jan 12, 2023 at 11:15:57PM +0200, Dmitry Baryshkov wrote:
> On 12/01/2023 22:44, Melody Olvera wrote:
> > From: Taniya Das <quic_tdas@quicinc.com>
> > 
> > Add Global Clock Controller (GCC) support for QDU1000 and QRU1000 SoCs.
> > 
> > Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >   drivers/clk/qcom/Kconfig       |    8 +
> >   drivers/clk/qcom/Makefile      |    1 +
> >   drivers/clk/qcom/gcc-qdu1000.c | 2653 ++++++++++++++++++++++++++++++++
> >   3 files changed, 2662 insertions(+)
> >   create mode 100644 drivers/clk/qcom/gcc-qdu1000.c
> > 
> 
> [skipped the rest]
> 
> > +};
> > +
> > +static struct clk_regmap_mux gcc_pcie_0_pipe_clk_src = {
> > +	.reg = 0x9d064,
> > +	.shift = 0,
> > +	.width = 2,
> > +	.parent_map = gcc_parent_map_7,
> > +	.clkr = {
> > +		.hw.init = &(const struct clk_init_data) {
> > +			.name = "gcc_pcie_0_pipe_clk_src",
> > +			.parent_data = gcc_parent_data_7,
> > +			.num_parents = ARRAY_SIZE(gcc_parent_data_7),
> > +			.ops = &clk_regmap_mux_closest_ops,
> 
> I think this should use clk_regmap_phy_mux_ops.
> 

I believe so too. So I updated this as I applied the patch.

@Melody, please send a fix if bringing up PCIe shows this to be wrong.

Thanks,
Bjorn

> > +		},
> > +	},
> > +};
> > +--
> With best wishes
> Dmitry
>