Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp440880rwb; Wed, 18 Jan 2023 20:37:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXsABJq2A1vaik8WZ2TsOXV5TcbeyY2F/27Kk11oq3aWUEJwn85mFHEcPMdUQ6jJLjVjyEv4 X-Received: by 2002:a05:6a00:4207:b0:586:210b:2b67 with SMTP id cd7-20020a056a00420700b00586210b2b67mr11789694pfb.6.1674103073978; Wed, 18 Jan 2023 20:37:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674103073; cv=none; d=google.com; s=arc-20160816; b=qWlekn/ASw764N5yw/KHCU351qUxara3p+gXlq1ISotmC3vKJb3GatWO4O48CehHmZ 7h0UkN3v77cxhZyZrPLL7UHBATdGoAHoGdOz1I2R9q9DDmUGpRUZYK0lmR5iE7ZnJRJD KHntcd+FPKp9l4+qBmFuD1if102ni3w7Vlo/hzqSADm8K8qNWsqRzdN0ExXHg6e82W6J VQzvEzm/GA3QdS9zCrddu539Dtbvl6YIx0W+6hQtMx/eBY3x3pAqIkyItVCAIoJurOi5 F1/bsEikamKbrbbPRtrRWVvfJhnh7e4+M1+o2yL+D5wBb428pa61R+ub1Yeab9R3wW6S Ex5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RdzKr0SlWmRcbFq/uzCx+KAUppJQmuY3ANo9KF26kak=; b=z22zRoWbD0PHF1q0X2IagWJLfWDojOizKAAhfnd0oyVeKJoYvwk820/GtgnDlaj9xA 89bSd1Pi7jejs287E7njeb7TOimLfwfDRsrrcn8+LTfz0JLwUzf68GXfbja+EptxDp2x igP/UcVhml2QaVg2ErT3wfZeg8q7oHTD8wjlPzhxI2vxJvDvrw6ncx4Uamj+Pire++Vs s93n/oxKjX0C3RyZDUe3APRBIwsbgS53ayUxREKSyFenlGXUSU4yRsd7Wb9lB7NN7I5u ShJ6742tF+K1R++al3ys58jNxfnBn1z25+QhpI+7h06KOyxVCO/c6t1Xkg1Ecy1WbTTa QeAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="JAJmhT/I"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f5-20020a056a00228500b0058158371654si9351122pfe.368.2023.01.18.20.37.47; Wed, 18 Jan 2023 20:37:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="JAJmhT/I"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230448AbjASERI (ORCPT + 46 others); Wed, 18 Jan 2023 23:17:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230155AbjASEAC (ORCPT ); Wed, 18 Jan 2023 23:00:02 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EF55B37B45; Wed, 18 Jan 2023 19:57:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id ADAF6CE1FE3; Thu, 19 Jan 2023 03:44:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB1FCC433D2; Thu, 19 Jan 2023 03:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674099871; bh=bQlbGQrc9yJs59rSSNPWzyJ0ckGvabW8Cu5jr8y+/ZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JAJmhT/IYErYc/2eD4WDCv1guLTKHz0vsbdz7pYIWI0c/Y99CGOf2UDc3PZde9NAC yKBUDQNx6p7GxouNl757s7yNfdVkOn+DHDMt87gzwrw1WVyjzsrshqR7MymCoitlzc WYNGUa9GqM1IoxKs2Tx7gBPeMMzp2OG1ozToXegZqZR2hIF+VA/TUcI7fBC07zc6FJ parXx6BtV9ezFhgGxNesRBwJYxCrprl/f0irO1wbqnPnLGC+8Vlm9ytgn4suRU9kx4 TSE7WOYqwsRUNMn0CYeh/56U2xyMb1j3xmMcp2yUexTZbn4k97dq7vXUYRYW41BETb yPlN+fGtsJ6fw== From: Bjorn Andersson To: quic_sibis@quicinc.com, Manivannan Sadhasivam Cc: regressions@leemhuis.info, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, will@kernel.org, robin.murphy@arm.com, catalin.marinas@arm.com, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, sumit.semwal@linaro.org, amit.pundir@linaro.org, robh+dt@kernel.org, agross@kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: (subset) [PATCH V4 00/11] Fix XPU violation during modem metadata authentication Date: Wed, 18 Jan 2023 21:44:28 -0600 Message-Id: <167409986459.3039214.14669304455685242733.b4-ty@kernel.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230117085840.32356-1-quic_sibis@quicinc.com> References: <20230117085840.32356-1-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jan 2023 14:28:29 +0530, Sibi Sankar wrote: > The memory region allocated using dma_alloc_attr with no kernel mapping > attribute set would still be a part of the linear kernel map. Any access > to this region by the application processor after assigning it to the > remote Q6 will result in a XPU violation. Fix this by replacing the > dynamically allocated memory region with a no-map carveout and unmap the > modem metadata memory region before passing control to the remote Q6. > The addition of the carveout and memunmap is required only on SoCs that > mandate memory protection before transferring control to Q6, hence the > driver falls back to dynamic memory allocation in the absence of the > modem metadata carveout. > > [...] Applied, thanks! [01/11] dt-bindings: remoteproc: qcom,q6v5: Move MSM8996 to schema commit: bdea142295ffd76aaec2a90a36ba09ad19660686 [02/11] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Update memory region commit: 9b3024247b2ddea6880fa77b638c870ddbdb6bba [03/11] dt-bindings: remoteproc: qcom,sc7180-mss-pil: Update memory-region commit: 95864f27330674c970c84b81ae791182de150b0f [04/11] dt-bindings: remoteproc: qcom,sc7280-mss-pil: Update memory-region commit: eb48137d783b4c845c7b081e32a73666326dcbb3 [05/11] Revert "remoteproc: qcom_q6v5_mss: map/unmap metadata region before/after use" commit: a899d542b687c9b04ccbd9eefabc829ba5fef791 [06/11] remoteproc: qcom_q6v5_mss: Use a carveout to authenticate modem headers commit: 57f72170a2b2a362c35bb9407fc844eac5afdec1 Best regards, -- Bjorn Andersson