Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230117221858.734596-1-jmaxwell37@gmail.com> <20230118203849.7c00187a@kernel.org>
In-Reply-To: <20230118203849.7c00187a@kernel.org>
From:   Jonathan Maxwell <jmaxwell37@gmail.com>
Date:   Thu, 19 Jan 2023 15:42:14 +1100
Message-ID: <CAGHK07D2K7JajnzDGYV5sLeMVX1TDUtkTqLO62ib3h+GWrRWfA@mail.gmail.com>
Subject: Re: [net-next v2] ipv6: Document that max_size sysctl is depreciated
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        yoshfuji@linux-ipv6.org, dsahern@kernel.org, martin.lau@kernel.org,
        joel@joelfernandes.org, paulmck@kernel.org, eyal.birger@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        andrea.mayer@uniroma2.it
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 19, 2023 at 3:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 18 Jan 2023 09:18:58 +1100 Jon Maxwell wrote:
> > Subject: [net-next v2] ipv6: Document that max_size sysctl is depreciated
> >
> > v2: use correct commit syntax.
>
> change log under the --- lines
>
> > Document that max_size is depreciated due to:
> >
> > af6d10345ca7 ("ipv6: remove max_size check inline with ipv4")
>
>  ^ commit

Okay I'll add that.

>
> the word "commit" should be there before the hash
>
> > Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
> > ---
> >  Documentation/networking/ip-sysctl.rst | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> > index 7fbd060d6047..edf1fcd10c5c 100644
> > --- a/Documentation/networking/ip-sysctl.rst
> > +++ b/Documentation/networking/ip-sysctl.rst
> > @@ -156,6 +156,9 @@ route/max_size - INTEGER
> >       From linux kernel 3.6 onwards, this is deprecated for ipv4
> >       as route cache is no longer used.
> >
> > +     From linux kernel 6.2 onwards, this is deprecated for ipv6
>
> 6.2 or 6.3? 6.2 is what's currently in Linus's tree, net-next
> is 6.3 and the commit in the commit msg is in net-next only.
>

I'll change this to 6.3.

Regards

Jon

> > +     as garbage collection manages cached route entries.