Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <883d1df3-a7d8-45bf-a4a1-91352f958f1a@amd.com>
Date:   Thu, 19 Jan 2023 10:47:34 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v11 02/11] Documentation: amd-pstate: add EPP profiles
 introduction
Content-Language: en-US
To:     Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
        Mario.Limonciello@amd.com, ray.huang@amd.com,
        viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230118075210.447418-1-perry.yuan@amd.com>
 <20230118075210.447418-3-perry.yuan@amd.com>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <20230118075210.447418-3-perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnRRVU5VQzhBMHAwRTdndGJDWmR2QzVYc2NDZWpMTy9kT3Zpb2JZU3hSQ3lz?=
 =?utf-8?B?YXFTTDk1ZVU5Yjc4cm1VMzdXeFBUNDl4OGx1QndBVDZ4NUlxOWFUbjlWM0Mw?=
 =?utf-8?B?a01vZzdselh3RUtmcU16M1V0N3NmTVBPbnBmU2NoL29NOEZXb21TazByb0sw?=
 =?utf-8?B?dHRUSmxDQ1VwbVlnYlh2TUpvb0YvcklOdGV3SHZic25lRkdSZU1DaXhUSGZs?=
 =?utf-8?B?cE9qaVNOS1hJbVo4eFVSRWVOdVFkK0N5aW43dWFjb2FINDlQTHJCeEE3dCtR?=
 =?utf-8?B?YmxlTnkrZmRWTGpzWjc3TktqdjcvbzBnRE5vdHUvSWNnaXlCUnplejJDYXZn?=
 =?utf-8?B?RS8ydUNQdStQdnZKdVV6RGp1VldRbzZlWDBUbHRka29kQjMzNnhyNjRWK05x?=
 =?utf-8?B?VmhiNUxRUjNWZU9jUWN6d1hKZVFNZ0U0TjN1cU5SSTRhb2ZPS2JsZXV4cHdF?=
 =?utf-8?B?WnpHUnluWlhydldHend6eFdFd1JFanNYcTNUK2ZYK2laVGc2emJEY0dxeW42?=
 =?utf-8?B?VFRKdk5LU3JHTHZwS1V6S3d0TEREZExBUVl5SEVadGRNeVFBTWFBVUZ1VHBK?=
 =?utf-8?B?SjFCSlBXblFGOUZRMEdxeCtFTGhFa0FwZzNLMWFMRk9UMjdDdDh2bi9ybEpL?=
 =?utf-8?B?N3BQUjhZclhoaDJrV0xUZmluTlRiUmFWK0ZEL3pWMWIwTkdweGpDZ2N2TG1M?=
 =?utf-8?B?azBmTTczMTl0eGdJMnFNdHV0b09RWU55Nmd5UUJmbVBQbmk5TnJMdHRwWHRY?=
 =?utf-8?B?TXpSR0FUOUdaMm1sK0xIN1c1dllhN3RldlVZRUUwTTUvY1JWUC9kTXQycHdY?=
 =?utf-8?B?MnJ4WjlWNnpSN2o0MDdIME9GVHU0S0o1UTliMGlDbDVlVDd3ZXl4cTdLWXZj?=
 =?utf-8?B?VTkxNzFWOTBVWXltOEg2aFN2WHFRcFNXcU5UcTJRVSt1dWJENU1JNFN4Qjk4?=
 =?utf-8?B?RHVUWDhMREtVSVVHMVBnZytEa2JDaVplT2ZPN0JNbzgzcVFQUmNVa1IzT1Zl?=
 =?utf-8?B?L29yZEVQTkNWM1l1VFBrMFVLWEFVR29OT3lpeWZMS2VPSjFsRkkxOGk5RTRp?=
 =?utf-8?B?ajlnczdTV21EalBRaytwWnlUSVR5UXordno3NGdZc2lKV1JKVER3MWlhRGpM?=
 =?utf-8?B?NE52bkVEaEtDUlhjekwycWtacng4QVQxUFdReWtJTk5oSHl3UFZhUkVNaXdt?=
 =?utf-8?B?bmdwdHoyNzRWV2F3a3dIYzJOOWFZZEtMQzlqMkY3bVRPVFR3d2xTTldUTUtD?=
 =?utf-8?B?SUdsOU5rWnptSnovOERXOFBKVmNET2lPLzBEOGlEcDQwZmRLdFo2eSszZXZT?=
 =?utf-8?B?cHVUMEREbXZ6N1lzOUVtS0NvZTNySGc2QXZXUzJrMTNZaGw3eTNQaDBDRFN2?=
 =?utf-8?B?VHVWa1o0Q2NLZE5mOTlXSWJxTmlxS0NNV1FQNmsrQlJxV0FNSCtOaVJMT1lQ?=
 =?utf-8?B?czFaV2hpaWwzbGV1VlM5K0Y2dGgzQjRxQ3ZMdWVSTWFpaklNNzdoV1hPTHdJ?=
 =?utf-8?B?dmNqYWtUR2dPRG9aeVpYaFJINFRxWkZOeG5DZzNyK1ZIejR6YWdzY0J6ck8z?=
 =?utf-8?B?Sk1DY1RuUHY3QmZ6a0lqL0lvRnlxYlp6eFBhLzR3bWh2WVNBbjc2S2tSOFV4?=
 =?utf-8?B?RHJVUnUwbUhxSmo5VGd5WEVTWmZQcFlkZlRiUHhJTmtvYVdBYUhFc0NuZXVs?=
 =?utf-8?B?b1ZMOG9oWGFTN1RFSGozTFRtelNCRi96RTlTSTBISEtYMkN6VTdITXpHNXkx?=
 =?utf-8?B?QW9RTVBpdmxhQkRrSEtpYUQ4NXN2WlRYTjd6M2VnVEdza3JYT0N2M0h6dGY2?=
 =?utf-8?B?cjdVQkYzcXNSeUlpTkVYWWFZVGVzZnpRSFcveUJJTnYzSHhxM2dBazFkWEtP?=
 =?utf-8?B?Z3pjaGRXZDY0ZFl5enVxSFFpL3lnSHRHTytINDBvVDdlN2dHQTh5bjNWMDRk?=
 =?utf-8?B?eGl0MHd4TXRBQnFkbTBIWEIxcUI1YVhhMm9kcEJNY252TWdaU0Q2Y0NocTF4?=
 =?utf-8?B?TmpxbTc2QTFZa2Rnd0dHN3NRR1JBZ0NtS05JZHFScDg0OTAxL2h1MUhOS3Y4?=
 =?utf-8?B?ZGR0T1JxUnp4WjZSa1M5SlJlaHY2Ulp1TVg1cFN2MEgwbnpFcmU3OVVEN3lY?=
 =?utf-8?Q?FzMwIlcL9QWzz7AFzZFfHub1G?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5602d52-52e1-47aa-f9b3-08daf9dc807d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 05:17:47.2394
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 54m9jR8jMwj4/uCYM7scmdev28kUuMU0ZgD+++gyU2S/2EWmzFnijJuHWCFpQu3bMzHwuMGqK8IaEg25pTTMAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6321
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/18/2023 1:22 PM, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> The amd-pstate driver supports a feature called energy performance
> preference (EPP). Add information to the documentation to explain
> how users can interact with the sysfs files for this feature.
> 
> 1) See all EPP profiles
> $ sudo cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_available_preferences
> default performance balance_performance balance_power power
> 
> 2) Check current EPP profile
> $ sudo cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference
> performance
> 
> 3) Set new EPP profile
> $ sudo bash -c "echo power > /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference"
> 
> Acked-by: Huang Rui <ray.huang@amd.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Tested-by: Wyes Karny <wyes.karny@amd.com>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
Reviewed-by: Wyes Karny <wyes.karny@amd.com>

> ---
>  Documentation/admin-guide/pm/amd-pstate.rst | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 5376d53faaa8..98a2bb44f80c 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -262,6 +262,25 @@ lowest non-linear performance in `AMD CPPC Performance Capability
>  <perf_cap_>`_.)
>  This attribute is read-only.
>  
> +``energy_performance_available_preferences``
> +
> +A list of all the supported EPP preferences that could be used for
> +``energy_performance_preference`` on this system.
> +These profiles represent different hints that are provided
> +to the low-level firmware about the user's desired energy vs efficiency
> +tradeoff.  ``default`` represents the epp value is set by platform
> +firmware. This attribute is read-only.
> +
> +``energy_performance_preference``
> +
> +The current energy performance preference can be read from this attribute.
> +and user can change current preference according to energy or performance needs
> +Please get all support profiles list from
> +``energy_performance_available_preferences`` attribute, all the profiles are
> +integer values defined between 0 to 255 when EPP feature is enabled by platform
> +firmware, if EPP feature is disabled, driver will ignore the written value
> +This attribute is read-write.
> +
>  Other performance and frequency values can be read back from
>  ``/sys/devices/system/cpu/cpuX/acpi_cppc/``, see :ref:`cppc_sysfs`.
>  

-- 
Thanks & Regards,
Wyes