Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <59daf0e1-8148-7f5b-e1df-58c000b3a098@amd.com>
Date:   Thu, 19 Jan 2023 11:01:01 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v11 06/11] cpufreq: amd-pstate: implement suspend and
 resume callbacks
Content-Language: en-US
To:     Perry Yuan <perry.yuan@amd.com>
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com,
        Mario.Limonciello@amd.com, viresh.kumar@linaro.org,
        ray.huang@amd.com
References: <20230118075210.447418-1-perry.yuan@amd.com>
 <20230118075210.447418-7-perry.yuan@amd.com>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <20230118075210.447418-7-perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alp0ak9VN2pRdkk3MWtmVHhvYnpwVHRTNFdIYmFsWEZ3bkxsKyt6UEd1Rml6?=
 =?utf-8?B?RVMzaE5GOTZIZ2JqeFJlWEo0ZDdWZVNiN1lxdlBqbms4aTM0TUEzSFVXYXNr?=
 =?utf-8?B?U0RPMFMzVWdScXEwelprRjJVVE51c00zRmozay9iQVoxajJZOUdtSUNtR0JN?=
 =?utf-8?B?M214aGYxR2tGS1NOU3ZYOXNiU1U1OGZzRFF3R0NCUVJFTUg2UjNTU3Qzb21G?=
 =?utf-8?B?SnJZTFpKQ1E0blVGelR6emkrK1E5Wnc0VVNXSDJEdEdKUWNtZnZsd2tEZXVa?=
 =?utf-8?B?aDJCTTI0UnVTejV4RFdpMGtiV3BXRko0endlMkRJd3pNWTdWUGFhY1FxVnJV?=
 =?utf-8?B?dnlweEJNak1JWjNKejVhaTBUdXZTa3FubWVwRzdFa0FhNThZRDFyN0hZeDhj?=
 =?utf-8?B?QXUvWGdqU3dza2F1Um9kcnB6T2JuaERUWDdBRXJlRnFGMmJPNGl3bFNGUjRa?=
 =?utf-8?B?ZWZGQ0RMYzl6eGlyYnRxWStCanJ4amM0T1FhUVE4eHB3UVZRWkpFRm9YMC9B?=
 =?utf-8?B?Q041NytRV3c1THZnSEpPR2J0UHJtTmVPdEpod1BqM3Fyc1pwUy9FSUhlRnVv?=
 =?utf-8?B?VFFYWlFMaEhtcFVwWHRZZythUk5JdUNtMjNPMjV6bEFyVE5iNmZYMTRmeUpv?=
 =?utf-8?B?UlN5YkdDZFQ3enN5a3oyWXU2aWxVTW1scUQvWndNVDdFTUVhRzJIcG9EL01G?=
 =?utf-8?B?VkNIK3B2Y21DcERFYlpKcTBMcklVMFlrODJkRUU0Nzk2ZUVUcFZCSG9LYm1B?=
 =?utf-8?B?YXpvTzNHUUFCODZwV1RHOWY5TjBVWDRGV3o0dytDM25kWlJ1QzgzbmJUUzJr?=
 =?utf-8?B?b1RrK1EyNlBqZnFJbzFwaG5zcVhPTEhrNVZESEFNZWIzSXVlRlBNbjVGanVq?=
 =?utf-8?B?YW1BbjVFMHRlSlhIakM2Tm5jZkVXTlJDeXhsSEZmNCsvSUZqSTlJNjlYTm9o?=
 =?utf-8?B?cGhMcnUrUXQzU3lRY2NSYlN5SFR1ZnVHWldFdjVpZmpRNkY1L3Yxb2tibU94?=
 =?utf-8?B?cEZkRnFuNVppTmlDK3prZXlubWd0MTFkcTdHTHg0TWsxNW5lOUdJcnh1SEtK?=
 =?utf-8?B?U1RscmxBcWZRb3FDWVRwK2F4YUZvZ0pHL3AwNkM1NHR3NTlPcU0wM0o1Rits?=
 =?utf-8?B?NVR4UkVVbEVnanFBVDFrQXBBVWRlNmZJSE9YTXpEendSTFRaNndtZ2xtTndE?=
 =?utf-8?B?MGp6MDY3RW1nUzJNUFloN05URFk2aW13SENnMjk4dFJqWDZDQXlzUVFodUZR?=
 =?utf-8?B?a1lCNU9OU2NEUWhaMFJiMWkxcWloVVpXdlUvU3JjdkNZK21DakxuYWQxTXpM?=
 =?utf-8?B?MW5Jd2dvT1N3eXg4b2ZiOEp0VWNvWFZObFBrcWFESXAxQVFjRWZwVUh1OTJL?=
 =?utf-8?B?SUJSK1IvQTltaFE3TXNVakVNYjBTVXhkVFg4N3doWlBpcjAzTG14MFJTaW91?=
 =?utf-8?B?Z3dHcFBlMTBlTFI0WEVkb3hOdzcyaWcyRmVacWQ0Z1FRZVRnTXczVU1rU2d5?=
 =?utf-8?B?VjRGZms5M0dMNXhBVUlqcVpQL0toNjV1NlZJWmVMZjg4cGkydlNQVnkraE9m?=
 =?utf-8?B?V1F4YjdtRG1SUlVMT0xoRjN6a1hzVVUrZ2JmTzZIQU43MGEyV3ZISkp5Vkxv?=
 =?utf-8?B?elRNN0xNL3pUbzAwMnZhQmJSR3BldG1JWHpmZ0dsNjdtVUhSNVhhOVF4ZW1w?=
 =?utf-8?B?aWxkNGF0QnNtMWc4SjRDZjVzb1FURktzdGhYd25DVThQTG92dXp4U3FLVkd4?=
 =?utf-8?B?aEFRUnZwQ3FEQ3dnbnVrUFo1bURHSzFSU1UxRk0zelRHZ1NDbmF1YXJjYmtO?=
 =?utf-8?B?ai8rOFVZY25EeWNNdGVBWnlGZDB3bUUvVnJqMHlKbzF4SDBUR3BNY25BZWNJ?=
 =?utf-8?B?eURTTGdyclJlZzc2ODU0UWl1UFZ4ZUdxRlMrU0ZDaFRxc3ArSWpiTTBwWHdh?=
 =?utf-8?B?RWpVRG0xeFVpL3dSOFBrclp2WFNOa0U3RXV2c0dIVDQxa1FmZWovQUhKSEJ4?=
 =?utf-8?B?eHJNbngzR0FVMWdRVEJRc09BY2U1QnEwUU96OFIyTXFvOEJrdGRJSnFrdzMr?=
 =?utf-8?B?TU9XUkpUWi9ITm9SazJKQkt0a0tZYkhjeXp6bCtHL0MyVFBHeW42UlJSZVNt?=
 =?utf-8?Q?KdtSZyade4mz2tm+f47PDCZSv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6bef62f-7d3a-4ad8-421e-08daf9de6190
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 05:31:33.7639
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EzvMfyy59cp4o6exQMigQs8D8Rl1JE32Gk9hpS3eKFQUDdxRXVxoQRQ0zCRHSKLPPiN205X8lDRp2hE2DGv7sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5758
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/18/2023 1:22 PM, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> add suspend and resume support for the AMD processors by amd_pstate_epp
> driver instance.
> 
> When the CPPC is suspended, EPP driver will set EPP profile to 'power'
> profile and set max/min perf to lowest perf value.
> When resume happens, it will restore the MSR registers with
> previous cached value.
> 
> Acked-by: Huang Rui <ray.huang@amd.com>
> Tested-by: Wyes Karny <wyes.karny@amd.com>
> Reviewed-by: Mario Limonciello <Mario.Limonciello@amd.com>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Reviewed-by: <wyes.karny@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 40 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 1472a6382b29..9e1bee060597 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1045,6 +1045,44 @@ static int amd_pstate_epp_verify_policy(struct cpufreq_policy_data *policy)
>  	return 0;
>  }
>  
> +static int amd_pstate_epp_suspend(struct cpufreq_policy *policy)
> +{
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +	int ret;
> +
> +	/* avoid suspending when EPP is not enabled */
> +	if (cppc_state != AMD_PSTATE_ACTIVE)
> +		return 0;
> +
> +	/* set this flag to avoid setting core offline*/
> +	cpudata->suspended = true;
> +
> +	/* disable CPPC in lowlevel firmware */
> +	ret = amd_pstate_enable(false);
> +	if (ret)
> +		pr_err("failed to suspend, return %d\n", ret);
> +
> +	return 0;
> +}
> +
> +static int amd_pstate_epp_resume(struct cpufreq_policy *policy)
> +{
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +
> +	if (cpudata->suspended) {
> +		mutex_lock(&amd_pstate_limits_lock);
> +
> +		/* enable amd pstate from suspend state*/
> +		amd_pstate_epp_reenable(cpudata);
> +
> +		mutex_unlock(&amd_pstate_limits_lock);
> +
> +		cpudata->suspended = false;
> +	}
> +
> +	return 0;
> +}
> +
>  static struct cpufreq_driver amd_pstate_driver = {
>  	.flags		= CPUFREQ_CONST_LOOPS | CPUFREQ_NEED_UPDATE_LIMITS,
>  	.verify		= amd_pstate_verify,
> @@ -1066,6 +1104,8 @@ static struct cpufreq_driver amd_pstate_epp_driver = {
>  	.exit		= amd_pstate_epp_cpu_exit,
>  	.offline	= amd_pstate_epp_cpu_offline,
>  	.online		= amd_pstate_epp_cpu_online,
> +	.suspend	= amd_pstate_epp_suspend,
> +	.resume		= amd_pstate_epp_resume,
>  	.name		= "amd_pstate_epp",
>  	.attr		= amd_pstate_epp_attr,
>  };

-- 
Thanks & Regards,
Wyes