Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4e2675b7-6d6f-7d24-1b78-400431723ecc@amd.com>
Date:   Thu, 19 Jan 2023 11:03:20 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v11 10/11] cpufreq: amd-pstate: convert sprintf with
 sysfs_emit()
Content-Language: en-US
To:     Perry Yuan <perry.yuan@amd.com>
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com,
        Mario.Limonciello@amd.com, viresh.kumar@linaro.org,
        ray.huang@amd.com
References: <20230118075210.447418-1-perry.yuan@amd.com>
 <20230118075210.447418-11-perry.yuan@amd.com>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <20230118075210.447418-11-perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDRuVkZTenZxcmFVYTYwRlU2Q3dkUDZ1K2RmaFUydzFnSmozSHdHbnRRdU1Y?=
 =?utf-8?B?R2krQ1hLSmEvRzRjdFFrSk1qREN3SUdISGxlNFVsTnhBdlpzd0c0RFB5dHI4?=
 =?utf-8?B?RkpzU0wzSXRnWXdGS3lZUnVqSXZibmZhV2lSUlBhbUhqUzR0RTNRTS9iOWpE?=
 =?utf-8?B?L2VOc3o1MjhJanIzTWxKL0t1cnU1VUtIckV6VC9ycHQ1a3NmOFNiaW5HNmd4?=
 =?utf-8?B?dW5PMkQ4RGZxQkxUdnRnYkVwQW1YdW53K3hSMlF1eGZnaEZTaEE1aEVCWXlo?=
 =?utf-8?B?RE5ma3dQdFBNUHFueHExV2wycW1tYkRTQ1JLWWpXT2JZVUlDMitCbWZwa1VG?=
 =?utf-8?B?MFNTcUZ5R2JXVTErMktCZUgybnc0cTRES0I5OWYzTmtFTXQvZEZvZGRsZDMx?=
 =?utf-8?B?T3k5Ri96eG5OV05CNzRBRmZTQnBXMFFOTXNFSVRSdWd6WHpXSE1WMTRSakdK?=
 =?utf-8?B?bGhWQ1FzQzlTcUJrYi9USlBObVlzVVpxMXUxUXdyODV1cW1HU054Umx1MDZ0?=
 =?utf-8?B?T0FxekQvUk1iZm9mQ3FDMzR1NFlUanhBS0ZyQk11S2RCWEVDREU5Q0oxc0lj?=
 =?utf-8?B?WWljcVEyVCtJMitncUNZVXc3aCs4NC9JNnBBTFZEd2VWSW5lWm11QzA1MWVH?=
 =?utf-8?B?REFZeG55QWFTR0o5Umx2V0hwWHI4dGJ0WUVaeG9vM2owV3NuYnpJVXlXZlJk?=
 =?utf-8?B?V0RJYUp3VjYzYVFNdHBnTldScklwQ1g3M0N6VkxERVU4UWhaSFNTSGhXcStz?=
 =?utf-8?B?T0VHZG8wSXVYSjNLYlczS0hkcm5VWDFDaUZkWllxUzdPd1FEd1FLQXJSbi9F?=
 =?utf-8?B?dmEyb3RaTlJZMWhWNDkxbUJMRXJ2dlRicEFINW01NU51b0o4MUtJOVR4QS8v?=
 =?utf-8?B?TzF5YXB0NzhsNHExVW5DcEorOWZ0RGNRREZZZ1Z3ZWExU0IvSE1QRzQ3Qml0?=
 =?utf-8?B?cmlUcmF3TDlIQlhFSUg4aFdhZm11eEJKTW9NRlpOYjhNdU9aenZ1RVN1di9V?=
 =?utf-8?B?YnJHVWFsY25KWU4wcHlHeDZtbnR0NFp3VUxvVE9NTkp2aE9iTS9vT0FtNnhT?=
 =?utf-8?B?NkVMcDRRV3pCWUR6eFpPWmZjTm1IMzlDYXVRWGhpVER4YVcvdGxBR1dyekNs?=
 =?utf-8?B?RjEvUmhEbTJyUE1wOVNWVGpVcU9xcGhYL0JST1F5WC9FamRFVU1QQWJ0dWpN?=
 =?utf-8?B?NVJYc3kwZHpQZUJBRlpLamJPWDlTWk1RUTVDMkxjRStKM2R6ajE1OWxjcGlY?=
 =?utf-8?B?a1ltWGNiUUc4WkMwaXdCU3BFL1gxWUNINFlqb0pGbDRudDdOSzFraFhZMTRs?=
 =?utf-8?B?cDJoZG8rWGVLOFZ1Rml4K0dic0U3M0x5WVlYekV3RmFOMkowblBuRWN3MW82?=
 =?utf-8?B?QzV3TDgwR0dmamZ5bDNBSFVGVDg3amFLdUFiVzFOdUExVmF0RkFLajlTT3hw?=
 =?utf-8?B?dlVTa2RqaWgzNzlueWhkaUNaeWZiVzY4dVlwNlVOaEQ5OFhzTnVPUmhBeWpN?=
 =?utf-8?B?ZFdTSzNobXdndHNPMEdPWjNpc2wyOUxURzBMRk4yTXQrZWdoYUtsVW1Ea3RU?=
 =?utf-8?B?NmhxOHh1RUJCczNFWld2MEFUbzZwZXB4cTVsSytVZ3NFQjEyZmFZQy9Yd3FS?=
 =?utf-8?B?TXlSamhZelhnTlpRUDB2bWlDb1ZOZkRJUnhsRGhSMXJkTmF0dE8rWWJNTUlo?=
 =?utf-8?B?R1N3RlZ2RXlqV2llTnVVbXU1ZEE2WW5SLzRHTTF3NUFLc2QzYTRyelF5eXQv?=
 =?utf-8?B?N1NTS055aEJDTUVqYzFoYzQ0enBVOVBBZVFpcmlKWXgrYjhQQ0JITy92OEdG?=
 =?utf-8?B?Z2lUSlhFTlZUekRVYmh4QVJyTHdNWGloQ1pRYi93VFA1T3NXWDFjOTl1MGMy?=
 =?utf-8?B?aldGRlJiUXdHOWZ0WnVhN3ZHdkhQVEQxVXhodXVQaEJibzE3ME1JVmdKdHFq?=
 =?utf-8?B?T05EQnMyaUtWd0wwZ3J2WFZLLzlyR1YxL2t4dXVUT0FRZnFOYVJ1cDIvWUx2?=
 =?utf-8?B?YlM0bnlWTnhROXpZUW9FKzdlM0pqbzVvSGt2VTNjUDJ1bWxNaWh3eW1PeUds?=
 =?utf-8?B?UHJJWE85cmNlNHJabXNQN1FJYytqWUpTYzE3TkhVQW1xSWdjcHJUME1jME9E?=
 =?utf-8?Q?SIlkxSlI7G/rb3DyHGp/vNkHV?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 872dbe6d-1edb-4c0a-0aa5-08daf9deb45f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 05:33:33.4279
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O7164yYqXg7QvAY9JmAoklS/5yV8LAiOpr7Ti7rt8Wx7bhj4vlbhe10rbbLmr7hiska5uErBI5TPcV4VaDWamw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5758
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/18/2023 1:22 PM, Perry Yuan wrote:
> replace the sprintf with a more generic sysfs_emit function
> 
> No intended potential function impact
> 
> Acked-by: Huang Rui <ray.huang@amd.com>
> Tested-by: Wyes Karny <wyes.karny@amd.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
Reviewed-by: Wyes Karny <wyes.karny@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 2e5e594dc41e..c307d67a76ae 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -694,7 +694,7 @@ static ssize_t show_amd_pstate_max_freq(struct cpufreq_policy *policy,
>  	if (max_freq < 0)
>  		return max_freq;
>  
> -	return sprintf(&buf[0], "%u\n", max_freq);
> +	return sysfs_emit(buf, "%u\n", max_freq);
>  }
>  
>  static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *policy,
> @@ -707,7 +707,7 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli
>  	if (freq < 0)
>  		return freq;
>  
> -	return sprintf(&buf[0], "%u\n", freq);
> +	return sysfs_emit(buf, "%u\n", freq);
>  }
>  
>  /*
> @@ -722,7 +722,7 @@ static ssize_t show_amd_pstate_highest_perf(struct cpufreq_policy *policy,
>  
>  	perf = READ_ONCE(cpudata->highest_perf);
>  
> -	return sprintf(&buf[0], "%u\n", perf);
> +	return sysfs_emit(buf, "%u\n", perf);
>  }
>  
>  static ssize_t show_energy_performance_available_preferences(

-- 
Thanks & Regards,
Wyes