Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp528711rwb; Wed, 18 Jan 2023 22:16:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXuq0Brt1xZ5xpUXYWJtL5d0aq7zSPV95v54+n0cj4Bfaqc9+C7lT0bRXBgR0Tmi9paNfySu X-Received: by 2002:a17:902:e54b:b0:194:7efa:702f with SMTP id n11-20020a170902e54b00b001947efa702fmr13876565plf.53.1674109009517; Wed, 18 Jan 2023 22:16:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674109009; cv=none; d=google.com; s=arc-20160816; b=wDac+RWp+GL0dJ2rGIvaG5mAfEwQAyXL5aMyL6kkBU+i2RC5UXGf/XFKzyrd8SlNyk 1ShYPsgtCTLa3EP4xvAp5j+lugiB6SurDiXpZ/mOIxWcIxtaRxB8ZZKgpcUU7GNo9hpm rAIdxr4lslZBkEXj08njwvULdKLE0BSJJurOuFL8GAf99BfcDoqQEqrJBVymSbF7BA8d /ISGUFu0R7bB6oqAsE3dDyWOPVoduvwxFKcMTCaUkUiRJhZEjJhgJbVxspN8HBWS0Dod bau40ww9DkVyo25HlblHG1fbH0J9aBPm3vXDKwD5d9R8DmS6wFLMZGnvIt3L6e6+lFMy OPUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=y6/Fa2kMecOK/lB+bl33NmUdoAvTaziXy0CYW3YUNlI=; b=Bq37ZrSuLlrEWhhYz+cRUICy5x4qYqFanHL9x/V2NTL+lQOZPqNZu7IFovqL3j0lXx ABhVmAXuZwZ+fkz6zrFlxDpEUVW+duUsSqSWvZEvkuA9TxCQpSOCbQDUXqSr3X0r5WpR qU0++9iD9PQbSWh4XJJvB9I2gCRbaZvxvxjsFrXl9EArn4uyYKmurd2mgEYBLF8ZzPo9 epdUZGVPOsSRajA3+hll6KzYcu00Omy1NVybWY54qGms05u9EyLVl4JIhxEbL0dQre3c kZkXGQf0l4UD6G3Juo/NPv6gmd83pfLIGJiC3cynhCGK22aeOfye3waSEeCrzxBskSQQ MttQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bm18-20020a656e92000000b00476e98ca7d5si36792333pgb.785.2023.01.18.22.16.38; Wed, 18 Jan 2023 22:16:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229724AbjASFfx (ORCPT + 43 others); Thu, 19 Jan 2023 00:35:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjASFfu (ORCPT ); Thu, 19 Jan 2023 00:35:50 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBB38E9; Wed, 18 Jan 2023 21:35:49 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 208ED67373; Thu, 19 Jan 2023 06:35:46 +0100 (CET) Date: Thu, 19 Jan 2023 06:35:45 +0100 From: Christoph Hellwig To: Song Liu Cc: Christoph Hellwig , Thomas Gleixner , Luis Chamberlain , Christophe Leroy , songliubraving@fb.com, Peter Zijlstra , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH/RFC] module: replace module_layout with module_memory Message-ID: <20230119053545.GA16775@lst.de> References: <20230106220959.3398792-1-song@kernel.org> <20230118074047.GA27385@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2023 at 01:52:51PM -0800, Song Liu wrote: > In this way we can use the array in the for loops, and use mod->core_text, > etc. when we only need to access one of them. Just use the array please instead of making it too ugly. If that is the only sensible way to iterate we have a good argument for the array and can live with it.