Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230112095848.1464404-1-guoren@kernel.org> <20230112095848.1464404-5-guoren@kernel.org>
 <Y8EjAt3DC4WC062n@wendy>
In-Reply-To: <Y8EjAt3DC4WC062n@wendy>
From:   Guo Ren <guoren@kernel.org>
Date:   Thu, 19 Jan 2023 13:46:20 +0800
Message-ID: <CAJF2gTTXtkCnv4vHXS1H=L=gbbVd1wyijteq7WjgC4KiSPuHfw@mail.gmail.com>
Subject: Re: [PATCH -next V14 4/7] riscv: entry: Convert to generic entry
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de,
        peterz@infradead.org, luto@kernel.org, heiko@sntech.de,
        jszhang@kernel.org, lazyparser@gmail.com, falcon@tinylab.org,
        chenhuacai@kernel.org, apatel@ventanamicro.com,
        atishp@atishpatra.org, mark.rutland@arm.com, ben@decadent.org.uk,
        bjorn@kernel.org, linux-arch@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        Guo Ren <guoren@linux.alibaba.com>,
        =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@rivosinc.com>,
        Yipeng Zou <zouyipeng@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thx, I got that:

  LD      vmlinux
riscv64-unknown-linux-gnu-ld: arch/riscv/kernel/traps.o: in function
`do_trap_ecall_u':
/home/guoren/source/kernel/linux/arch/riscv/kernel/traps.c:245:
undefined reference to `handle_page_fault'
make[2]: *** [/home/guoren/source/kernel/linux/scripts/Makefile.vmlinux:34:
vmlinux] Error 1
make[1]: *** [/home/guoren/source/kernel/linux/Makefile:1252: vmlinux] Erro=
r 2
make[1]: Leaving directory '/home/guoren/source/kernel/build-nommu'
make: *** [Makefile:242: __sub-make] Error 2

Sorry.

And here is the fixup:

diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
index 0b764071de8c..69d619ddbcd5 100644
--- a/arch/riscv/kernel/traps.c
+++ b/arch/riscv/kernel/traps.c
@@ -268,6 +268,7 @@ asmlinkage __visible __trap_section void
do_trap_ecall_u(struct pt_regs *regs)

 }

+#ifdef CONFIG_MMU
 asmlinkage __visible noinstr void do_page_fault(struct pt_regs *regs)
 {
        irqentry_state_t state =3D irqentry_enter(regs);
@@ -278,6 +279,7 @@ asmlinkage __visible noinstr void
do_page_fault(struct pt_regs *regs)

        irqentry_exit(regs, state);
 }
+#endif

 asmlinkage __visible noinstr void do_irq(struct pt_regs *regs)
 {

On Fri, Jan 13, 2023 at 5:23 PM Conor Dooley <conor.dooley@microchip.com> w=
rote:
>
> Hey Guo Ren,
>
> On Thu, Jan 12, 2023 at 04:58:45AM -0500, guoren@kernel.org wrote:
> > From: Guo Ren <guoren@linux.alibaba.com>
> >
> > This patch converts riscv to use the generic entry infrastructure from
> > kernel/entry/*. The generic entry makes maintainers' work easier and
> > codes more elegant. Here are the changes:
> >
> >  - More clear entry.S with handle_exception and ret_from_exception
> >  - Get rid of complex custom signal implementation
> >  - Move syscall procedure from assembly to C, which is much more
> >    readable.
> >  - Connect ret_from_fork & ret_from_kernel_thread to generic entry.
> >  - Wrap with irqentry_enter/exit and syscall_enter/exit_from_user_mode
> >  - Use the standard preemption code instead of custom
> >
> > Suggested-by: Huacai Chen <chenhuacai@kernel.org>
> > Reviewed-by: Bj=C3=B6rn T=C3=B6pel <bjorn@rivosinc.com>
> > Tested-by: Yipeng Zou <zouyipeng@huawei.com>
> > Tested-by: Jisheng Zhang <jszhang@kernel.org>
> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > Signed-off-by: Guo Ren <guoren@kernel.org>
> > Cc: Ben Hutchings <ben@decadent.org.uk>
>
> Unfortunately from this patch onwards, the !MMU build is broken.
> Should be able to reproduce it with nommu_virt_defconfig.
>
> Thanks,
> Conor.
>


--=20
Best Regards
 Guo Ren