Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e69b28cb-4053-4c62-ace4-bf72062dd252@siemens.com>
Date:   Thu, 19 Jan 2023 07:34:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 3/3] arm64: dts: ti: iot2050: Add support for M.2 variant
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Bao Cheng Su <baocheng.su@siemens.com>,
        Chao Zeng <chao.zeng@siemens.com>
References: <cover.1674059300.git.jan.kiszka@siemens.com>
 <fe57b923d3f290dceea4f54724459015a7bad899.1674059300.git.jan.kiszka@siemens.com>
 <cc820b4b-d3b7-9972-a07f-0c9f94f8d175@linaro.org>
From:   Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <cc820b4b-d3b7-9972-a07f-0c9f94f8d175@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mm1JSFZiOWV2QlZwSG93R2taSlJCREE0aDRiUDFQREgvSktyNXgwb0xTVXlw?=
 =?utf-8?B?TytWa3Vjcm04cEk5Kys5SHo1YnpValNzZVJ4UkRSeXVneGtlV2NTcEVWL24w?=
 =?utf-8?B?aXlXTFRpckd6MlFCa2ZIZ2V6SlBFRFJJaHptZ3lFQ3RKcUR2Z0Y0YmNNNnBm?=
 =?utf-8?B?OGhRZ28rcVIwdTNPZ1hKQm5ha2FLWnVNeS9KbjVLSVZTQnZMRDJZbU1Zd2Qy?=
 =?utf-8?B?ZERYUEdxVjNQWXJ3MzZEbEoxVUJhMlJNSzBoZ2lDbjZTbzhHN2R5dzEyZGY0?=
 =?utf-8?B?VXVuYWtaTm9DQU5PWjRtZXBJV0tiKzFGNFhDMExzT002SzNCMTlXOGhOUzZq?=
 =?utf-8?B?eXNkMjhLTVdJdU9iajNaZkdYRE50ejlCRTl6TzJGOUFwQXBCb3pWYmFoVkcx?=
 =?utf-8?B?dW1NVE8rNFgzQ2dneDJoYXdzU2FOSC9VUXBieEtTN0VZVHF5WkNJY2M5Y3FM?=
 =?utf-8?B?Y291RERDWSs3bFVwNW80ZWgzU09DUnpyemtKaS90RlFodGgvWEdVSE9KTHRU?=
 =?utf-8?B?cjNWUkFrWi9ra2s3VUNmcFloS2FSb1hhb3hVck9jcldsZXZMSmhPSDJqMFNk?=
 =?utf-8?B?NlJiS2ExSDMxaEVnMDBXbEZMUnJESC9hZlpKc3JhZk5nTmJVdm8zL0lzQmZF?=
 =?utf-8?B?MjdCQmp6TzRId1VWTTYwUmViV00rNnIya1VZQ2JpMUFmVm1oaEF3WFFhSXds?=
 =?utf-8?B?SzhBMkI4aTltSmZhbkcwTy9SalBTdTFVUlRaSVFrSW1DcVdsdzZOQVhMVXJk?=
 =?utf-8?B?K3B5Y1hWN1pmdlNYa2JaYzhGcE1ZRkQ3a1pDb1lCSGRVNXFxNnFWakpIL2tY?=
 =?utf-8?B?U3RsK051c0NPenJZOXVKdkNyazM4R2E5SERyVEtVMnJEQSt4UGUvUHpkd2dJ?=
 =?utf-8?B?ZzBVS0Y1YUQ1L0JaODNDL25rQzQzSStTMzdueHlwQ2RhMUl5THZKd213OC96?=
 =?utf-8?B?ZGZCU0FlV1psaFc3SjhlcWtNUTB0RjFpMXpxTHk5MUI5bHlTU3ZuVlNpb2U3?=
 =?utf-8?B?U2xaL3g4b2NqKytYUTYyMGFjQmsvVWNVR3ltZjRXQzByTC9pVzNMcWNjYWtZ?=
 =?utf-8?B?RjR0SW9XTlhRUUs0ekJpRVFpOERWM2tGY29wclFJaGhySDBrWXVJbXdRdUlJ?=
 =?utf-8?B?NnpDOVNVc2Z4T0ZIMEZCNVdBUG1selZoV2dBSENqcFVTb04xdzBwSzk0TGRj?=
 =?utf-8?B?bWd3VlloUmhieWc2YnIvSjBPZGFxMjZwSUwwdVZiM1B5Q3p6eGpPaHdmM3No?=
 =?utf-8?B?a3dhQVZDTzF0WVRDRWlBVXJxbHJpSWN6b1R2SmpvRjNId3NPMnhGSzhWS05K?=
 =?utf-8?B?WTJaVk5IWVNoQkNjaHJqZWEwbGZhTDRxWkRHMzh3ZHAvbzhyai9xTDdVb0ZL?=
 =?utf-8?B?ZjA2TFV5ZDR3UXBjclVXc2lxdytQZkVHNC9zdk45bWRTbHJIc3laczBhbG0z?=
 =?utf-8?B?VmxydnhrSVVjVktNcG5CelVSeXFITFJsQ0ZvVG45NGFyZkJPZnNCRUxuK0JJ?=
 =?utf-8?B?ZERvVmFIaFlmYzZxVHpiOW9ST3loKzhBRWFoc2dWTDY3amJWUHhzL24wa1dS?=
 =?utf-8?B?WDAxYjUrblJLVE5DRXhsSjhZbDRock5Id1VIblloeUwwZldPeml3S0xIZ0xZ?=
 =?utf-8?B?STZWSVcxbUlMWnBsbzFrWkFadkRLY0EvejdyMjVpSTZZUFBESkF1RWR0YzV4?=
 =?utf-8?B?a1ZLTjNHY29aZmNxSkNKZjA1OW1DRy8rb1dJNHVQMkJGUVczc3Q0SGVKaERi?=
 =?utf-8?B?bmtCYjJwNVlkbkdvV2NFekRtQS9scFh1OWZkVXFRTHBYQStTLzdiS0lzaU5o?=
 =?utf-8?B?V0dMRDlQV3p4Uzg1a2c4bWVGV1pqRlQxTjNucWNWS0QwdEc2aXIrZjNYRkpB?=
 =?utf-8?B?c3MwOEhwTFB3SVRzcEYrVUc2WDZJY1J4aVl3YzRYYXZreXRPVFV6VWJwSDlW?=
 =?utf-8?B?dTFSQmZLSnhKQ2thaVplQ040ZHdQaDE4Ui91TUJVUXNabjZNSWkvdnJjZkJT?=
 =?utf-8?B?WG9wU2R3aFhhRGRBRlovQW4wS09VMHpzRDVwQVdsTFI5ZUEwWEVmbWllL1E1?=
 =?utf-8?B?ZmkzWWkzUzlTTzExOWpmdUVnOFIydmhMOEdSRDVNNUtrM0dkdWRROCtRcXlD?=
 =?utf-8?B?T21ZV1l5cjNZQ2RlTDhQLzl3RzdWQlEwL0V0a25jNjEvNVoxbkg1MTg4eHVs?=
 =?utf-8?B?MUE9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a91d8f3a-7fe5-4f20-4191-08daf9e728b7
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 06:34:04.7986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XSV4nv6W6R7E1Ujy+cIsnV9UfKiXC4vtOSV/AzWbjN55mYWr/tRQpkdK3JL5w+t/gAjuzHkeKi37Hs3qeSUumQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB6302
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 18.01.23 18:07, Krzysztof Kozlowski wrote:
> On 18/01/2023 17:28, Jan Kiszka wrote:
>> From: chao zeng <chao.zeng@siemens.com>
>>
>> The M.2 variant comes with 2 slots, one B-keyed and another one E-keyed.
>> They are configured by the firmware during startup. Also the device tree
>> will be adjusted according to the detect or manually configured
>> interface mode by the firmware. The kernel only carries a single
>> configuration as base device tree. It has to be built with a symbols
>> node so that the firmware can apply overlays for the connector modes.
>>
>> Signed-off-by: chao zeng <chao.zeng@siemens.com>
>> [Jan: refactored to a single DT]
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  arch/arm64/boot/dts/ti/Makefile               |   3 +
>>  .../dts/ti/k3-am6548-iot2050-advanced-m2.dts  | 122 ++++++++++++++++++
>>  2 files changed, 125 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
>>
>> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
>> index cf7c509538a4..13e79bf7e804 100644
>> --- a/arch/arm64/boot/dts/ti/Makefile
>> +++ b/arch/arm64/boot/dts/ti/Makefile
>> @@ -11,6 +11,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-am6528-iot2050-basic.dtb
>>  dtb-$(CONFIG_ARCH_K3) += k3-am6528-iot2050-basic-pg2.dtb
>>  dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced.dtb
>>  dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced-pg2.dtb
>> +dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced-m2.dtb
> 
> This does not look like proper order.
> 

It's ordered according to their time of release, not simply
alphabetically. But if the latter is a must, I can reorder.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux