Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4dc6a571-8564-b38c-31df-0d9741dfc592@meta.com>
Date:   Wed, 18 Jan 2023 23:34:01 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH] tools: bpf: Disable stack protector
Content-Language: en-US
To:     Eduard Zingerman <eddyz87@gmail.com>,
        Peter Foley <pefoley2@pefoley.com>,
        Quentin Monnet <quentin@isovalent.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>
Cc:     bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
References: <20230114-bpf-v1-1-f836695a8b62@pefoley.com>
 <701abf4bbf5b7957a24d2f164c643e1d9f586fad.camel@gmail.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <701abf4bbf5b7957a24d2f164c643e1d9f586fad.camel@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXhqeWdhQW12dmpxYTFjMDhES1VITENpRzJWT0MyamJ0ZmUyUDhyR0U0MERa?=
 =?utf-8?B?RzMybm5QdVZkUVRNY0RvSStiWG9pMVNreVFTWU5hSUF2TWdvMWpGWlFwdVM5?=
 =?utf-8?B?NGJpQit3MS9ZdnRlbnBCUThDZE8yL1FJTXVHVHJVb3Fnc2NWamphcUpsSUpl?=
 =?utf-8?B?YzNpVFlIdkQ3eUlhK2RLdDBTd0Z2RWdPd29KajV3cWI3eTJKZnZrU0J6bU8w?=
 =?utf-8?B?UEhLdG1EYmJhSkZZRDFyNHlqOGdVZVovSDI2U0ZUTzVFTmMzQmFJWGhCaUhT?=
 =?utf-8?B?UlV2OFpyQzNmWUVFZUR0NjNCendleW9nNzFzaHdCQUxHcE5SQkdtSzBjdFJB?=
 =?utf-8?B?K0JtV09VUFcvTDc0cXhIYXhDa0dmaVVBcHIxYXdHL01pSi9zbjBpd0JLT3Zt?=
 =?utf-8?B?MUtCY1BpVGkyZFM4MkcrTktMcW9EVnJxVk9ESHZGV0xBa3pxakthTjV6cnB3?=
 =?utf-8?B?cXQrRkM3RVZ4akgzNWZ0UGwxcVZibWRhWmRyRTRzRTFoSElRckJyNThqc0Js?=
 =?utf-8?B?aE1MdngzVFl0WVVnZS9PM0lXK0pvZmxkaTMrUC9SazlzcHdFUGZWbDB6V2Va?=
 =?utf-8?B?eVdvUSt6Q2x4WjRVNVpjZUpTNW9OUXZjaDY0emtJSlpsdDdwdFVnWmpLWUZL?=
 =?utf-8?B?OXFBanJEcjJqYStTNkJ0RVVPczgvVGFveTVGNUcxQjZCR2ZCOEhNVTNzcnNK?=
 =?utf-8?B?ZlhPYnJOMHVBTUVUMGFhU0FJNkdQbDVtV0pmRVl5cU1QY1FzdEw0NjNKUWFW?=
 =?utf-8?B?Qk5FTStNYURpMzBURE55SWd5UTdQNUNYaTVSbm51UmhGSTBSR1ZsM3NMZ1RU?=
 =?utf-8?B?dkZMZ1E4NzdRaXR5U1J2MXIxcmR0eXR2dkd6ZEl5RmRtTEpPTk5IRE5EcVgz?=
 =?utf-8?B?LzJDMXVjc1FDNytCaTB2Y3NSSEtnQWsyMVFBL1RKa1Z4Sy9tcnFjMlRJTDRs?=
 =?utf-8?B?Tnh2bHZIWTNvUXp4dGpqT2VHUGNFZ2xnenhHc3k0bys2RUVMRks0b1dZcWFr?=
 =?utf-8?B?d0V5ZHpJODAxejZ1TGpEa3NZSFJFbzdMZ0h0akhIWjJiQWxxRCt4bWwwcnQ5?=
 =?utf-8?B?aC9WTUZKL1hiM3dTMWZXWkFOUFNMUUM3QnNxOEg4dXBlcDVJMnZJSk9lWnNB?=
 =?utf-8?B?U1E5TDBNVi9KK2pDbXVFMzR3MTZXSFRLNlpPN1ZEU3o5Rjc5ZnFpdmduOHhl?=
 =?utf-8?B?ZmtxU1VDZ1BsSkJLd0VlaTZlZ1UzYmN6TWJESFhaa1VLOHlQaGdZUjB4ZmxQ?=
 =?utf-8?B?RGt5V21TaWR0QU9MUFNIRmc4V0hYb3F4cnVtLzBFb0JrMmtlNVJmTGdQMkc3?=
 =?utf-8?B?bE4zQ0U2aHVsY1FHOEhUbE5TUjB0RHNuSVYyaENKcm15MkhKd2pjaGJPTDZB?=
 =?utf-8?B?Z3k5RmgxUkdLb3NBWEMxS1dPenpFK0pTMmdHQlUvbFhtd3RCMktQTXBqdG9u?=
 =?utf-8?B?RjZhazl1TVgvYW01ek1Oa3hNN2dhYU16SmVqQ2hzK0plUHlyM0E3Y3BLcXds?=
 =?utf-8?B?MU9yZ0hSS0c0Zm1paS8vcm01TjIyUzQ2cDVObEZtTVBqejZuc1F0bjY4aEZN?=
 =?utf-8?B?SUFnWmw5RkgzV2g0em9vYWNUUXg5dVZkYXdOME1TeGZsdjQ0bmJMOGFVSjB5?=
 =?utf-8?B?TndJMmlEUnEzam5HVG9KNUhNaFdqYlY1OVduYzBLai81c1RzalViaHZYYXU4?=
 =?utf-8?B?RElQTHZkYWs0aDA5bkRRSkRWc09PRHA4ZitHVzk3VzF6SVpkd0svSTlVY3NR?=
 =?utf-8?B?S0RwdER6YjhicWJKVzBpTHFLT1lENGlFdXN5RStNWnVwdU1jVDFhSzlmSkJp?=
 =?utf-8?B?d0VLaFFXMVNWaFFCU1FXSzVjMHNaSWRaeGU5UVliS1liMFFGZ0Y4UndRc1I0?=
 =?utf-8?B?NWx5c3VHY2gvYXFQRndNZHM5L1dKRTM5cUZ2Q0VFVGhUeVc0Q0NybFdBRm95?=
 =?utf-8?B?TkMzdXp4N3c3R3N3Q00yNzl0VFluSngydWt6dS9CM3dwSWdkWG0rN2RCOENK?=
 =?utf-8?B?aktpNE9Oa3p0VGdnKzFKTk4rOXhheWFpMGhwRW9qa0FxQTArMGdnV2ZvbnhR?=
 =?utf-8?B?S2FGdDBkak42UXdycG91NkY4LzBmWmZnMWxWWHJUTmV2ekRBS25mOThnOGsw?=
 =?utf-8?B?UGJlM0VUSDJ0Mnc3Qml5MWtHWWNxV1FvTFVBRnc1anVGcUdGdWlaOE1ZaTZr?=
 =?utf-8?B?RVE9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16f38143-9e68-4444-6394-08daf9ef8a9d
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 07:34:04.6448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rBq3V91i8iCtCo2a0i7rEk7zDz8RoFNsUnROzRQzb2xTdvH+lz4TtJZdkBG3Zcl5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR15MB5578
X-Proofpoint-GUID: -M9iWvRNBAuZIzdAku94vEEwvBJPJ2RF
X-Proofpoint-ORIG-GUID: -M9iWvRNBAuZIzdAku94vEEwvBJPJ2RF
Content-Transfer-Encoding: 7bit
X-Proofpoint-UnRewURL: 1 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-18_05,2023-01-18_01,2022-06-22_01
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/18/23 11:28 AM, Eduard Zingerman wrote:
> On Sat, 2023-01-14 at 18:00 -0500, Peter Foley wrote:
>> Avoid build errors on distros that force the stack protector on by
>> default.
>> e.g.
>>    CLANG   /home/peter/linux/work/tools/bpf/bpftool/pid_iter.bpf.o
>> skeleton/pid_iter.bpf.c:53:5: error: A call to built-in function '__stack_chk_fail' is not supported.
>> int iter(struct bpf_iter__task_file *ctx)
>>      ^
>> 1 error generated.
>>
>> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
>> ---
>>   tools/bpf/bpftool/Makefile    | 1 +
>>   tools/bpf/runqslower/Makefile | 5 +++--
>>   2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
>> index f610e184ce02a..36ac0002e386f 100644
>> --- a/tools/bpf/bpftool/Makefile
>> +++ b/tools/bpf/bpftool/Makefile
>> @@ -215,6 +215,7 @@ $(OUTPUT)%.bpf.o: skeleton/%.bpf.c $(OUTPUT)vmlinux.h $(LIBBPF_BOOTSTRAP)
>>   		-I$(or $(OUTPUT),.) \
>>   		-I$(srctree)/tools/include/uapi/ \
>>   		-I$(LIBBPF_BOOTSTRAP_INCLUDE) \
>> +		-fno-stack-protector \
> 
> While working on clang patch to disable stack protector
> for BPF target I've noticed that there is an option to
> disable default configuration file altogether [1]:
> 
>    --no-default-config
> 
> Should we consider it instead of -fno-stack-protector
> to shield ourselves from any potential distro-specific
> changes?

Peter, could you help check whether adding --no-default-config works
in your environment or not?

> 
> [1] https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-no-default-config
> 
>>   		-g -O2 -Wall -target bpf -c $< -o $@
>>   	$(Q)$(LLVM_STRIP) -g $@
>>   
>> diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile
>> index 8b3d87b82b7a2..f7313cc966a04 100644
>> --- a/tools/bpf/runqslower/Makefile
>> +++ b/tools/bpf/runqslower/Makefile
>> @@ -60,8 +60,9 @@ $(OUTPUT)/%.skel.h: $(OUTPUT)/%.bpf.o | $(BPFTOOL)
>>   	$(QUIET_GEN)$(BPFTOOL) gen skeleton $< > $@
>>   
>>   $(OUTPUT)/%.bpf.o: %.bpf.c $(BPFOBJ) | $(OUTPUT)
>> -	$(QUIET_GEN)$(CLANG) -g -O2 -target bpf $(INCLUDES)		      \
>> -		 -c $(filter %.c,$^) -o $@ &&				      \
>> +	$(QUIET_GEN)$(CLANG) -g -O2 -target bpf $(INCLUDES)		\
>> +		 -fno-stack-protector 					\
>> +		 -c $(filter %.c,$^) -o $@ &&				\
>>   	$(LLVM_STRIP) -g $@
>>   
>>   $(OUTPUT)/%.o: %.c | $(OUTPUT)
>>
>> ---
>> base-commit: 97ec4d559d939743e8af83628be5af8da610d9dc
>> change-id: 20230114-bpf-918ae127b77a
>>
>> Best regards,
>