Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <04a37865-516c-45a8-8099-7d3a284fdf98@linaro.org>
Date:   Thu, 19 Jan 2023 08:43:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH 2/3] dt-bindings: arm: ti: Add binding for Siemens IOT2050
 M.2 variant
Content-Language: en-US
To:     Jan Kiszka <jan.kiszka@siemens.com>,
        "Raghavendra, Vignesh" <vigneshr@ti.com>,
        Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Bao Cheng Su <baocheng.su@siemens.com>,
        Chao Zeng <chao.zeng@siemens.com>
References: <cover.1674059300.git.jan.kiszka@siemens.com>
 <3f825ff8853b1ffd8228d3283c7da0483ddf55d5.1674059300.git.jan.kiszka@siemens.com>
 <a219dcf6-412b-a9f8-cf06-1896df0709de@ti.com>
 <dc6fc5be-0b53-00fc-3664-4dfd11b1fea9@siemens.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <dc6fc5be-0b53-00fc-3664-4dfd11b1fea9@siemens.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/01/2023 07:34, Jan Kiszka wrote:
> On 18.01.23 18:43, Raghavendra, Vignesh wrote:
>> Hi Jan,
>>
>> On 1/18/2023 9:58 PM, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> This new variant is derived from the Advanced PG2 board, replacing the
>>> MiniPCI slot with B and E-keyed M.2 slots.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> index 203faab80142..7af813202f1f 100644
>>> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> @@ -43,6 +43,7 @@ properties:
>>>            - enum:
>>>                - siemens,iot2050-advanced
>>>                - siemens,iot2050-advanced-pg2
>>> +              - siemens,iot2050-advanced-m2
>>
>> Could you re arrange alphabetically?
> 
> Time of release ordering, but I can reorder as well.

The entries look ordered alphabetically, not by time of release. BTW, I
assume time of release != time of adding to Linux, which would be just
dropping stuff to the end...

Best regards,
Krzysztof