Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bb2e8b7b4ca894ed53d70bf04e2d52bed2553105.camel@gmail.com>
Subject: Re: [PATCH v1 1/2] iio: core: Replace
 iio_sysfs_match_string_with_gaps() by __sysfs_match_string()
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonathan Cameron <jic23@kernel.org>,
        Michael Hennerich <michael.hennerich@analog.com>
Date:   Thu, 19 Jan 2023 09:00:45 +0100
In-Reply-To: <64406c4f-c9da-b434-360b-1050ff685d2d@metafoo.de>
References: <20230118074828.66155-1-andriy.shevchenko@linux.intel.com>
         <5f9b713b-9c71-7da6-e674-b6ebd28dc5d5@metafoo.de>
         <Y8gVDs0UoiHqCRsM@smile.fi.intel.com>
         <64406c4f-c9da-b434-360b-1050ff685d2d@metafoo.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-01-18 at 08:37 -0800, Lars-Peter Clausen wrote:
> On 1/18/23 07:49, Andy Shevchenko wrote:
> > On Wed, Jan 18, 2023 at 07:22:30AM -0800, Lars-Peter Clausen wrote:
> > > On 1/17/23 23:48, Andy Shevchenko wrote:
> > > > None of the current users is using gaps in the list of the
> > > > items.
> > > > No need to have a specific function for that, just replace it
> > > > by
> > > > library available __sysfs_match_string().
> > > Hm, I specifically remember adding this for a driver where there
> > > were gaps.
> > > One of the DACs. But it might be that the driver itself never
> > > made it
> > > upstream.
> > I have checked all modules that have struct iio_enum and/or ("or"
> > probably may
> > not happen) IIO_ENUM() in them.
> >=20
> > It might be that I missed something.
> I checked too, I can't find it either. The driver probably never made
> it=20
> upstream.

Yeah, I also did a quick check and I could find it in one adc (most
likely we have more downstream users of this) that did not make it
upstream. Eventually, we want to have it upstream but the ABI using the
gaps can arguably be dropped...

Anyways, from my side I'm fine with this change. We can revert it if we
ever have a real user for this. I'll just have to be careful when
updating ADI tree (but that is our problem :)).

- Nuno S=C3=A1