Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp696713rwb; Thu, 19 Jan 2023 01:11:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXtomjTysyu0vPTFq14SzxUvK3UctawMbg17u5P8CIe1RBpV6whsMKYg9zUnDGJRjZkma5w+ X-Received: by 2002:a17:907:a07b:b0:7c1:3f04:efa2 with SMTP id ia27-20020a170907a07b00b007c13f04efa2mr23824549ejc.29.1674119490088; Thu, 19 Jan 2023 01:11:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674119490; cv=none; d=google.com; s=arc-20160816; b=vHnUbQfZMnTuSbj82ZFf7kBVWZoqCwUMuZ38Dk/7nnaU2DCwXRmD+mNXDakZ/R3eE+ uCc1oQPgOHufWQGjVUw1dg/dMqGpxtXwZnM9pE8/GfvkUfrPOA5JV4hQNmCBwmIrecC+ GC53K6zF8tzTkS0RrFB2WwRziWr2ep9IQ/YNO4tgp5mj6U9ppwgOR7neBMI8XmgLoExo OVUAosAAcSnERP2JCS5/cC3wyPPE6SRi8mq1XVixS7JTyIjpQd6g8OjpB6Q9hB9i71B0 LVhlCqT7gnuZr4x6ckG2D5L+AMcHBaAM3i2ar/tZCcvsgqz635F3uWPe8A7RcTfyRHsK juXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=mn2JbKYAQsNeYnkRN5qpIkeRXL317vu4/izCeLSldg0=; b=LQTuV9U+JqtzCclLBwO9i+YoWmCLbbTcAO0t4DsTSSibtyBvNU4kCosUzwbHpWMoiP RSa+4Hae3n9TK4SeenkxWdr+1cvrGaLwnACujDSAZndeXVHcKuPFnP7t/mBTLelaRcXb 2XdKJK6R+pHpDJJHi2Ivbo3BbRIlE8IddlgYmeFnbmhYDbSYvE0UHcY6OlH5QzyizN9p Dds9Un3yc63YhY35lUk8odf3gAYPybUm5ZWzntGf0y6XB06y+ukYOI2ep13irDIGGolm LUKS178oZwZR1qKu4b9udRq1AZ5BfRxrnIDVUK1Kp2vX9T9PB5bpJoCjHuRfm6kQX22j PUhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=rc+37mK0; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Z1Wc+S3U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt14-20020a170907728e00b008318885e1f1si43640926ejc.176.2023.01.19.01.11.19; Thu, 19 Jan 2023 01:11:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=rc+37mK0; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Z1Wc+S3U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229814AbjASI5x (ORCPT + 44 others); Thu, 19 Jan 2023 03:57:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbjASI5q (ORCPT ); Thu, 19 Jan 2023 03:57:46 -0500 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D93A6796A; Thu, 19 Jan 2023 00:57:44 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id EC7655C006C; Thu, 19 Jan 2023 03:57:40 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 19 Jan 2023 03:57:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1674118660; x=1674205060; bh=mn2JbKYAQs NeYnkRN5qpIkeRXL317vu4/izCeLSldg0=; b=rc+37mK0rgykOYr91sA8MJnxUK JcUHSxUB69vOrQtZLXtQ2y3+34WpCXOv3Se7NsQYwRQjhOc/nxIogKjP2Cp3Pyy7 /bGWCTq29Nhfcr/I1Il7AkCRw5PxOB9wRp00ZE/IDjd0LBUJsr8zESXbA30FuT7u FIe9Mziudr3VeSlEvXdg2vOFG2+3G2fJMvaYg2jxHhlGjy8jdEbr2XVSr3mw2cPP Z/1GqQBp32x0h3HW5IgWBhPCjYP5lBi/XX8MJ3U+6SQE8sN1QuSZfDN/PZ+u5FFg h12taYI556qigoUGGooWgAGvKAUHpVvtIZ+6XlEUlmubSroMCbZdjsLP9U9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674118660; x=1674205060; bh=mn2JbKYAQsNeYnkRN5qpIkeRXL31 7vu4/izCeLSldg0=; b=Z1Wc+S3Uwo5G8OQ47N8l6W0p2DSVnHbOqaJT5Lfwazt/ jLStp3Z0z7T3hPQYkOrgBsTUm2KAlHS3Vw8aot9X5U/ZAAJbxEt7wbl7UMcxpFqW bfr2SLl7M3IVB0aCOVsVd7WQhoMYa0/ooT0EY89pcOT7LwA+lAaGwORxN8AySvgp DDCDnDX4FNS7pLe8+md/xCCaXNr8/Wk/nksHhW0oDMKN/kUVjae/TLea1wEEJqCU S7A0xfL25qYEBYOCErtUqJdDxriE3F5HvGjqmSEfkzRJoT4xRsl3d/O5FLl9ONEM Brb1Ub0USVaO72dOJUCmDS+SQt1ZpJQcOKEj6/cLcQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtledguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id EAAB2B60086; Thu, 19 Jan 2023 03:57:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0 Mime-Version: 1.0 Message-Id: In-Reply-To: <20230119033918.44117-15-blarson@amd.com> References: <20230119033918.44117-1-blarson@amd.com> <20230119033918.44117-15-blarson@amd.com> Date: Thu, 19 Jan 2023 09:57:20 +0100 From: "Arnd Bergmann" To: "Brad Larson" , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, "linux-mmc @ vger . kernel . org" , linux-spi@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, "Andy Shevchenko" , blarson@amd.com, brendan.higgins@linux.dev, "Brian Norris" , brijeshkumar.singh@amd.com, "Catalin Marinas" , "David Gow" , gsomlo@gmail.com, gerg@linux-m68k.org, "Krzysztof Kozlowski" , krzysztof.kozlowski+dt@linaro.org, "Lee Jones" , "Lee Jones" , "Mark Brown" , yamada.masahiro@socionext.com, "Philipp Zabel" , piotrs@cadence.com, p.yadav@ti.com, "Randy Dunlap" , "Rob Herring" , "Samuel Holland" , "Serge Semin" , skhan@linuxfoundation.org, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, "Tony Huang" , "Ulf Hansson" , vaishnav.a@ti.com, "Will Deacon" , devicetree@vger.kernel.org Subject: Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2023, at 04:39, Brad Larson wrote: > > +extern unsigned int sdhci_timeout_val; > + This declaration should not be in the .c file, and I don't think there should be a global variable with this overly generic name either. Arnd