Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp780915rwb; Thu, 19 Jan 2023 02:35:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXvPa2S281rqq2VAFDTHCtg5G9x3P4UTRRznqI5d0eIKxIRZn9GAfEo44egCGluFEZJ5TOq/ X-Received: by 2002:a05:6a20:7048:b0:b8:915c:477f with SMTP id i8-20020a056a20704800b000b8915c477fmr9464739pza.19.1674124509293; Thu, 19 Jan 2023 02:35:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674124509; cv=none; d=google.com; s=arc-20160816; b=Gc/PL1ZFn52I7pQ+8fLNLYNGl/5jTpWbly3gqRddQiTgWmLxqubs76YV1GoCPDyW5p rCugiqfRASMJEB/06DyNvaejUVgCXW33Fg2EzPqOHJeM6HRx7fC/a47Zwm7yOqv+ru8g 7BrrvWCz7QI97NmOVmiBvRvf8NgXQbbcFdnh64WslvDLn80cs6gpwYBj1E6VCeQzzI0/ 7JL/Apohv84CCmlyKD4uU47AhkB0Dt3XOOaoaRXCOSME73dHRQ9gQG//2qVWzIt0rAfS zwerqmUWrWoyaR9GVf4NBm1nHyL7IRE/Q9r+rpqJNMeKwA2k4V7LUdd9/0C21fIXxrtC L+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=8KlZvB/UZYoksWT8hu741iFNZtBsBPjxTGyRD6uI2Ko=; b=uwZ4VU4ztq66igB7gThKGSAZ2p41KJJkmh3xrZhPuhAAGvAVMdnbiApWDpwpw/KG5J oKPvL01xKOVa2EumPYWVYp4NQxQ6ei+qvXMzSq52uzZokptCTCsPnK3/ktNUSfTHVby+ DR24c+pkXlJxnsvRNtLD2WNr1VsHBRVR6Ctwc5pjwmH1Q+S1Qz7w6VKAb5XwQZ80Nga6 JB5/ri5nw/OjwRIaVy7bU6hQXxi18hv21cYgu+6As8LW8Vd6Qus7KApN/+Y4GbPAdUGC Zu0LOog1fPvfg8N/WUtAoF+sEM/UpGT5Lx8I/IzR2ywsGOVkM76aXXUZ3yOdvwWuWyZQ x7gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=k0ic+1V+; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h190-20020a6383c7000000b00498fda6b663si8641282pge.36.2023.01.19.02.35.04; Thu, 19 Jan 2023 02:35:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=k0ic+1V+; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230045AbjASK3u (ORCPT + 44 others); Thu, 19 Jan 2023 05:29:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbjASK3r (ORCPT ); Thu, 19 Jan 2023 05:29:47 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA3B73ABA for ; Thu, 19 Jan 2023 02:29:44 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 597FC5CC2F; Thu, 19 Jan 2023 10:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674124183; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8KlZvB/UZYoksWT8hu741iFNZtBsBPjxTGyRD6uI2Ko=; b=k0ic+1V+fKvyIIFs/LqlGPRvOUUHZVkeHkWDW004aaWTKsGZ3EXfpIXL/X5TutMdq0RS6/ Zps69tLDQf13QMeOgU9VSzVljwAtVYoRbvEDH+FB7LM+GGfPb4ftN+JIQjDlf1631uk5km QlOrHXOB/T98YRidodHAULA3xQCUKjg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674124183; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8KlZvB/UZYoksWT8hu741iFNZtBsBPjxTGyRD6uI2Ko=; b=IPhbZ9EjkvqmGUIZ4C2Y+sFXn75Ef5eDpMFoum3Woe46eGFKF3Rrh3sCajGcCn/nS43V4w AX6jqcqyb1M9CUAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 374A3139ED; Thu, 19 Jan 2023 10:29:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jk/VDJcbyWO2HgAAMHmgww (envelope-from ); Thu, 19 Jan 2023 10:29:43 +0000 Date: Thu, 19 Jan 2023 11:29:42 +0100 Message-ID: <87wn5irf55.wl-tiwai@suse.de> From: Takashi Iwai To: Artemii Karasev Cc: Jaroslav Kysela , Takashi Iwai , Xiang wangx , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] ALSA: hda/via: Avoid potential array out-of-bound in add_secret_dac_path() In-Reply-To: <20230119082259.3634-1-karasev@ispras.ru> References: <20230119082259.3634-1-karasev@ispras.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Jan 2023 09:22:59 +0100, Artemii Karasev wrote: > > snd_hda_get_connections() can return a negative error code. > It may lead to accessing 'conn' array at a negative index. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Artemii Karasev > Fixes: 30b4503378c9 ("ALSA: hda - Expose secret DAC-AA connection of some VIA codecs") Thanks, applied. Takashi