Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 Jan 2023 11:26:53 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Daniel Scally <djrscally@gmail.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v1 1/1] device property: Make
 fwnode_graph_for_each_endpoint() consistent
Message-ID: <Y8kM3bzIBF3dbuZh@kuha.fi.intel.com>
References: <20230117152120.42531-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230117152120.42531-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk

On Tue, Jan 17, 2023 at 05:21:20PM +0200, Andy Shevchenko wrote:
> Make fwnode_graph_for_each_endpoint() consistent with the rest of
> for_each_*() definitions in the file, i.e. use the form of
> 
> 	for (iter = func(NULL); iter; \
> 	     iter = func(iter))
> 
> as it's done in all the rest of the similar macro definitions.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

FWIW:

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  include/linux/property.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 37179e3abad5..f090419818a2 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -436,9 +436,9 @@ fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode,
>  unsigned int fwnode_graph_get_endpoint_count(struct fwnode_handle *fwnode,
>  					     unsigned long flags);
>  
> -#define fwnode_graph_for_each_endpoint(fwnode, child)			\
> -	for (child = NULL;						\
> -	     (child = fwnode_graph_get_next_endpoint(fwnode, child)); )
> +#define fwnode_graph_for_each_endpoint(fwnode, child)				\
> +	for (child = fwnode_graph_get_next_endpoint(fwnode, NULL); child;	\
> +	     child = fwnode_graph_get_next_endpoint(fwnode, child))
>  
>  int fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode,
>  				struct fwnode_endpoint *endpoint);
> -- 
> 2.39.0

-- 
heikki