Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp798101rwb; Thu, 19 Jan 2023 02:53:27 -0800 (PST) X-Google-Smtp-Source: AMrXdXuh55TqP4xnUZ4BZh8XxFuT6pEgl9xl1/P5vq+txFd+Ki1xjFsvRMU4SLfUoQCxVhf2/dld X-Received: by 2002:a05:6402:1764:b0:49b:7416:e3fc with SMTP id da4-20020a056402176400b0049b7416e3fcmr10366537edb.36.1674125607160; Thu, 19 Jan 2023 02:53:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674125607; cv=none; d=google.com; s=arc-20160816; b=t8ZZrUAslhEyPAlnrp71zHWpdC/7wHSYs4FaaRzDY410njI/JjdZPYVH/SY3geRMVY MCiV7P/S7k77UNE3KUmCWTfYSPyDqpJWT8BC4ltKelmbKAfh8nrLsBLzWmWfQHNjA061 srROdG1I0wfrzUuHOiAFgcHVZBtaDEQYDMw0UfXJug+dHOD3jvL6Z8svFRpkCj0fMLwW nLKZ6N1fo2F6lpUc2eEBmrC+2KWq05+BsnaOHB7PYRi2WEl0A0S/yw9QNgitElU17nq8 FkJWX+DdMFU4SDu6ItD2vhyBEzPKnVT/gqilRqvUY0K4IleIArD0Y85N4PSBWsPSifdW 7ruQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YC3HZeFmpTWTR27bvicWWSMmr/5hlJ0I3x/nSKUzYMY=; b=O8nzQzZO9P4jW9gGOR6ekNwTScNS3Ibz0wbAuD4mjGy/3T2JUbnRK9HKehdB04+mOR z2qui+hJcQ3j/hXi1yb6s8ZdcuxLF1JscrlepjQyhoITa8+OVuwRVOoXxo/UgSM0rUhE PNZc2mtBLpgv7PRRxyYu9sn5RXvkA2bXVv/FkH7WR+gJO+Ys/pYRV2AJEk2qU4mlcWHj pbcZD4fKd0eFgp6qIrk7DPcWJYXR4xwENydiOiBdKwV8Z3MCNEC6L8YCkxnayyhZubTC Lduwy2OPjgAA4Axru73xCfwnBelPX7kFXEeM8rMZXdiZhLp7Rmzwl5wgs1av1IN60X9L LJiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kqDqPevZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i21-20020aa7c715000000b0046bb19bce74si15767418edq.441.2023.01.19.02.53.15; Thu, 19 Jan 2023 02:53:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kqDqPevZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230424AbjASKfI (ORCPT + 46 others); Thu, 19 Jan 2023 05:35:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230347AbjASKeb (ORCPT ); Thu, 19 Jan 2023 05:34:31 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CF006F32B for ; Thu, 19 Jan 2023 02:33:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C707B61511 for ; Thu, 19 Jan 2023 10:33:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CD1CC433D2; Thu, 19 Jan 2023 10:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674124435; bh=FSTb7ps69bklSNTl2tXp872NF4+kDIeeWJq6EUM+gQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kqDqPevZQ4XSsi7+3j4KXbs/udOIaV72oY3M/upUjyTkZVRyb8Svnwr3nY1nRv5E2 DptSYerO5xOVbpK3gXlz+pkd9ItIywRQ8CRlyjNfIdn3Hn9dP5mbaMiiRmNB8rnxrr YqBbDf2XjaKav81W1Us7rdYVdWc424fwSuTBBudRXIjlOmWcMccxm5ejjKsF9WNxyG D3Sv12PzfflJENNniy5NwIZ0SEUEsi0+Rw9xooSUgezbku9n2iJ7mpLsZE563G7w5B 0wwLkKKO1fqLNbOceGikTfJkIkoXeqq8P17mOlu+jiyAWOqnoLn2Q/jlIzEw9U0Dw/ jq75wUiw7iURA== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Tomer Tayar Subject: [PATCH 08/10] habanalabs: run error handling if scrub_device_mem fails after reset Date: Thu, 19 Jan 2023 12:33:37 +0200 Message-Id: <20230119103339.718430-8-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230119103339.718430-1-ogabbay@kernel.org> References: <20230119103339.718430-1-ogabbay@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomer Tayar If device memory scrubbing from hl_device_reset() fails, we return with an error code but not perform error handling code. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c index 9a9c494b08a4..edeec35fd9c6 100644 --- a/drivers/accel/habanalabs/common/device.c +++ b/drivers/accel/habanalabs/common/device.c @@ -1738,7 +1738,7 @@ int hl_device_reset(struct hl_device *hdev, u32 flags) rc = hdev->asic_funcs->scrub_device_mem(hdev); if (rc) { dev_err(hdev->dev, "scrub mem failed from device reset (%d)\n", rc); - return rc; + goto out_err; } spin_lock(&hdev->reset_info.lock); -- 2.25.1