Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b9172e14-0370-7ba5-2589-b3429b6c1e5d@wolfvision.net>
Date:   Thu, 19 Jan 2023 13:01:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH 5/5] arm64: dts: rockchip: add pinctrls for 16-bit/18-bit
 rgb interface to rk356x
Content-Language: en-US
To:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Sandy Huang <hjc@rock-chips.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sascha Hauer <sha@pengutronix.de>
References: <20221130140217.3196414-1-michael.riesch@wolfvision.net>
 <20221130140217.3196414-6-michael.riesch@wolfvision.net>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20221130140217.3196414-6-michael.riesch@wolfvision.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjJMcVBWMURWMFVzYjBybWZSU2o2Zm1vc1YzbmRCaitIOG5FdVlqNUJHY1FC?=
 =?utf-8?B?azMwUklySy9BUUVXQUcwc3pLVDYzMjNIV2lFdkhzM2JEWUQydHpORzBSdUUw?=
 =?utf-8?B?K3pYRElrYWgzVXRLOVB5UWtvTHZBTjZzVWdwUjZBU2laZmhYd3pqVFdlSzl1?=
 =?utf-8?B?Tzg0L3A5REpROCttNTFSWTVkdVVzZHdlYVBoS2lvRzQyTmo4SHlpbVdhSzlU?=
 =?utf-8?B?aHc2d2lDeEp0VENIa3NvM3Z5YzhJdDNDQ1d1eXhwblBsZzFaazN3SGxpT1FI?=
 =?utf-8?B?UlcyQUptaFZmTGpYUTBQUGltNG1DTDVYdlZkbEhEeXNCTG9HZGhoZlZER1pp?=
 =?utf-8?B?SDlMZmVnR0ZkOWVPa1o5T3JHaTB1bW1DbklhL1BXSmxBSTlkQTlWUjA0clJG?=
 =?utf-8?B?ZmpzbkM1NG5lR2V3c2tmT1RXOWxJK3VRcU5EMTArOFZVZlFvNWF0NkhmWW5p?=
 =?utf-8?B?NUhYL20xeFZEdVdoSVpIYmduZjdXVi9HaDQxT0VHbmo0TjJkZk1LcjB4OXNT?=
 =?utf-8?B?VWgvYjFYTFZQUnI3SUVGVEsxRlo0NmdRSlNHcXJscFZKZlowTlF4aEFDY1RO?=
 =?utf-8?B?T05INEdqcWcrSjhudEthQmJ2Wk5YRXc3Q0wvdkxETXgrd044eXIrZjVObGdT?=
 =?utf-8?B?ci96aW05U1dKeThBYzg2ZHRCVDJ4SHk1emF1SW85MWNtZHowQlVaMDcwakIz?=
 =?utf-8?B?bGtPUk1UZHZiQlllMVd2c2tiWnB0MjM1ODJaMGpoYlh4aTVEKzZjSk9lYytD?=
 =?utf-8?B?ODRobFlpeEQ4MXVrZkVYM1BMWmtvaitIanEyNVFTMkdYaWRwZ052djNlMzQx?=
 =?utf-8?B?QWZXa21YS2Y4TXFFRTZnNFFQTXpMZXUxRzBxSWdBMHRNdnVSS2xTQWVOVUJt?=
 =?utf-8?B?UEFKNmdVOXNtTU9oWnVMWGlIRnIrODl2RVdYVk4wMzRid1hnZDVYWnNQUU40?=
 =?utf-8?B?bTZ0QWRKZWJseHdtbkZRWmJEOUU3dGUrbHphVzZJRzVLZFpneDkwWDhXK0Fv?=
 =?utf-8?B?SjFDc01IMFhjM2pZWWtHY0N4N1pzZzdZMmdhR0FKVmkwMEI0dDZHZ29XWGVS?=
 =?utf-8?B?dXRvUDZBM0k4QXdzTjF0WGNZaVJFWCtPWTlUYTFHSzVERDVFbGNheWRpM2NT?=
 =?utf-8?B?UE9RNmZScHJLZVlMMWZmM3ZaeHdqR2wvMFFsY0pPM0xBVTBzMTkwNkIzVGYz?=
 =?utf-8?B?WlpOWEIwZU5rektvRGRWTXlrNkVjVTlrdkdFVGdTNHdqMDQxRnFkMWNCeTl2?=
 =?utf-8?B?bW5kaGxMZkFDcVZxdXYwcldJbUZ6UW5URTlacElLREtFbnlRQkxNdTZOMWk2?=
 =?utf-8?B?ZFlTV2pueGxqNWdZVFpWQ2xwdmJZQVNHSzhYZFBqMnExMG51RzVyZjZZVDJn?=
 =?utf-8?B?dGJqbFhxNitWQU1ZU0RKMjY2MEppcldYTGxTN1JHd2ZtSEh6WWF1ckM5QnJh?=
 =?utf-8?B?REw2ekRXcEtLNDJNRC9Wd0JIUFFWdmJ2UHltd3Nya0gvS0w3eXNMMzJOU3ll?=
 =?utf-8?B?d3JvQ095Qmpoa3RMeXZFUGJjYUpSOERVQlhNTG9DR0FHUEFRUmp1OTQzMHI3?=
 =?utf-8?B?TVUyNkM4clhlbEdIV2haK24zWi9VYW4rNnpwYWRCdzBSWUR2b1BGSDRxR0dH?=
 =?utf-8?B?M3F6TFFjZzVlWWd3Z0lZdjM0b0w1WnZDaElvL1hTL0l1L1VBQTF6akEvMGxz?=
 =?utf-8?B?Skd5cVlkcE9VcVFiUGVqSGNUR0NOMFpEcFdiY1c0YjVvZ0M2a0VHMk95L2d0?=
 =?utf-8?B?VjZrS0N5ZGg1ajhOQjBJQnNsVVJtd2J4S2ZLYlRNSU9HeWczS0c4V3FiMmNU?=
 =?utf-8?B?SnV4SXpGYThiazNHcC83aGVlMmt2bzd1MnMxbE9FbWJlZ1BsMWVHbndyL3Rz?=
 =?utf-8?B?VUF5Nzl0S3NiU1hkZ2M4ckpVM1RGblpSNnE3V09WN0RrTjRCYTZVcnh4UWxE?=
 =?utf-8?B?aDlHNXhhMUFkd2pxQ0V6QlpjbmpHa280Smp0a1RLcjI5TytaQ2c4N1R0UTlj?=
 =?utf-8?B?REJrVThqbDlybW44MmtuY0dvemk0bW00Y3paMFpRcU1OTFh4Q3ZWM1RZLzdn?=
 =?utf-8?B?STc3N2pyUEJKY05MekdDaVhZQWRPeXR3UVRXWGxnclhFTU1zQVgvT3ZRQXVY?=
 =?utf-8?B?eWlnRjg3bGhNRVZwWkN5OG45Qy9sdjBadEd2bjVBNitrRkNwb2JSNVlNaWpk?=
 =?utf-8?B?V3NLSi9vY3lwUDc2MFBWRk9hTFZ5ZjQ1OGVsSkxaZm5lVTJ5TlhwYUdZOWFS?=
 =?utf-8?B?NWcreVVqS05zWWd5N3N5dllRQ0xBPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 50b5896f-dc8d-408b-0285-08dafa14f37c
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 12:01:51.8875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /Z1TcIpE63hHJptxZbD37UQbCJrcZnpz98Jdkb/VtIRHx2UVJEDOIffyoSN7UvVeEPVuU3c6zKlz/NC6G5g6QWT3bii65Ro5e4aEvAFQe8A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7468
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Heiko,

On 11/30/22 15:02, Michael Riesch wrote:
> The rk3568-pinctrl.dtsi only defines the 24-bit RGB interface. Add separate
> nodes for the 16-bit and 18-bit version, respectively. While at it, split
> off the clock/sync signals from the data signals.
> 
> The exact mapping of the data pins was discussed here:
> https://lore.kernel.org/linux-rockchip/f33a0488-528c-99de-3279-3c0346a03fd6@wolfvision.net/T/
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

This patch is somewhat independent of the other patches of the series.
In particular it is not affected by the comments that this series has
received so far. If there are no objections, you might consider applying it.

Thanks and best regards,
Michael

> ---
>  .../boot/dts/rockchip/rk3568-pinctrl.dtsi     | 94 +++++++++++++++++++
>  1 file changed, 94 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
> index 8f90c66dd9e9..0a979bfb63d9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
> @@ -3117,4 +3117,98 @@ tsadc_pin: tsadc-pin {
>  				<0 RK_PA1 0 &pcfg_pull_none>;
>  		};
>  	};
> +
> +	lcdc {
> +		/omit-if-no-ref/
> +		lcdc_clock: lcdc-clock {
> +			rockchip,pins =
> +				/* lcdc_clk */
> +				<3 RK_PA0 1 &pcfg_pull_none>,
> +				/* lcdc_den */
> +				<3 RK_PC3 1 &pcfg_pull_none>,
> +				/* lcdc_hsync */
> +				<3 RK_PC1 1 &pcfg_pull_none>,
> +				/* lcdc_vsync */
> +				<3 RK_PC2 1 &pcfg_pull_none>;
> +		};
> +
> +		/omit-if-no-ref/
> +		lcdc_data16: lcdc-data16 {
> +			rockchip,pins =
> +				/* lcdc_d3 */
> +				<2 RK_PD3 1 &pcfg_pull_none>,
> +				/* lcdc_d4 */
> +				<2 RK_PD4 1 &pcfg_pull_none>,
> +				/* lcdc_d5 */
> +				<2 RK_PD5 1 &pcfg_pull_none>,
> +				/* lcdc_d6 */
> +				<2 RK_PD6 1 &pcfg_pull_none>,
> +				/* lcdc_d7 */
> +				<2 RK_PD7 1 &pcfg_pull_none>,
> +				/* lcdc_d10 */
> +				<3 RK_PA3 1 &pcfg_pull_none>,
> +				/* lcdc_d11 */
> +				<3 RK_PA4 1 &pcfg_pull_none>,
> +				/* lcdc_d12 */
> +				<3 RK_PA5 1 &pcfg_pull_none>,
> +				/* lcdc_d13 */
> +				<3 RK_PA6 1 &pcfg_pull_none>,
> +				/* lcdc_d14 */
> +				<3 RK_PA7 1 &pcfg_pull_none>,
> +				/* lcdc_d15 */
> +				<3 RK_PB0 1 &pcfg_pull_none>,
> +				/* lcdc_d19 */
> +				<3 RK_PB4 1 &pcfg_pull_none>,
> +				/* lcdc_d20 */
> +				<3 RK_PB5 1 &pcfg_pull_none>,
> +				/* lcdc_d21 */
> +				<3 RK_PB6 1 &pcfg_pull_none>,
> +				/* lcdc_d22 */
> +				<3 RK_PB7 1 &pcfg_pull_none>,
> +				/* lcdc_d23 */
> +				<3 RK_PC0 1 &pcfg_pull_none>;
> +		};
> +
> +		/omit-if-no-ref/
> +		lcdc_data18: lcdc-data18 {
> +			rockchip,pins =
> +				/* lcdc_d2 */
> +				<2 RK_PD2 1 &pcfg_pull_none>,
> +				/* lcdc_d3 */
> +				<2 RK_PD3 1 &pcfg_pull_none>,
> +				/* lcdc_d4 */
> +				<2 RK_PD4 1 &pcfg_pull_none>,
> +				/* lcdc_d5 */
> +				<2 RK_PD5 1 &pcfg_pull_none>,
> +				/* lcdc_d6 */
> +				<2 RK_PD6 1 &pcfg_pull_none>,
> +				/* lcdc_d7 */
> +				<2 RK_PD7 1 &pcfg_pull_none>,
> +				/* lcdc_d10 */
> +				<3 RK_PA3 1 &pcfg_pull_none>,
> +				/* lcdc_d11 */
> +				<3 RK_PA4 1 &pcfg_pull_none>,
> +				/* lcdc_d12 */
> +				<3 RK_PA5 1 &pcfg_pull_none>,
> +				/* lcdc_d13 */
> +				<3 RK_PA6 1 &pcfg_pull_none>,
> +				/* lcdc_d14 */
> +				<3 RK_PA7 1 &pcfg_pull_none>,
> +				/* lcdc_d15 */
> +				<3 RK_PB0 1 &pcfg_pull_none>,
> +				/* lcdc_d18 */
> +				<3 RK_PB3 1 &pcfg_pull_none>,
> +				/* lcdc_d19 */
> +				<3 RK_PB4 1 &pcfg_pull_none>,
> +				/* lcdc_d20 */
> +				<3 RK_PB5 1 &pcfg_pull_none>,
> +				/* lcdc_d21 */
> +				<3 RK_PB6 1 &pcfg_pull_none>,
> +				/* lcdc_d22 */
> +				<3 RK_PB7 1 &pcfg_pull_none>,
> +				/* lcdc_d23 */
> +				<3 RK_PC0 1 &pcfg_pull_none>;
> +		};
> +	};
> +
>  };