Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e0e3fb48-1c7a-f012-5308-4897bab01dfc@nvidia.com>
Date:   Thu, 19 Jan 2023 13:38:15 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH V3 2/2] usb: gadget: u_ether: Don't warn in
 gether_setup_name_default()
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andrzej Pietrasiewicz <andrzej.p@collabora.com>
References: <20230119102547.26698-1-jonathanh@nvidia.com>
 <20230119102547.26698-2-jonathanh@nvidia.com> <Y8kfdm9juBi58bnj@kroah.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <Y8kfdm9juBi58bnj@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWpUZmYvVUYzRGpjRGZhRDlzV2NUczhGZXI2dHFITlFzRUZiMitIbFNmK0hV?=
 =?utf-8?B?UWVJSkQzWUl4U2g4cHh2NGZUejkxa1h3elNkNXQyY0dabVlvQ2ZBVFYxZnBo?=
 =?utf-8?B?QnhBbm1mVDErREV5azhuYUw1bmF0bmRmL3owYkxiUHhzbHR4NXhQdnhWdEFV?=
 =?utf-8?B?YjlNYWxJaWJDQXNtZ3QvZU1PMXJ0cnNGa1Y4Y0JwMnh3RWlaZXpJWmh0SnNL?=
 =?utf-8?B?amh2TFJPdElNZnRHdjBlTzQ1ZWtPZXlqbXN5TTJORUt2UnJIWEZnb1FlMFow?=
 =?utf-8?B?OVBGZWhKZmZEbnZoY2Zqa1NiRFZPejYrVG83YVBvc2NzUGlMbGJuZU1CYXJY?=
 =?utf-8?B?M3hpdjd5K09HeWVNWWIrVlhJTWkwOVFPaFY3Ykp2V2dZUFlQVzR0UEhPc0JU?=
 =?utf-8?B?UnZNWm9LRjZEamp2L0NQYWxENGtpN0pDYUgzV0NyZkp2WW5TaGdzZW5jaGpv?=
 =?utf-8?B?cnJPYzZTNnF6em5uYXlmR0dHcElUZHJiRjZVQm1BaU4vVjJjMW9LT3g2QUdX?=
 =?utf-8?B?Wi9zNHlRWVR0Uk10Q09yY054bjVidTFSZVBZdGZVOEJiRTQ3MDMxalFRYnIw?=
 =?utf-8?B?aWlBV1B1bGZxdC9QRVJaNmdaZ2h1K0xJbUp2cEU3Zk5CUmdQUCtpcUZmZC9D?=
 =?utf-8?B?M28ybWlRT3R3WXNJalZoVmt4VjNsTktuM3lSektxWWk2ZGZnV1JUN3h4ekpQ?=
 =?utf-8?B?YVJpa2hzdzFFUEZ4eTl5L09TdVJmeGQrQ1pkKy9xQTNKREYrVFc4bzJnbUxX?=
 =?utf-8?B?T2Q0YkVnVHRPRUswN0QzVTJGUXRsNlJ6NmtaY1BkRmxOQ0cvQ1lFajg4WGgv?=
 =?utf-8?B?N3RlQWd4d0J5UGFQWkZ0RUpUNWtES2kvbmVBb21yMTl2WXRoRmhaaXRKWnVa?=
 =?utf-8?B?TGtValNVNTVEWVJDc2o5am9SVnU0ZVNZVTB0Q3ZQMVU4UmFoYTc2c1YySWJ3?=
 =?utf-8?B?MXhmNTNoRVVnL1V2ZitqSzVGbi9PZ2swOHo1d0l5WTdDbXFnOGZjMjRRc3NC?=
 =?utf-8?B?TFl5Zy9lK0tSYTRybzBWV25Pbnc1cVZZRVlndk4yS2pFeSs1ZktCQWFONHZ4?=
 =?utf-8?B?TDN0RWc0bzdsVlhNWW1QYWg2SC9sRzBsdU1SNGo1dnVTYmpCQTRvYkpNMzRW?=
 =?utf-8?B?emxqNEhRMUpvVWlKRGlmZGVGZFhTRzRMSTVMT0tTODZid0dxek8zQ2ZsNlp6?=
 =?utf-8?B?NlI1ZVc2RzZhbUQ5d0Z4VEVBR29wMHZBb2EvMmVzd0o4M05WSWNUNmVOWnNi?=
 =?utf-8?B?VlR1eVFVeU5oUWxPMjRKbW9xV2VvS2QwcWcyVlBpKzhpak5NZ2s2MXY3OFB5?=
 =?utf-8?B?aGs3NC9wSGFvLzY0MlA4aXVQZFFpZi94MTkwcEYzRU5BNzh0Rmw0UFM1d28x?=
 =?utf-8?B?RmxUdFVXKy9MSnAvaldVaHlPZzI5TFkzdGZDM2Y1RUVXRzlERldySE9sa1B1?=
 =?utf-8?B?S2pKSXVkMjQ0MTBkVm1wYkx4ZXFNMkNjMnJUTnJEWjI5dGR0ZGlGd1NOaG5k?=
 =?utf-8?B?eERzdUZsbkhORE9JZFdNVEJHQjcyWnlnN01sRXF4RkhsZVNyZGt4ZDVuRzZP?=
 =?utf-8?B?WE9va2tiWlpsN2gvS2lQcHR1SkpVVzZYamRad2lzUXgycXJ5TmgwUEluZnph?=
 =?utf-8?B?N21ERXFRRzlESU84N2dSbXZEdFNBd2I3QnVFcVRMOVBaNUJpb29ZOEJjS0lv?=
 =?utf-8?B?V0huNFJuaVo4d2ZmRkwwbE45UjUzYTdGelErR0p2d1VTYU8vMkxnK1hEUEpm?=
 =?utf-8?B?WS9pUGNBeTZuQ0N6dFRqUnZYZ2xqQ2I2NDR2RFVmM1kwUGwvUkxRV0FSbzgy?=
 =?utf-8?B?bFRpU3JaUngyeGExVTY2Q0piOEh2QVZqNjV4dVg3dGhFTWtIQ3BGUVVCdllI?=
 =?utf-8?B?RmE3ZWU2QTRHbHVOVHAwQkc3NHg0TFhKaFJvQTRScFkxdEFpbUh2OEVaWXpo?=
 =?utf-8?B?L3N1cVZXWXFsZzJwdWU5SFh0QS9LZ3hXMGF3L0pueVovaHdpclJWcnJ2Ym5O?=
 =?utf-8?B?TFlia3ltTVRJMXJ0QUN2MnRUYmU1bGdCeUltQ2dIcDFBcmdSRGZ6dE9HcktZ?=
 =?utf-8?B?UnNDbWtmWmwxazl6cTFHTUdKeWJ4RGdqUDhodFNHcEg0YjRPZUhRdkNzYU9Q?=
 =?utf-8?B?T3N0MTErU2E2Zm1GZ0hKZVZoSXlBNFNqK3h2Sy9xTUtnMFpXN2t1Zy9kNStp?=
 =?utf-8?B?Unc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a6f6fda-837b-4351-9882-08dafa230a7f
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 13:42:43.5623
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 170puEyT/jSCVypGXe+x5DRIm/kXQKa7hi1gY6RGpgUYReYqX3A1SM8d2M35cm3bYG6GuoJmx0RVcyJtceiLJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5405
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 19/01/2023 10:46, Greg Kroah-Hartman wrote:

...

> In looking at this further, you are right, the structures are not
> initialized properly yet.
> 
> So move these to a different function entirely, they should be in
> gether_register_netdev() instead, after the device is registered with
> the system.


I wonder if this is even necessary. Looking at gether_register_netdev() 
it already has ...

  status = register_netdev(net);
  if (status < 0) {
          dev_dbg(&g->dev, "register_netdev failed, %d\n", status);
          return status;
  } else {
          INFO(dev, "HOST MAC %pM\n", dev->host_mac);
          INFO(dev, "MAC %pM\n", dev->dev_mac);
          ...
  }


Any objection to just removing completely from 
gether_setup_name_default()? If we move to
gether_register_netdev() then I believe we also have to deal with 
gether_register_netdev().

Jon

-- 
nvpublic