Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 Jan 2023 10:16:34 -0300
From:   "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
To:     Pavel Machek <pavel@denx.de>
Cc:     Vignesh Raghavendra <vigneshr@ti.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-rt-users <linux-rt-users@vger.kernel.org>,
        stable-rt <stable-rt@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Carsten Emde <C.Emde@osadl.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Daniel Wagner <daniel.wagner@suse.com>,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        Clark Williams <williams@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Jeff Brady <jeffreyjbrady@gmail.com>,
        Salvatore Bonaccorso <carnil@debian.org>
Subject: Re: [ANNOUNCE] 5.10.162-rt78
Message-ID: <Y8lCspFtQ0wg6uCy@uudg.org>
References: <Y8VSslRJZpFbo1/u@uudg.org>
 <40de655e-26f3-aa7b-f1ec-6877396a9f1e@ti.com>
 <Y8krsVFguwWLy+zT@duo.ucw.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="RrHfV96HQrxQVFBx"
Content-Disposition: inline
In-Reply-To: <Y8krsVFguwWLy+zT@duo.ucw.cz>
Precedence: bulk


--RrHfV96HQrxQVFBx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 19, 2023 at 12:38:25PM +0100, Pavel Machek wrote:
> Hi!
>=20
> > > I'm pleased to announce the 5.10.162-rt78 stable release.
> > >=20
> > > You can get this release via the git tree at:
> > >=20
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git
> > >=20
> > >   branch: v5.10-rt
> > >   Head SHA1: 143ef105f40a65f3ddd57121d4b4bc36eb10cc06
> > >=20
> > > Or to build 5.10.162-rt78 directly, the following patches should be a=
pplied:
>=20
> > I see that vanilla 5.10.162-rt78 fails to build with arm64 defconfig. [=
0] Full log [1]
> > Any pointers on what maybe wrong?
>=20
> We see the same failure.=20
>=20
> >   AS      arch/arm64/kernel/entry.o
> > arch/arm64/kernel/entry.S: Assembler messages:
> > arch/arm64/kernel/entry.S:763: Error: immediate out of range at operand=
 3 -- `and x2,x19,#((1<<1)|(1<<0)|(1<<2)|(1<<3)|(1<<4)|(1<<5)|(1<<6)|(1<<13=
)|(1<<7))'
> > make[2]: *** [scripts/Makefile.build:367: arch/arm64/kernel/entry.o] Er=
ror 1
> > make[1]: *** [scripts/Makefile.build:503: arch/arm64/kernel] Error 2
> > make: *** [Makefile:1837: arch/arm64] Error 2
>=20
> The line is:
>=20
> >        and     x2, x19, #_TIF_WORK_MASK

I believe this is related to the arch/arm64/include/asm/thread_info.h
changes in 5.10.162-rt78, specifically:

    79a9991e87fe arm64: add support for TIF_NOTIFY_SIGNAL
    1ba44dcf789d Merge tag 'v5.10.162' into v5.10-rt

The first one is the original change, coming from stable v5.10.162 and the
second one has the merge conflict I fixed in that file due to the existence
of TIF_NEED_RESCHED_LAZY in PREEMPT_RT.

It escaped me that having TIF_NEED_RESCHED_LAZY set to 13 breaks the AND
statement reported above. Looking at

    b5a5a01d8e9a arm64: uaccess: remove addr_limit_user_check()

specially this note

    To ensure that _TIF_WORK_MASK can be used as an immediate value in an
    AND instruction (as it is in `ret_to_user`), TIF_MTE_ASYNC_FAULT is
    renumbered to keep the constituent bits of _TIF_WORK_MASK contiguous.

I understand that I need to either have to renumber TIF_NEED_RESCHED_LAZY
to 8, with the risk of breaking something else, or backport commit
b5a5a01d8e9a in order to remove TIF_FSCHECK and then safely renumber
TIF_NEED_RESCHED_LAZY.

Guidance is welcome here :)

Best regards,
Luis

> And I believe there were some cleanups in stable in that area. Let me
> search for them.
>=20
> Best regards,
> 								Pavel
> --=20
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


---end quoted text---

--RrHfV96HQrxQVFBx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEk1QGSZlyjTHUZNFA85SkI/jmfCYFAmPJQrIACgkQ85SkI/jm
fCbnbA//Zj+o1GrFLzhK3mDWQHoDRlUtgAEk0ctO3VLzBr8SZTskqJW1x47Ihfgq
BNFy7MLSniqu7fyJgEzH/0arW/+3qoOy0T61NybJv5HIUj00m37Ah4CVjVXNSpGB
Io9uCy6JdbzEmhDGAZ1iSjvowjhlzKcdM9226BVn0BMMJqy2s2j6BCykZn7YabmI
h4VelQTIJYlfSvxZsp0iK3l3Z9GRCDoSyduvnRX07siiWOZfXRRHp2XIhEHKvE/R
3LXrqYv576mF2nfY0QIYo27rhJd4RZ1X7ADKfGx13pZVyObNsyoKwdtGyQqnynRD
lxfYMW3B0mwXfrhR5soYvv/xaSqthNthjkxY+3oNTpltYxx0DzESXxXywefNseZE
3KITzG8drms7H9bzw8tVVwHeD2KtrkswsUNRCNyDpsI4klyujxwZWubkrgMd1Ja9
wGDrP+f3OGzlv62qVgBMfVV8vMrO4Xlvr/QqKywqFkAmwiX7BnDFuhSpcwQrZruF
rgEyCCFmIpDwejWGVH5ccl0tU6d5psju8taFO6ImPI9bACJ8UxqsgnGgkIl6iJRH
HCa0RRSQ5zmSj4ZOKbLUrAnNhcSmwELKdrMNI7rstN2a0hIsRxK8o5RE81sPOJAg
nppOugBmH75Jce8q5m0ZbtnJ0CrDgfM7hsH65ZgwDGiEmWGX55E=
=V2rh
-----END PGP SIGNATURE-----

--RrHfV96HQrxQVFBx--