Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b16c0134-b8a6-573c-4ad9-c4620fc98d5c@i2se.com>
Date:   Thu, 19 Jan 2023 18:28:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 0/4] gpiolib: get rid of exessive
 ->of_gpio_ranges_fallback()
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>
References: <20230113215352.44272-1-andriy.shevchenko@linux.intel.com>
Content-Language: en-US
From:   Stefan Wahren <stefan.wahren@i2se.com>
In-Reply-To: <20230113215352.44272-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:YJCObP7Zmsg=;+MbDRnIRKM8+p3rT3vi2DFL1Bgf
 0wt5aJSJ1ijrbN4WRR/lMzwLoMM+st/vv34oy7RQz9lPj3xZboy1H5uVuSthsvFP8xl5IlwyV
 DjbATypWLO8mb2Nbu7A1icqezGH0Dcyl1RMQ/Vmf6ESOn3Nz0tN8LqIA0jRhoi+b3AqxscjXm
 pm6dDJzUyQAllVZH6x3DgiJ8Xqqq32Fnv1kmw9kJmvegs7McGvsmUGdxScU48dtKKsS/feFwk
 3W9GD5pCdArZq8R5+DMKV4l4Bsv0GQm0tBpQXT3LJfAYqZk4utKpw5l/yqTsxP24uTQiQ2VYX
 VU/e/n07+RHZ8cswk2xo9d/0K0mReEjkSf0YTFBUc7zunD8KripOQ1/D354LNSjQKNuu9AKvv
 PSLO4aHXTEr6gDDxHwjmO6oplpNMyN3eNtKKAAJYdGnDSF8bCsownj0qSBAIt5cwUwXky9tR1
 fUeculjxGrCiqkxCwTBTQXH/LCAkqWXP03wChJrXUZGI/JYEmy+7RWNXokV70DwHbK9cQrCty
 xe/57X/C9/qISYHBghaddqf/Td5MB+vnwYmVeeRpOIyjOUBuk1eXYE89MPtCxQC+pjN4eW8Se
 Km3LnbdjDAhbbGBBYcxYsqK8qLaUwhXU+r7AGuezaKbtwuRAzPw2bkHo7xdDaYkaj6Hj++/Wm
 2K8eJBKK45VvLdxKnN29b7x3xgJWEMx7xOFUYAgusQ==
Precedence: bulk

Hi Andy,

Am 13.01.23 um 22:53 schrieb Andy Shevchenko:
> The ->of_gpio_ranges_fallback() repeats the idea that lies behind
> ->add_pin_ranges(), while the latter covers more cases that the former
> hook. Drop the former one for good.

i successful tested booting of this series with multi_v7_defconfig on 
Raspberry Pi 4 (with and without gpio-ranges in DTB):

Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

>
> Changelog v3:
> - moved check of the property presense to GPIO library
> - split out the refcount fix in a separate patch
> - added cover letter
>
> Andy Shevchenko (4):
>    gpiolib: Check "gpio-ranges" before calling ->add_pin_ranges()
>    pinctrl: bcm2835: Remove of_node_put() in
>      bcm2835_of_gpio_ranges_fallback()
>    pinctrl: bcm2835: Switch to use ->add_pin_ranges()
>    Revert "gpiolib: of: Introduce hook for missing gpio-ranges"
>
>   drivers/gpio/gpiolib-of.c             |  5 -----
>   drivers/gpio/gpiolib.c                |  8 ++++++++
>   drivers/pinctrl/bcm/pinctrl-bcm2835.c | 10 ++++------
>   include/linux/gpio/driver.h           | 12 ------------
>   4 files changed, 12 insertions(+), 23 deletions(-)
>