Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1372124rwb; Thu, 19 Jan 2023 09:44:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXsFBlUvQv8gLMiiB41ekHs98sK42fc8bHc1/IV0YqSj9NhTnu/OpLG76ZDgLsq2Mtb7hkDf X-Received: by 2002:a17:902:8c94:b0:193:ab5:39c7 with SMTP id t20-20020a1709028c9400b001930ab539c7mr12371761plo.11.1674150265323; Thu, 19 Jan 2023 09:44:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674150265; cv=none; d=google.com; s=arc-20160816; b=rs+adwk5h40ngXPxGlE+yQeiyipKEjpi1OGbt2IQ2vqOyjwQQmxidEcdaW9750ZSPY oA/mpWQuVKybVEewNTScRT0uS8Pkcl1IaGESDtxFqxIZLBbxToPIWIHT2zbuFd7RBk1H 781wV1815geFKudkdvK9DwJE2jItHMd3W73mNdYO8kEfjWPP99UnndUSiMaSZWnXOo6Q zYrER4EVSijs+hzKRUXORVtjh0oMaE7bK3/ADwwSLTqLWN4J5SK24RRWn4H/a15os7ZB +ulBpPa45vruPthYDV2ONc4ZRJOZXikoA7DhP+//Jhg0OW4b+Tr2oG3PEKDh/it57ehG ZA5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=2aidwM5DJaS3T8vEx2JrlSPToIVIffo/fMisHoQ8PjQ=; b=auX4TK6u3qPVDnxlYUg05eO2kya3BiOhDMFMrisvT+vZEwhpfLCkhA1RT6+nPZxv/V jhP4E2bdfM6KiIilzQk0HZju3kUv6GUg1qlCAsCedCX1/6qykCcGuCSmfuPop3v8X53k lNIUObGi7d/cOm7+iOsGML3W+FC7OO1Zwzxw3ivuPiWp34+nw6Tx0Wke/Bl0oTRMWr18 wKBWPVMks1XUgTumkAbQ62oEiWgapnGVFvBhrUEhvj98MzoEtkhzLH9ZhhY0MR0bVEC9 7XsyI1VV5WlKGvIvYDcAKZEHJKDuJFGacsbghu7hX90zFqi9cCdDyU8KdTGdghYQpUos /mXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y7-20020a1709027c8700b0019488af7e99si14317197pll.581.2023.01.19.09.44.19; Thu, 19 Jan 2023 09:44:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbjASQny (ORCPT + 45 others); Thu, 19 Jan 2023 11:43:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbjASQns (ORCPT ); Thu, 19 Jan 2023 11:43:48 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB25A7EE5; Thu, 19 Jan 2023 08:43:47 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 4BF5E68D0D; Thu, 19 Jan 2023 17:43:45 +0100 (CET) Date: Thu, 19 Jan 2023 17:43:45 +0100 From: Christoph Hellwig To: Yu Kuai Cc: tj@kernel.org, hch@lst.de, josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH -next v3 3/3] blk-cgroup: synchronize pd_free_fn() from blkg_free_workfn() and blkcg_deactivate_policy() Message-ID: <20230119164345.GC3332@lst.de> References: <20230119110350.2287325-1-yukuai1@huaweicloud.com> <20230119110350.2287325-4-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119110350.2287325-4-yukuai1@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The this change itself looks good, but it will clash badly with my "switch blk-cgroup to work on gendisk" series: Reviewed-by: Christoph Hellwig Can I get some reviews for that series once I rebase and repost it after this series is merged?