Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c990cea-16a7-14c6-3328-632c14df0388@seco.com>
Date:   Thu, 19 Jan 2023 13:17:20 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH net-next v5 0/4] phy: aquantia: Determine rate adaptation
 support from registers
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Tim Harvey <tharvey@gateworks.com>,
        Vladimir Oltean <olteanv@gmail.com>
References: <20230103220511.3378316-1-sean.anderson@seco.com>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20230103220511.3378316-1-sean.anderson@seco.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEd5THZ2MEphVFcyVjZhbU1vMit0bE4wYWZLQkZqaGplWGdwWS82VE1wM1hY?=
 =?utf-8?B?WWU3ZjhWdXVJejVBdEN0NHhwMURIdkdMNzk5S3VReVdodHZKYWJrOGE0a1Fk?=
 =?utf-8?B?aXRiWW9DaVovdXEyL1ZidmsrWmlNSjZYNmJCdFNCbFBKbjNlSStJV0tQT241?=
 =?utf-8?B?akdKc25GL2xMQ0lKa1NRZnVOTnRVcEt1MFJsMXFVc2k0ajhQWkd1L0QrQUhN?=
 =?utf-8?B?Z1JiU2ZBQzlWVGE2NkpvR2FNc3F2MkdySTh3aWpYd2hNMUdmN2hyTFIrazV2?=
 =?utf-8?B?MFQ5Lzl4SFdEalk2TXN1K2RCZkpVNlFEMERzZE8zRDlTQXdKMXBNMFNRN3FQ?=
 =?utf-8?B?NGt1djdYZnhkOGJnTlJuTnNOQmxTbEo0cmZ4L1JFU1hiODlOY2xsK2F6QXE4?=
 =?utf-8?B?R2taeS9wdzFvNGZNb2djV01mSUZmU2pGQklqcFFnY3lkU0hZT09jMXBaTWJV?=
 =?utf-8?B?NW1LOHFYdXBWODNGakQ5d1pCTjdRdlQxM0lsRHkvTUtrMmxjOGUvVTZ2VW53?=
 =?utf-8?B?MzFWb2RMQndjYVNURzBVeDBlenlQK2d6TDlhd0YvMGJsQVlHMUJDZ1BnMHBD?=
 =?utf-8?B?b0Q2M2R5ZTluU0JYeFNVZDlUZXVpZk8vSnRQaUVBV2E0dmRaTjIyb2FTU2V0?=
 =?utf-8?B?UjdMZFhYNzRselJtbmNEYW9FcFBPWGZOQXhwSk9yVGdUY2Nnc0NCWVlyN3ZG?=
 =?utf-8?B?V2hGaHd5eDZ3U1JRREJ1MlVPS0NiWEZWdkVhN3RLWDZyTFgzZDVUL3o3YTBJ?=
 =?utf-8?B?YzJYTEptcmk2NERoUVVtUi9XL1pOY0htR3cwVG5wT3RBT3pvL09mY05Od1NK?=
 =?utf-8?B?R2JnbHdXWVVPZjQ5SlBBcFVKcEJsQnJBeFhYeldDUks2NnNkdlBJZnkvb3Rw?=
 =?utf-8?B?MlRZRFk1TlpRZ2MvVTJCa3NGMUkyWm9nVHZselh0RzlOcnl3a3ZzMHpqVFpP?=
 =?utf-8?B?MndZWG0vQXhhcEF0SFYxU0EzT1BuUWtqL0FzcGF5K1dSWnhPRjlqWlViTlBZ?=
 =?utf-8?B?K3FReS9CMlZtSFdrN0U3Y3c0cDRPa3paZ0RqVW1ub2VFMnZaTTdGTktDbVp3?=
 =?utf-8?B?S2NJdWRFQ2E4WlJJQ05CZnFwVThEemFBbFBNM2k5MDlZdnB2M1RmeHpWUC9j?=
 =?utf-8?B?bzhyRTV4L3hVaXlFK0hkaDRycnRFa2dTZHFSVVg1R2dqS0NBMkhTTXBOcG5a?=
 =?utf-8?B?UGxjZTBNMGdGcGhzUFU0NEFxMTlCb1psUXo3WWRSRHZXMDR2b1U1TlFNaVFx?=
 =?utf-8?B?UVl1SUx4QnFuc0Q3N014R3pyZU12RWJobURod2E4MVdpRjBGM2hQcVU5N2xp?=
 =?utf-8?B?ZGpnc2Z2RUZidTJ5QU9tNThLdWcxQXdTcFIyaVBXb01rUlVxOWp3OGFEbi9B?=
 =?utf-8?B?M2NrREpUUUlydG5aTDBVOXlPcDN6SDBQTFFQc1lkRXd0ckFWNVRva3NTcEtC?=
 =?utf-8?B?NkFQbVVwWFdmcjFMZms2eDZuZkxiOTArYWhBKzlsY0tXcFJkZWYxcWYxMjJB?=
 =?utf-8?B?VWNGWmc3QnRYclo0VWIzeXBFM25iSlRvTFdzajd6Z2ZtQnNZZTI1ZDdRWVJ5?=
 =?utf-8?B?a3IxUFZscm9HQzJOblpjVFpDZVIveDNRM1BmcHBERmNiZUEwQ1dGQU9Weks4?=
 =?utf-8?B?WkxmZFhrZkY1NFJacWd0c0d6VmcrRUF4ZFFpNUppTHMwK3Uva3JVWEN6bEl0?=
 =?utf-8?B?R1FyVndWaEtRNWVKaUpLcTNOUTFwSGczb1pkMkZkbG5nZnVRSVM4SHhMUFZV?=
 =?utf-8?B?SlVWTHc5M0lTUVFURFprY0pXUzRzVFNnMUtIKzVIdTNkeE9JWG9RSDA0aUJ3?=
 =?utf-8?B?RHpSUE1xc1gwQVh1ekNITHhvUFJPMXZUcnhtODhTZGNMWDFBdC9OT0VTZ0xH?=
 =?utf-8?B?U0JXU3BKcDg5NDJHdElqVWxrZHRBMG00YVBGMUpYSzRhanNhRjFuZHJCT3Bh?=
 =?utf-8?B?SzUySG9pTVd3U3JVRjZ2a2RWK1l6anF6NWY3WWNUVWJ6Skt4UWY5dW9jNzZp?=
 =?utf-8?B?M0c5NEZpa2VBZG9lcHlxY0o5T3VodDZLWnRGcHBvbmZuWmI5ZjBYMEEzVEV2?=
 =?utf-8?B?ODZMek1OazU0aXVLM3hUSWM3b1FyVnRsaDd2L2t0NG5xQ1crKytOT1RmVDRH?=
 =?utf-8?B?cDBVK0ZOeWtxSXBkalNDck1acHRydWllNGNhOHJyZTB2QW1XVGhSZE9LSUY4?=
 =?utf-8?B?aUE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4ea509d-2637-49a2-e793-08dafa496985
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 18:17:23.8161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z9LkqcQPJ0vHGTVlcoBal1HGIFYp7RZ4rEy1YHKpz9EkiIIf2SPLDBz/u26pR/V1w0DyuvUUfm0Y6XQTsxHBsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB9077
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/3/23 17:05, Sean Anderson wrote:
> This attempts to address the problems first reported in [1]. Tim has an
> Aquantia phy where the firmware is set up to use "5G XFI" (underclocked
> 10GBASE-R) when rate adapting lower speeds. This results in us
> advertising that we support lower speeds and then failing to bring the
> link up. To avoid this, determine whether to enable rate adaptation
> based on what's programmed by the firmware. This is "the worst choice"
> [2], but we can't really do better until we have more insight into
> what the firmware is doing. At the very least, we can prevent bad
> firmware from causing us to advertise the wrong modes.
> 
> Past submissions may be found at [3, 4].
> 
> [1] https://lore.kernel.org/netdev/CAJ+vNU3zeNqiGhjTKE8jRjDYR0D7f=iqPLB8phNyA2CWixy7JA@mail.gmail.com/
> [2] https://lore.kernel.org/netdev/20221118171643.vu6uxbnmog4sna65@skbuf/
> [3] https://lore.kernel.org/netdev/20221114210740.3332937-1-sean.anderson@seco.com/
> [4] https://lore.kernel.org/netdev/20221128195409.100873-1-sean.anderson@seco.com/
> 
> Changes in v5:
> - Add missing PMA/PMD speed bits
> - Don't handle PHY_INTERFACE_MODE_NA, and simplify logic
> 
> Changes in v4:
> - Reorganize MDIO defines
> - Fix kerneldoc using - instead of : for parameters
> 
> Changes in v3:
> - Update speed register bits
> - Fix incorrect bits for PMA/PMD speed
> 
> Changes in v2:
> - Move/rename phylink_interface_max_speed
> - Rework to just validate things instead of modifying registers
> 
> Sean Anderson (4):
>   net: phy: Move/rename phylink_interface_max_speed
>   phy: mdio: Reorganize defines
>   net: mdio: Update speed register bits
>   phy: aquantia: Determine rate adaptation support from registers
> 
>  drivers/net/phy/aquantia_main.c | 136 ++++++++++++++++++++++++++++++--
>  drivers/net/phy/phy-core.c      |  70 ++++++++++++++++
>  drivers/net/phy/phylink.c       |  75 +-----------------
>  include/linux/phy.h             |   1 +
>  include/uapi/linux/mdio.h       | 118 ++++++++++++++++++---------
>  5 files changed, 282 insertions(+), 118 deletions(-)
> 

Although there was a lot of discussion about the final patch, I think the
first 3 are good changes. Can we apply them as-is? Should I resubmit?

--Sean