Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5f6a7d5-0301-0c51-d663-775d06536e0e@intel.com>
Date:   Thu, 19 Jan 2023 10:28:50 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 7/9] igb: Remove redundant
 pci_enable_pcie_error_reporting()
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>, <linux-pci@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
References: <20230118234612.272916-1-helgaas@kernel.org>
 <20230118234612.272916-8-helgaas@kernel.org>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20230118234612.272916-8-helgaas@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmJFR25NVmdNWGJFeFI2L2FtWGQ1NzNkeWIzUlZSQTl1dzJqQUsrVmFKVDJV?=
 =?utf-8?B?b0FHWGN4WXBRdm1mbWFoby9uTFRmRWpUZEpOTllOZWNkYTUxOWhVb0FGbDl3?=
 =?utf-8?B?Nk1pdHpBMitwMzJQTzk2TXVicTVUazMyaDlPRUdPN0Joc0ZaVDlrRlZuVklM?=
 =?utf-8?B?M2hxSHNLMzBSdjJoeENBOUxwOERSTUxOcXQxdzRmeGNnRWsza09EUXNSMXRC?=
 =?utf-8?B?V1duOU5qbU9HQ2RtZzZBTUhIbXhBNFpxS3k4R21lbmZlWWJ3YjZNQnlZQUdr?=
 =?utf-8?B?bVlvSVRudnJ4TEw2cWlhZitlWE5SRDJhaEhYN0JtbmV6RXlTdkdTUFFJajBL?=
 =?utf-8?B?YTZYU0NqQ29EWjEyU3BWMDNlNXNlSnNHS3B6ejBjQmxHckVSSlNocFVuakRB?=
 =?utf-8?B?Nnp5VTVxZzlSbzVxOWNiWmlMYWNWanRqMFBFUDJZN1VsUlVzK1JnZW1UODhS?=
 =?utf-8?B?V2FHZWM4eE1USitlR2dFYmRHWTlUbHI5aCt1UVRmYWxoRC9WS2N2aUkvam5i?=
 =?utf-8?B?d0JmdURuOWtpZ1FvaXZoQ1ZZWEZwVm5zenBodGVqYVZjM25HYVltSzF4dktK?=
 =?utf-8?B?MWUzQ3RFVVErZHd6MXZ5WmI2N1dWbFRmN3BZbUR2ak11Z3FUYUM1dFAyVVM1?=
 =?utf-8?B?eUdpLzA0bEdiaVN3dlJpK0YrcFlsK0RiRU8ya3R3bVYzTUE3RktYWjU1dE0v?=
 =?utf-8?B?RHZUZWxIUTRHUlBVZ1AvOUFpeHpwbCtkSXNZa3cyTDVaaC9NWThPcUVkM1No?=
 =?utf-8?B?d21KVE1MdGRBdG0rUjBGMUJkQUc2Q1drUllGWCtJVHBjdS9aTzlpbkZGSXZO?=
 =?utf-8?B?VUsyUWY2Q081Ulo4VlpheCs1enlaVHd5UTRWTldHT2EyVmkyZ3MrTit1cWEx?=
 =?utf-8?B?SDVoZ1hlQkxOak9xUVE2YjFMN2ltd25vNllNblJlc1ZId3V1WlgwaGF6UHZW?=
 =?utf-8?B?OHg1TG9Vb3EwYzQxNTZ5b3NBRVk0TmJTTFNDRUZyM1g3ZFE0OHV2RVBvSC9P?=
 =?utf-8?B?QitPdlJGT3E5dW4wcTRwWStDdFYzNXcxRmp5SUdwdjNBMXNpNUhJMjNyWXJT?=
 =?utf-8?B?K0xIdys1aTZLQUIvZTA2SXpQQUcwTUVXb3NIZHYxVW9Ha2QyR0dqUGJqZk5o?=
 =?utf-8?B?OVhGZkt1QUh0dGU5Sk9IQlpkazl0RkZsSFR3N3luZTdVYlM2dUdaREVtcTBQ?=
 =?utf-8?B?bURUcFZ6bWQzUGVLd2N0NUQ4YVZ0L1lYWUh2MkVqdTFlT2JQYjFVV1JQWXg3?=
 =?utf-8?B?emFMRjdCR1JxRmtJTURYeGE0YlhPWHVSSktad0VDWjVyN05iVlREOW5JVmNH?=
 =?utf-8?B?cUpwZkt3clJ3SHN0RlNEMDVBNnZ1bktUcnNBVHdlancyWmlXd2VTelAwSU90?=
 =?utf-8?B?cUVySk5jM2JvUzdsTGpERzlkV2Qybkc3VjVTQ2NWeXVuSjJVTU16LzFSb3Nm?=
 =?utf-8?B?enBpNUhTMEdYM00vQkpFTEwyMVB0a2NXbUUwdWVNVHZrVlVjWmZjcnlhMnJ2?=
 =?utf-8?B?dkdpTmpwelNlUFp0YkdVZ1crS0NYazI3aUh5T0pMVDdGT3Jqd0xmL0ljVmdD?=
 =?utf-8?B?bUdMOWJYQ2VhWDVqUHROcVVzRU8rVUFHZTl0d0JMKzFVbnJIcmg3QTNpOGM3?=
 =?utf-8?B?MFRVbWNaVC9oWXo3emtyVDQ4MUFKSGplZmVQOWU5RkFCQktqWlZTclE5cERl?=
 =?utf-8?B?akJSR1gzUm00UjNocjRZSFFxS0N2ZGJzdjNjcEl5OStpMzNpTmdpcWw0TXo5?=
 =?utf-8?B?M1ViZVZNVVJuMVNCNjBGN2xkc2RlekY2NTI4aEduVzhVZHcwb1NzY282SGp0?=
 =?utf-8?B?WUp3dUlCQllidDh5eUplaWlHZGFFRXpObnM3WEk4Z29UTUEwdnA3Y3YwUDBZ?=
 =?utf-8?B?YlZjZFh2SUkwVVRFWm9OZHJsNndsMllKZzY0aWJiZ1VnTU1DZGQ0RFBmRkJB?=
 =?utf-8?B?b2F5UFFqeDBtMXBNYzAyMngrclV2b0Z3SzJqRjVyWDEwTytFT09ROCt0dENl?=
 =?utf-8?B?L2NSYXFGRnc0SDFNRGVEM2dvZTRlSmJTTGRaQ2U5ZFZtM3RzSk9xUjh1akND?=
 =?utf-8?B?NnRLL2Vid3RXMzVUdFJnenJoZHBYeWxMNWtTeGFwS0dCM2hHditWYU5ZOTVz?=
 =?utf-8?B?MTNHSEVpMFBBaVZCUWdxUEFUK2Fsem9NT2U0RDFyOEc0d1JaSmJUZ0VjWmJP?=
 =?utf-8?B?NkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0adaca28-6032-4d18-5058-08dafa4b0453
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 18:28:53.0594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +R2y6V1KcsO1B92BdMCpIFDG9hwkdSjThleGwMV5Bkbb8R+GNh7v9VVuFpM+PAxrrO4cxiCuXACAIp7h0r9/ug0kJynv9UUdc87kHIu68Xk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7410
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/18/2023 3:46 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration.
> 
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
> 
> Note that this doesn't control interrupt generation by the Root Port; that
> is controlled by the AER Root Error Command register, which is managed by
> the AER service driver.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> ---
>   drivers/net/ethernet/intel/igb/igb_main.c | 5 -----
>   1 file changed, 5 deletions(-)

Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>

> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 3c0c35ecea10..c56b991fa610 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -3194,8 +3194,6 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	if (err)
>   		goto err_pci_reg;
>   
> -	pci_enable_pcie_error_reporting(pdev);
> -
>   	pci_set_master(pdev);
>   	pci_save_state(pdev);
>   
> @@ -3626,7 +3624,6 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   err_ioremap:
>   	free_netdev(netdev);
>   err_alloc_etherdev:
> -	pci_disable_pcie_error_reporting(pdev);
>   	pci_release_mem_regions(pdev);
>   err_pci_reg:
>   err_dma:
> @@ -3837,8 +3834,6 @@ static void igb_remove(struct pci_dev *pdev)
>   	kfree(adapter->shadow_vfta);
>   	free_netdev(netdev);
>   
> -	pci_disable_pcie_error_reporting(pdev);
> -
>   	pci_disable_device(pdev);
>   }
>